Live data from Hacker News

"Careless" employees

niniane.blogspot.com

21–30 of 83 posts

Re: "Careless" employees

#21
I think these are all fantastic things to implement but do you know how much pushback you get from engineers on this:

Me: "Do you have a standup every morning, so that you know about schedule delays after at most one day?"

In general folks HATE these, but I would love to hear other cases where people have found them successful. We are small enough that the conversation is ongoing so haven't needed to implement it.

What I have done in other cases is the "walk-around" to speak to people individually rather than in a massive group meeting - and that seems to have been well received.

Re: "Careless" employees

#22
post #20

Code review ranks just behind design review in value (cost/time savings). In fact code reviews are so beneficial that if I was working on a solo project I would either pay for them to be done or review the code myself after a suitable cooling off period, depending on what I was working on. On the other hand, I have also witnessed sloppy, lazy code reviews that catch nothing except the occasional typo. This amounts to…

I find that one of the causes for wildly different levels of code review (and value derived from them) is a lack of training. There is a real lack of materials for explaining how to do a code review, how to do deal with the human aspect of giving feedback, what is/is not valuable to talk about (arguing over tabs vs spaces should not happen in a code review). Most of my experiences have involved a trial-by-fire proces…

I agree - and your comment gives me an idea for a series of posts on this exact subject.

Re: "Careless" employees

#24
post #5

Great read. This sentence sums it up best I think, "Why, why, why would people expect to get great results if they flaunt all the best-practices that have developed over the past 20 years?"

I don't think he's using the word "flaunt" correctly. It struck me as off -- sure enough, the definition agrees with me. "Flaunt: to parade or display... conspicuously. The use of 'flaunt' to mean 'to ignore or treat with disdain' is strongly objected to by many usage guides.'" http://dictionary.reference.com/browse/Flaunt

Quit blaming the individual and focus on the system dang it.

Re: "Careless" employees

#26
post #5

Great read. This sentence sums it up best I think, "Why, why, why would people expect to get great results if they flaunt all the best-practices that have developed over the past 20 years?"

I don't think he's using the word "flaunt" correctly. It struck me as off -- sure enough, the definition agrees with me. "Flaunt: to parade or display... conspicuously. The use of 'flaunt' to mean 'to ignore or treat with disdain' is strongly objected to by many usage guides.'" http://dictionary.reference.com/browse/Flaunt

[deleted]

Re: "Careless" employees

#27
I am going to approach this a bit from the other side. And I'll make it personal, rather than asking a series of indirect questions.

More than once, I've ended up in a position where I've put considerable effort into fixing what are often frankly the shortcomings of other co-workers. Co-workers who sometimes may be observed to be very busy discussing their weekends, or the latest movie, etc.

I've fixed conditions that come about as the employees responsible continue to be rewarded, promoted, etc. -- in short, considered "acceptable".

I tried to do what I felt and what I had been taught was "the right thing".

IN HINDSIGHT: When you find yourself persistently in such conditions, when the problem is not a one-off, GET THE FUCK OUT. Unless you can very demonstratively take control of the situation -- of the conditions -- and steer it in a better direction, you are caught in a system that will chew you up at the least and most likely, sooner or later, spit you out.

As a relatively unempowered employee, the single solution to bad management and counter-productive compensation, is to GET THE FUCK OUT.

Anything that prevents your mobility, e.g. employer-provided health insurance, a non-liquid mortgage -- I won't, I refuse to, add "a family" to this list. But otherwise, any such thing becomes an anti-pattern.

One perspective on what is wrong with U.S. society these days: So many people locked into anti-patterns.

Re: "Careless" employees

#28
This may not be obvious to some people (like my boss), but code reviews alone is insufficient; having a good technical design early on is more important.

I've sat through several "code reviews" and they're always conducted at the end of small-ish projects and when I look at the code, I would very much want the guy to rewrite it but by then it would have been too late.

Re: "Careless" employees

#29
I definitely agree with all of the sentiments in the blog post. With the exception of daily scrum (we do twice weekly), we try to follow all of these habits. There always seem to be two things which we run into though; superficial code reviews and haphazard integration.

On the code review side, I find that most engineers look for trivial crap that could normally be picked up by running lint. It's nice to have similar lint-y style, but for me, the most important things to look for are whether the code is going to break with unexpected input (ie. is the logic sound and are the unit tests good enough), and did the engineer write in an idiomatic style which would be easy for other engineers to understand. I don't mind comments like "maybe use this other variable name", however using recognizable patterns which allow other engineers to easily follow the logic is much more important. Often it seems like people get lazy during reviews and write really superficial comments instead of taking the time to really get down and dirty in another person's code. And why would they? They've got their own code to write.

The other thing I feel like I'm always up against, particularly with younger engineers (sorry younger engineers!) is not thinking through all of the integration points when your code needs to work with other code which is being developed concurrently. One engineer will say something like "Oh, just call function X", which when you do, doesn't provide the functionality which the other engineer was claiming it had. That, or there was some additional step which one engineer wasn't being explicit about and there was an assumption that you were going to take care of it. There's nothing worse than finding this out on the last day of the sprint when you're trying to button everything up.

Re: "Careless" employees

#30

Code review ranks just behind design review in value (cost/time savings). In fact code reviews are so beneficial that if I was working on a solo project I would either pay for them to be done or review the code myself after a suitable cooling off period, depending on what I was working on. On the other hand, I have also witnessed sloppy, lazy code reviews that catch nothing except the occasional typo. This amounts to…

That code snippet is a matryoshka doll of brainfuck.
Post reply on HN