21–30 of 46 posts
Looks interesting. I see they also contributed a fix to the OnlyFans notification robot. Clearly doing the important work that the internet needs.
Like if Batman turned out to be bad at fighting criminals so had to fight null pointer exceptions instead.
Given that the issue already gives a before-and-after metric it's extremely odd there's no POC PR attached. This just seems like an AI slop GitHub issue from beginning to end. And I'd be very surprised if VS Code performance could be boosted that much by a supposedly trivial fix.
Even if it is a real performance issue, the reasonable fix would be to move the sort call out of the loop - implementing a new data structure in JS is absolutely not the way to fix this.
(Somewhere in the pile of VSCode dependencies you’d think there’d be a generic heap data structure though)
I feel with Valgrind (in C++land) or VisualVM (JVMland) stuff like this is very easy to zero in on. I don't work in JS-land.. but are Electron apps difficult to do performance profiling on?
> Real-world impact: With 50+ view parts (text, cursors, minimap, scrollbar, widgets, decorations, etc.), this wastes 1-2ms per frame Good thing to find...
How does it possibly take 1-2ms to sort... 50 items? I'd expect that to happen in an order of microseconds
I’ve had agents find similar “performance bottlenecks” that are indeed BS.
> This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Given that the issue already gives a before-and-after metric it's extremely odd there's no POC PR attached. This just seems like an AI slop GitHub issue from beginning to end. And I'd be very surprised if VS Code performance could be boosted that much by a supposedly trivial fix.
also no discussion of measured runtimes for the rendering code. (if it saves ~1.3ms that sounds cool, but how many ms is that from going over the supposed 16ms budget.)
Looks interesting. I see they also contributed a fix to the OnlyFans notification robot. Clearly doing the important work that the internet needs.
This is what I want to do when I retire. Maybe not OnlyFans fixes specifically, but just go around fixing random stuff. Like if Batman turned out to be bad at fighting criminals so had to fight null pointer exceptions instead.
A bit sloppy but easily resolved - surprised it took so long to notice, or maybe it was new?
> Real-world impact: With 50+ view parts (text, cursors, minimap, scrollbar, widgets, decorations, etc.), this wastes 1-2ms per frame Good thing to find...
How does it possibly take 1-2ms to sort... 50 items? I'd expect that to happen in an order of microseconds