Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

OpenTofu may be showing us the wrong way to fork

infoworld.com

Post reply on HN
Print view View original

21–30 of 37 posts

Re: OpenTofu may be showing us the wrong way to fork

#21

Post by emestifs »

I have no horse in the race, but as an outside observer, and involved in some small open source stuff, I find it interesting the dynamics of these kinds of large public events and forks. Looking at the contributor activity from Aug 13th 2023 to today, there seems to be slightly less activity in the OpenTofu repo vs the original Terraform repo, but small sample size and just eyeballing it, don't take this as an accurate statement.

I wonder how viable this fork will end up being. To contrast with the recent Redis debacle, Redis is by some measure a completed piece of software, as suggested by the Redict fork. But with the moving target of the Cloud, is Terraform in a similar bucket? Will there be enough support behind this fork 5 years from now? And by support I don't mean is some big tech company's logo displayed on the website - are there multiple contributors or is it some random person in Nebraska doing what they can during evenings and weekends?

Might be an unfair comparison, but I'm reminded of the Reddit API uproar last year. It did what exactly? Reddit IPO'd, got their cake, the people who threw up their arms got what? Some maybe left, others just quietly returned to their corners of Reddit and continued using it? Will these large publicity forks end up being healthy and viable or end up open-source abandonware that once promised the world?

To be clear, I'm all for competition, FOSS, and all the stuff. I just genuinely worry about big bang, high publicity stuff. Is it big bang and then a quiet whimper, or a self sustaining entity for the long term?

Re: OpenTofu may be showing us the wrong way to fork

#22

Post by emestifs »

mrd3v0 wrote: post #15

> Matt Asay runs developer relations at MongoDB. Explains the lack of factual basis. It is literally a PR campaign.

It's a PR campaign?! What?

MongoDB is mentioned in the footer, in greyed text. MongoDB benefits from Terraform vs OpenTofu tensions how?

Do you run or work for a DB company? Because your comment sounds like a PR campaign by that logic.

Re: OpenTofu may be showing us the wrong way to fork

#23

Post by tsimionescu »

jkaplowitz wrote: post #16
tsimionescu wrote: post #14

Earlier quoted context omitted.

It's not at all clear that they didn't. This article seems biased and misleading.

The article shows a HashiCorp copyright notice coupled with an MPL license header for a file that was never released by HashiCorp under the MPL. How is that biased and misleading?

If you look at the commit history, the reviewers actually asked why the files have the HashiCorp copyright, and it seems that the developers were not sure what is the final copyright notice for new code. The one they settled on recognizes copyright both from HashiCorp and the OpenTofu foundation, as even the new files are probably deemed to be derived works of HashiCorp.

Here is the comment I'm mentioning: https://github.com/opentofu/opentofu/pull/1158/commits/35d1a...

Re: OpenTofu may be showing us the wrong way to fork

#24

Post by arp242 »

spooneybarger wrote: post #7

I diffed one of the example files. I don't see clear copying. It looked at a moderate glance to be a different implementation of similar functionality. I didn't spend time looking at the others as I felt the argument as put forth was already weak. I'd suggest comparing yourself and not assuming that the author's points are all valid.

These types of things are very hard to definitively prove one way or the other. I was once loudly accused of plagiarizing someone's answer on Stack Overflow. And they were right, the answers were very similar – the code was near-identical and even some of the verbiage of the explanation was quite similar.

Luckily I was able to prove my innocence quite conclusively as my answer was several months older that theirs. Whoops! We had a laugh about it and it all ended well, but it's a nice example on how two strangers can arrive at very similar code.

Should probably look at the original commit in the PR, rather than the current state of the repo. There's quite a bit of feedback on that PR and there may have been other changes since: https://github.com/opentofu/opentofu/pull/1158/commits

It's certainly not a blind copy/paste, but I find it very hard to say if it's a reworked version of terraform or a clean re-implementation. I think both are possible, or something in-between: they looked at the terraform patch to see what approach they took, went "ah right, that approach will work", and then implemented their own patch "from scratch". Is that legal? Probably. Is it moral? Well, you decide.

OpenTofu already requires a Developer Certificate of Origin: https://github.com/opentofu/opentofu/blob/main/CONTRIBUTING.... – basically we have to believe people are not lying when they say they're the author. While there are perhaps some eye-brow raising bits of code here and there, I think the current evidence is not even close to strong enough to call people liars.

Re: OpenTofu may be showing us the wrong way to fork

#25

Post by tsimionescu »

sethops1 wrote: post #19
spooneybarger wrote: post #7

I diffed one of the example files. I don't see clear copying. It looked at a moderate glance to be a different implementation of similar functionality. I didn't spend time looking at the others as I felt the argument as put forth was already weak. I'd suggest comparing yourself and not assuming that the author's points are all valid.

Take a look at the actual commit history. It's clear copying the BUSL files and then changing things. https://github.com/opentofu/opentofu/pull/1158/commits

I see lots of new activity in there, including reviews and feedback etc. What makes you feel they are copied?

Re: OpenTofu may be showing us the wrong way to fork

#26

Post by Yantrio »

Hey, OpenTofu core team-member here. I'd like to leave a note on what seems to have caused a lot of the confusion in this article.

The copyright headers in the new files are necessary because we sometimes need to move around code from older files.

For more information you can see this issue: https://github.com/opentofu/opentofu/issues/454#issuecomment...

Re: OpenTofu may be showing us the wrong way to fork

#27

Post by mrd3v0 »

emestifs wrote: post #22
mrd3v0 wrote: post #15

> Matt Asay runs developer relations at MongoDB. Explains the lack of factual basis. It is literally a PR campaign.

It's a PR campaign?! What? MongoDB is mentioned in the footer, in greyed text. MongoDB benefits from Terraform vs OpenTofu tensions how? Do you run or work for a DB company? Because your comment sounds like a PR campaign by that logic.

It is not really hard to put two and two together about what a source-available software company's developer relations person has to gain by publishing a hit piece on community forks that are created to oppose source-available licences.

That aside, it is literally in the title "developer relations." I am not sure what is outrageous in pointing that out.

Re: OpenTofu may be showing us the wrong way to fork

#28

Post by sdesol »

emestifs wrote: post #21

I have no horse in the race, but as an outside observer, and involved in some small open source stuff, I find it interesting the dynamics of these kinds of large public events and forks. Looking at the contributor activity from Aug 13th 2023 to today, there seems to be slightly less activity in the OpenTofu repo vs the original Terraform repo, but small sample size and just eyeballing it, don't take this as an accura…

> slightly less activity in the OpenTofu repo vs the original Terraform repo,

There is actually quite a bit of difference in activity level, if you consider unique people engaging with both projects. In the last 30 days, Terraform had 205 unique users interact with their repo vs 62 for OpenTofu [1].

[1] https://devboard.gitsense.com/opentofu?id=82c4b68df1&nb=all

Edit: If you only consider people with merges, then the activity level is very similar

https://devboard.gitsense.com/opentofu?id=82c4b68df1&nb=all&...

Note 1: Full disclosure, this is my tool

Note 2: You can't read too much into the trending insights for now, since I need to spread the API limit across many repos, so I only go back so far for each repo.

Re: OpenTofu may be showing us the wrong way to fork

#29

Post by emestifs »

mrd3v0 wrote: post #27
emestifs wrote: post #22

Earlier quoted context omitted.

It's a PR campaign?! What? MongoDB is mentioned in the footer, in greyed text. MongoDB benefits from Terraform vs OpenTofu tensions how? Do you run or work for a DB company? Because your comment sounds like a PR campaign by that logic.

It is not really hard to put two and two together about what a source-available software company's developer relations person has to gain by publishing a hit piece on community forks that are created to oppose source-available licences. That aside, it is literally in the title "developer relations." I am not sure what is outrageous in pointing that out.

Fair enough. I get what you're saying.

But is this about MongoDB trying to deter forks? Are there any live MongoDB fork? Hasn't the MongoDB hype train derailed a long time ago?

Re: OpenTofu may be showing us the wrong way to fork

#30

Post by PeterZaitsev »

I think the great lesson here is this - if Fork is where to compete with Proprietary Source Available software, it is likely it will need to implement a lot of similar functionality and to avoid potential problems it is very important there is a process of "clean room" implementation. I would consider asking developers to speficially attest they have not been looking at the visible but proprietary implementation when contributing code to Open Source project
Post reply on HN