Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Asahi dev found off-by-one bug in M2 MacBook Air bass enhancer

social.treehouse.systems

Post reply on HN
Print view View original

21–30 of 62 posts

Re: Asahi dev found off-by-one bug in M2 MacBook Air bass enhancer

#21

Post by supriyo-biswas »

okeuro49 wrote: post #15
015a wrote: post #6

This seems like a needlessly aggressive and poor take. Its a cool bug that they discovered; but going into "Apple's audio engineering team is, at least on some level, incompetent (or incompetently run; I'm not blaming the employees here, but rather the organization)" is just unproductively mean. "and obvious in a sine sweep frequency response test, which is the most basic test you can run end-to-end on a completed au…

It's not an official Asahi communication. It's a dev enjoying some hyperbole for something cool they fixed on a chat platform.

Hector Martin is the project leader, and regardless of wherever they comment, people will read into disparaging comments such as the one in this post (as opposed to expressing respectful disagreement).

Re: Asahi dev found off-by-one bug in M2 MacBook Air bass enhancer

#23

Post by dagmx »

CoolGuySteve wrote: post #12

At Apple we would see this tone all the time from people on the VLC project. It got so bad that the senior people would refer to them as DCS, Drunken College Student. It got so bad that we mostly ignored them. It wasn't good for either VLC or QuickTime.

Honestly, there’s the ego if “we did this when the paid elites didn’t” in a lot of open source communities. I contribute to many projects and it always rubs me the wrong way because they don’t consider how many other variables the team has to juggle, and what priorities are like. To be clear, I’m not saying this is everyone, and it’s often the vast minority but it also often goes unchecked and unchallenged when it does come up.

Of course part of that is because corporate development is a black box from the outside , but even if it weren’t, there’s no way people would keep up with it anyway.

Re: Asahi dev found off-by-one bug in M2 MacBook Air bass enhancer

#24

Post by gjsman-1000 »

aaomidi wrote: post #17
agildehaus wrote: post #8

Earlier quoted context omitted.

These devs didn't even notice it until they tried to rip into the inner workings.

> These devs didn't even notice it until they tried to rip into the inner workings. I mean, considering the source isn't open. Yeah, you need to do that.

The point is more that, yes, it’s technically incorrect. But if literally no human noticed or was affected in any way, who cares? That’s the only reason bugs matter anyway.

Re: Asahi dev found off-by-one bug in M2 MacBook Air bass enhancer

#26

Post by hgomersall »

teruakohatu wrote: post #4

> They have a stupid off-by-one bug in the middle of their bass enhancer AND NOBODY NOTICED NOR FIXED IT IN OVER A YEAR. The mocking tone of this post is really not necessary. An engineer made probably one of the most common coding errors that nobody noticed because real world impact is minor to non existent. The devs should be trying to build a relationship with Apple, not mocking then each time they find a minor bu…

It's a bug that shouldn't have happened though. One hopes that they have a well verified reference implementation for all their signal processing pipeline (and ideally both a high level and a bit accurate model) and they're testing the output of any optimised implementation against that, with random input data. This is Apple, one of the most "valuable" companies in the world. They should do their job.

Re: Asahi dev found off-by-one bug in M2 MacBook Air bass enhancer

#28

Post by Turing_Machine »

aaomidi wrote: post #17
agildehaus wrote: post #8

Earlier quoted context omitted.

These devs didn't even notice it until they tried to rip into the inner workings.

> These devs didn't even notice it until they tried to rip into the inner workings. I mean, considering the source isn't open. Yeah, you need to do that.

Well, for audio bugs that actually matter, you can just listen to it, or if you want to get all sciencey, throw the output and input onto a scope and compare them, or send the input and output sample values into the analysis software of your choice.

Code isn't necessary to judge the quality of an audio system. You can pretty much treat it as a black box if you want.

The fact that no one has apparently even noticed this bug before says a lot.

Re: Asahi dev found off-by-one bug in M2 MacBook Air bass enhancer

#29

Post by gjsman-1000 »

hgomersall wrote: post #26
teruakohatu wrote: post #4

> They have a stupid off-by-one bug in the middle of their bass enhancer AND NOBODY NOTICED NOR FIXED IT IN OVER A YEAR. The mocking tone of this post is really not necessary. An engineer made probably one of the most common coding errors that nobody noticed because real world impact is minor to non existent. The devs should be trying to build a relationship with Apple, not mocking then each time they find a minor bu…

It's a bug that shouldn't have happened though. One hopes that they have a well verified reference implementation for all their signal processing pipeline (and ideally both a high level and a bit accurate model) and they're testing the output of any optimised implementation against that, with random input data. This is Apple, one of the most "valuable" companies in the world. They should do their job.

> They should do their job.

They did their job. They delivered a sound system that has been called the best available in any laptop. Nobody, and I mean nobody, noticed this bug in the last three years.

Apple is doing just fine without your couch coaching about what they should have done. I might as well harass Apple for having 99% P3 color certification but not 100% accuracy certification.

Re: Asahi dev found off-by-one bug in M2 MacBook Air bass enhancer

#30

Post by jauntywundrkind »

thfuran wrote: post #18
okeuro49 wrote: post #15

Earlier quoted context omitted.

It's not an official Asahi communication. It's a dev enjoying some hyperbole for something cool they fixed on a chat platform.

They're being an unprofessional asshole. That they enjoy doing so hardly does them any credit.

[flagged]
Post reply on HN