21–30 of 64 posts
If everybody gets promoted because of "memorable" work, maybe nobody actually deserves the promotions, and they're just handed out at the whim of whoever remembers your work?
I'm curious to know if this is anyone's first time hearing about Trino?
It's certainly an interesting choice of name!
Should you say "TRY-no" to rhyme with Rhino or "TREE-no" to rhyme with Arduino?
I would do the latter, but I'm a debauched expat. My guess is that half the people in America will do the former.
Because I overthink this stuff I had to go see what's on trino.com and it's an impressively old-school unfinished personal website.
Earlier quoted context omitted.
Facebook has their own internal reviews for their own internal projects and forks of open source projects. I think the issue came down to Facebook adding anyone working on the project to have the ability to merge code to the open source project. Typically if a company wants to contribute to open source, you have to create a PR and have it be reviewed and merged by the maintainers of the open source project on top of…
I spent many years at FB, but no longer there, but that doesn’t even sound like a ‘special case’? Every engineer at Fb has access to pretty much all the code, and after an internal code review for your code change, you can get it committed to the internal repos. For open source things, something syncs the external and internal changes ocassionaly I think. I imagine the problem here was that now external people can’t…
This process is problematic, though. The "special case" is the standard process at FB: to make external contributors second class citizens.
They have their reasons, but doing this pushes the locus of discussion and action to the place where work happens fastest: inside the company. That means that the interests of FB engineers drive the project; in other words, not open.
That argument is I'm sure open to some logical nitpicking. But the evidence speaks for itself: Facebook open source projects aren't responsive to the outside community, and they language when FB's priorities shift. So their strategy has been pennywise, pound foolish in my view: they get the short term benefits of an "open" project, but they're incapable of actually being good open source custodians.
> Engineers at these highly competitive companies must create memorable work, or they will not get the promotions they deserve. If everybody gets promoted because of "memorable" work, maybe nobody actually deserves the promotions, and they're just handed out at the whim of whoever remembers your work?
"Feedback from these engineers ultimately culminated in the managers making the decision to give automatic contributor rights to any Facebook engineer working on Presto, so that these engineers could move faster." I'm confused -- does Facebook not have similar code review infrastructure as Google, etc. That is: nothing -- I mean nothing -- gets "contributed" at Google without it going through code review. Were FB eng…
Facebook/Meta does not have owners, so any two people in the company can land a change.
Any two people are in a less-extreme but similar boat: if someone puts up a bad diff and someone without a stake in the code accepts it, they had better hope to hell nothing goes wrong.
SEV review is a remarkably enlightened process for what it is, but you do not want to sit there explaining to extreme-seniority people why you YOLO'd something into Presto without buy in from a Presto hacker with your manager sitting behind you already thinking about how much this is going to get harped on in calibration.
The `OWNERS` file at FB is in `hg log`, but it's there.
Earlier quoted context omitted.
Facebook/Meta does not have owners, so any two people in the company can land a change.
And one engineer can (or could in 2018) put the unix name of the person sitting next to them in the "Reviewed By:" field and force push something, but it isn't/wasn't The Done Thing outside of the most extreme 3am SEV-0 scenarios. Any two people are in a less-extreme but similar boat: if someone puts up a bad diff and someone without a stake in the code accepts it, they had better hope to hell nothing goes wrong. SEV…
I'm curious to know if this is anyone's first time hearing about Trino?
Earlier quoted context omitted.
I spent many years at FB, but no longer there, but that doesn’t even sound like a ‘special case’? Every engineer at Fb has access to pretty much all the code, and after an internal code review for your code change, you can get it committed to the internal repos. For open source things, something syncs the external and internal changes ocassionaly I think. I imagine the problem here was that now external people can’t…
I worked at FB, too, and I can confirm you speak the truth. This process is problematic, though. The "special case" is the standard process at FB: to make external contributors second class citizens. They have their reasons, but doing this pushes the locus of discussion and action to the place where work happens fastest: inside the company. That means that the interests of FB engineers drive the project; in other wor…
I'm curious to know if this is anyone's first time hearing about Trino?
I had heard of Presto, vaguely, but not Trino. It's certainly an interesting choice of name! Should you say "TRY-no" to rhyme with Rhino or "TREE-no" to rhyme with Arduino? I would do the latter, but I'm a debauched expat. My guess is that half the people in America will do the former. Because I overthink this stuff I had to go see what's on trino.com and it's an impressively old-school unfinished personal website.