Live data from Hacker News

Why do most top performers have the highest count of commits and pull requests?

swecareer.substack.com

21–30 of 194 posts

Re: Why do most top performers have the highest count of commits and pull requests?

#21
`git shortlog -sne --oneline --since='Jan 1 2010'`

I like running the above command because it gives a good sense of coding productivity at the very least. And then you can dig into specific people to understand why exactly they have lots of commits or not. Most people use Git in a very similar fashion so you can very quickly make a generalization about how they commit if you look through their last N commits.

Some 'high commit count' people have lots of low value commits, e.g. lots of 'fix it' commits.

Other 'high commit count' people are very productive but mix in a lot of atomic commits, e.g. lots of 'another commit to change this comment', leading to a PR of 9 super small commits + 1 real commit, that's readable alongside their actual work.

Others are actually just more productive than other people. That might be because their code changes are simpler, or in an area that's easier to be productive in and write lots of code. Or they just work more. Or they work at a higher velocity because they understand the codebase and domain better.

Definitely don't _only_ use these metrics because some people just code slower and put out 1 large PR, but I can definitely believe a pattern of people at the top end of productivity who put out both small and large PRs at a higher velocity than the 'less productive' people.

I would honestly just attribute those high value, high commit count people to being stronger developers overall, in my limited experience. Overall as in, not weak in any particular area, and quite strong technically in every area. The people you can put in any situation in the domain and they'd probably succeed. Because they're strong across the entire codebase, their productivity is just generally higher no matter what they're doing.

Re: Why do most top performers have the highest count of commits and pull requests?

#22
post #17

Maybe, just maybe... the person you think is a Top Performer is not actually the Top Performer and you are creating a fake correlation to their high number of commits and pull request. Maybe we need to define who is the Top Performer in the first place.

I mean I won't disagree with your first point but if you read the article you would know that the author very explicitly defines 'Top Performer.'

I read it and don't think a go to person is a Top Performer. I wasn't talking about the author view of Top Performer but the realty. I think i can't tell what I'm talking about this KPI situation correctly with a comment. I will try to write a blog post about that asap. I noticed I have a lot to talk about creating KPI for humans. :)

Re: Why do most top performers have the highest count of commits and pull requests?

#23
post #5

In the olden days they used to measure performance by SLOC, Source Lines of Code. https://en.wikipedia.org/wiki/Source_lines_of_code

I read that most enterprise software developers write about 3k sloc per year on huge projects, in terms of final code add size (not lines added), but that it varies quite a bit. Has anyone ever found these sorts of metrics to be helpful in their experience? Wouldn’t be any good for individual performance but what about for projects as a whole?

Re: Why do most top performers have the highest count of commits and pull requests?

#24

“Top performer” here means “top performer in a team, relatively to teammates”, which narrows the definition substantially. There are mysterious geniuses who can deliver a great piece of software just as an experiment/PoC out of the blue, but they don’t tend to shine in such environments—they could be founders or indie consultants, or it could be their side-project persona. (I.e., stating the obvious, if you are inten…

I batch it based on what could possibly make sense to revert.

When I batch, I batch it based on what could make sense to lose. More often than not it's small quick-fire tweaks though. I even made a small CLI tool to quickly deploy it `happy "Message"` and even optionally release an npm version `happy --minor`.

Re: Why do most top performers have the highest count of commits and pull requests?

#25
Obligatory: https://github.com/artiebits/fake-git-history (does just what it says on the tin)

"I don't encourage people to cheat. But if anybody is judging your professional skills by the graph at your GitHub profile, they deserve to see a rich graph"

Re: Why do most top performers have the highest count of commits and pull requests?

#26
post #6

Lol, when I worked at a unicorn one of my buddies got an award for "most testing code commits" He confided after drinks it was because he didn't know how to squash/amend his commits. So I'm not so sure about that metric....

Is that why people are always saying you should squash commits? To help with collecting metrics?!

I view it as a clear antipattern (since the history within a branch can be valuable later if you need to cherry-pick apart a feature or find a bug with git-bisect) and have asked superiors in numerous places why they require it, and the response is usually a vague mention of “it cleans things up” and “history isn’t important”. It feels like the kind of practice that was mentioned on a screencast and just got cargo-culted, but I have to think it originally had some purpose.

Re: Why do most top performers have the highest count of commits and pull requests?

#27
Perhaps some of the more productive workers are the ones that don't hesitate to make necessary code changes, test the changes adequately, and then move on to the next thing.

I have noticed that pretty much every software engineer to some degree has problems that they procrastinate on. Folk can spend 10x more time talking about doing something than it takes to do it. For hard problems, that discussion is necessary and beneficial, but lots of problems just need someone to open up the text editor and get it done.

Re: Why do most top performers have the highest count of commits and pull requests?

#28
> "the top performer's commits out number the second highest by 50% or more. [...] This might indicate some form of Pareto principle at play. Perhaps?"

Price's Law?

"50% of the work is done by the square root of the total number of people who participate in the work" -> "You are working on a team, and there are the superstars who do most of the work or seem to produce most of the outcomes and then there is everyone else."

https://expressingthegeniuswithin.com/prices-law-and-how-it-...

Re: Why do most top performers have the highest count of commits and pull requests?

#29

“Top performer” here means “top performer in a team, relatively to teammates”, which narrows the definition substantially. There are mysterious geniuses who can deliver a great piece of software just as an experiment/PoC out of the blue, but they don’t tend to shine in such environments—they could be founders or indie consultants, or it could be their side-project persona. (I.e., stating the obvious, if you are inten…

I batch it based on what could possibly make sense to revert.

I batch it based on "ok, I need to commit and push this in case my computer dies".

Re: Why do most top performers have the highest count of commits and pull requests?

#30

Perhaps some of the more productive workers are the ones that don't hesitate to make necessary code changes, test the changes adequately, and then move on to the next thing. I have noticed that pretty much every software engineer to some degree has problems that they procrastinate on. Folk can spend 10x more time talking about doing something than it takes to do it. For hard problems, that discussion is necessary and…

I worked as a contractor with some companies and peer coded with their engineers.

What I found was that its not just procrastination. Many folks are just afraid to commit code, like literally scared and I could never get a real reason for that. At one point I added some code based on the direction what requirements were taking. But I could not convince him to commit it.

So we finally agreed to let it be there commented out, only a week later to find we need it now.

Post reply on HN