I found what it generates.
https://github.com/pediredla/Algorithms/pull/3/files
It looks like a linter, but maybe there is more.
Amazon CodeGuru – Preview
21–30 of 209 posts
Re: Amazon CodeGuru – Preview
#22The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.
[deleted]
Re: Amazon CodeGuru – Preview
#23Earlier quoted context omitted.
that's insanely expensive if you're doing any type of code generation.
This seems like a good incentive not to be generating thousands of lines of codes with each PR, which most would probably consider a feature as opposed to a bug.
If you split the same number of lines over two, three, ten, etc PRs it still costs the same. If anything it is incentivising code-golf via line minimization.
Re: Amazon CodeGuru – Preview
#24Earlier quoted context omitted.
This seems like a good incentive not to be generating thousands of lines of codes with each PR, which most would probably consider a feature as opposed to a bug.
exactly. IMO if you're generating code, it should happen at build/compile time not at checkin
What would the rationale be for that?
Re: Amazon CodeGuru – Preview
#25I wanted to try it on a single repository, but it requested access to all repositories, public or private and also needs admin access for webhooks. No thanks.
Re: Amazon CodeGuru – Preview
#26Please do us a favor and consolidate all these Amazon announcements into a single announcement page link. This is ridiculous.
Re: Amazon CodeGuru – Preview
#27The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.
That sounds pretty terrible to be honest. I cannot imagine getting that kind of value out of it (that I would not get with a simple linter).
Re: Amazon CodeGuru – Preview
#28I found what it generates. https://github.com/pediredla/Algorithms/pull/3/files It looks like a linter, but maybe there is more.
I've never seen a linter tell me problems with code in this detail before:
> You are using a `ConcurrentHashMap`, but your usage of `get()` and `put()` may not be thread-safe at lines: 110, 113, 135, and 137. Two threads can perform this same check at the same time and one thread can overwrite the value written by the other thread.
Re: Amazon CodeGuru – Preview
#29Earlier quoted context omitted.
exactly. IMO if you're generating code, it should happen at build/compile time not at checkin
What would the rationale be for that?
IMO it’s because generates code is not “source code”. It’s more similar to object files—both are generated by running a compiler.
Re: Amazon CodeGuru – Preview
#30The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.
Trying to compare it to another code analyzer... https://sonarcloud.io/about/pricing
100k lines for €10/mo.