Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Git-appraise: Distributed code review system for Git repos

github.com

Post reply on HN
Print view View original

21–30 of 30 posts

Re: Git-appraise: Distributed code review system for Git repos

#23

Post by alblue »

amiraliakbari wrote: post #14
e40 wrote: post #10

Earlier quoted context omitted.

To me it looks like something that could be used to implement Gerrit, but it doesn't come close to what Gerrit offers, having used it for a few years now. Gerrit is excellent at what it does.

I like Gerrit features, but it always seemed too complicated to integrate into usual coding workflow, especially with people always even complaining about git being "hard to use". This tools seems simpler compared to Gerrit, and more flexible compared to GitHub pull requests. I would appreciate advices on introducing Gerrit to my team and make it somehow transparent in development workflow.

I wrote about Gerrit a few years ago:

http://alblue.bandlem.com/2011/02/someday.html

I recorded a video showing how it worked together:

http://alblue.bandlem.com/2011/02/gerrit-git-review-with-jen...

Once you understand the workflow it's actually easy to adopt. The biggest challenge is getting people to think in terms of push requests instead of pull requests. If you configure the remote as "git config push HEAD:refs/for/master" then it becomes as simple as doing "git push" to upload changes.

Re: Git-appraise: Distributed code review system for Git repos

#24

Post by alblue »

pm90 wrote: post #6

How does this compare w.r.t Gerrit? I see that an advantage is that it doesn't require server-side setup. But wouldn't one require some sort of central repo to coordinate code reviews and CI tests?

I asked the Gerrit devs for their opinion: because the git appraise solution doesn't support rebasing it doesn't work well with the idea of being able to fix commits and repush.

https://groups.google.com/forum/m/#!topic/repo-discuss/Uab1n...

Re: Git-appraise: Distributed code review system for Git repos

#25

Post by flyinprogramer »

This seems like an awesome tool. Sadly my comment has more to do with Go, as I'm new to the language and trying to learn.

When building a tool that uses git I'm wondering if it is better practice to use git2go (https://github.com/libgit2/git2go) or to do what this author did which is wrap the git command line tool: https://github.com/google/git-appraise/blob/master/repositor...

Re: Git-appraise: Distributed code review system for Git repos

#26

Post by rco8786 »

secure wrote: post #12

I can’t find any mention of GUI frontends for git-appraise. While I prefer to write code in my terminal, I like to switch settings for reviewing code — with GitHub’s Pull Requests, I can just do it in the browser. Can I use git-appraise in my browser? Is there a stand-alone tool?

Looks like it's a standalone cli tool but I imagine you could get it to work with something like kdiff

Re: Git-appraise: Distributed code review system for Git repos

#27

Post by andrewflnr »

ubercow wrote: post #21

How does this handle identity? For example, what's preventing me from just changing my name and reviewing myself?

Why does anyone part attention to your review anyway? Reputation. No one's going to trust a review from someone that doesn't have a track record. If you want to get a sock puppet identity with that much reputation by making useful contributions through it, well, go ahead. :) xkcd.com/810/

Re: Git-appraise: Distributed code review system for Git repos

#28

Post by ghthor »

flyinprogramer wrote: post #25

This seems like an awesome tool. Sadly my comment has more to do with Go, as I'm new to the language and trying to learn. When building a tool that uses git I'm wondering if it is better practice to use git2go ( https://github.com/libgit2/git2go ) or to do what this author did which is wrap the git command line tool: https://github.com/google/git-appraise/blob/master/repositor...

Nothing wrong with calling the git command directly since this isn't an app that needs to scale past 1 human user. It could be some busy work in the future to translate it all into git2go, I have a project like this. It's a personal tool I use to write my journal and it wraps git to manage the entry data by placing it in a git repository.

Re: Git-appraise: Distributed code review system for Git repos

#29

Post by soinus »

Damn, feeling completely dumb. I have installed the tool, and am trying it on one of my projects. After I do some local commits `git-appraise request` returns `There are no commits included in the review request`. Is there any tutorial or more documentation available somewhere? Or do I need to dig into its code to find the issue?
Post reply on HN