Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

I couldn't submit a PR, so I got hired and fixed it myself

skeptrune.com

Post reply on HN
Print view View original

191–200 of 218 posts

Re: I couldn't submit a PR, so I got hired and fixed it myself

#191

Post by 9rx »

tunesmith wrote: post #61
9rx wrote: post #38

Earlier quoted context omitted.

They have, but they're beyond grasp of most developers. Tests were invented to express the "why" for the normal guy. They don't strictly prevent compilation, but a proper workflow will see them halt your process in the same way, offering the same outcome. Granted, there are a lot of horribly written tests out there that don't tell you "why" — or, well, anything. As always, people will find a way to abuse anything you…

With a test, it might link up some functionality with "why" and pass, but then what happens if a business requirement just isn't a requirement anymore? The test will still pass. I'm thinking of something sillier, like a language that forces you to justify why for your code, and then regularly quizzes you if the business reasoning is still true. If anything changes, it rips out the code and breaks your site. :) So the…

It wouldn't be too hard to add such logic to your tests. If it proves useful, someone will no doubt turn it into a language feature.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#192

Post by ChoGGi »

johnisgood wrote: post #146
buggy6257 wrote: post #82

I specifically attempted to get a job at Discord so I could submit a PR to make giant emojis be a toggle setting rather than automatic. I know the feeling. (If anyone works at Discord, please me and the rest of my server are begging you)

What are you referring to? You can disable the automatic conversion of :) to an emoji, for example.

I think it refers to only sending an emoji, it's shown as a large icon.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#193

Post by snickerdoodle12 »

chupchap wrote: post #157
carlmr wrote: post #149

Earlier quoted context omitted.

My biggest Amazon annoyance. I'm often looking for some product, reading Reddit and other reviews. They usually link to amazon.com. Then it asks me to switch my profile to American/$. But then in order to order I need to switch back to Germany/€. It's just super cumbersome. Just let me view stuff from any region without switching profiles. If I order from that region you can tell me to switch profiles. But not just f…

It doesn't work that way. A link is to an ASIN (unique product in Amazon). The same product might have a different ASIN in a different region. The product description, title etc might vary.

> The same product might have a different ASIN in a different region

But why?

Re: I couldn't submit a PR, so I got hired and fixed it myself

#194

Post by tofuahdude »

SoftTalker wrote: post #28

> I added an AbortController to the debounced search function, so that it aborts any previous queries when a new one is made. This means that the search results are always relevant to what the user is currently typing. To me one of the most annoying things an application can do is go off and do something before I'm done telling it what to do. Filters that apply themselves without an explicit indication that I'm done…

Grafana log search does this if change the currently-applied log filter, and then they charge you for search volume!

I've had to adjust my UX usage so that I don't get billed for every character I type, rather than the string I'm looking for.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#195

Post by zoover2020 »

LeifCarrotson wrote: post #171
cobbzilla wrote: post #169

Earlier quoted context omitted.

Clearly there exists some higher-level product concept with a mapping of country->ASIN for that product. How hard is it to lookup the correct ASIN? Maybe you end up on the home page when there is no ASIN for your country? There should be a nicer message telling you that’s what happened. But if it always dumps to the home page, that’s just dumb — Amazon could easily do the lookup.

There's no such mapping, you could do a text search and if the item name matches then maybe US ASIN 2785334 should correspond to UK ASIN 3894948, or maybe some third party just named something ambiguously. They're essentially GUIDs and essentially separate businesses.

Sorry this is just not true. ASINs can be the same cross marketplace. There are lower level identifiers available if needed

Re: I couldn't submit a PR, so I got hired and fixed it myself

#197

Post by troupo »

judge2020 wrote: post #125
troupo wrote: post #44

Earlier quoted context omitted.

> he introduced the "auto remove" feature for expired passes added to your wallet, then promptly quit This still didn't work reliably, unfortunately. I still have expired passes, tickets etc. in my wallet

Personally I don’t see why you would want to delete these expired passes. For the longest time they haven’t shown up alongside active passes.

> For the longest time they haven’t shown up alongside active passes.

They have always shown up for me, and the only way to delete them is from the wallet app. Note: from the app. You can't delete it from convenient screen where you access them

Re: I couldn't submit a PR, so I got hired and fixed it myself

#198

Post by linhns »

jraph wrote: post #135
392 wrote: post #111

Earlier quoted context omitted.

Also accepting gmaps work, if only it could preemptively cache the return trip for any trip longer than an hour, so that I'm not stuck with no service trying to remember how I got there.

Suggestion to use an offline app that will save you from such surprises. https://www.comaps.app/

Woah. What a gem you have provided us here.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#199

Post by linhns »

olalonde wrote: post #136
stevesimmons wrote: post #53

If Google Maps would like to hire me so the km/miles switch can remember I only ever want to see distances in km, my contact details are in my HN profile. I must have changed that back from miles once a fortnight since Google Maps launched 20 years ago. That's 500 times. Totally ridiculous for a company who core goal is profiling their users...

Also the currency in Google Flights... It always defaults based on your IP geolocation.

Defaulting to local currency is good since people usually book in local currency, putting switch button at the end is really bad though.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#200

Post by theandrewbailey »

jodrellblank wrote: post #183
theandrewbailey wrote: post #64

Earlier quoted context omitted.

When I implemented search-as-you-type on my blog, I decided to wait for the current search suggestion request to complete before doing a new one. Seemed like a reasonable balance between responsiveness and not overloading the server.

The earlier search will be on a shorter input which will find more results; imagine waiting for everything that contains "e" before you can get the one result for "europa" that you wanted. Isn't that pattern going to happen most of the time - waiting for a large amount of useless generated and transferred and disposed-of, before the search you want will run?

That's why I set it to run after the third letter and only return up to 7 suggestions. In your example, it wouldn't run until "eur", which should narrow it down quite a bit. Given my rather small blog article corpus and aggressive full text search indexing, it's very fast.
Post reply on HN