Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

I ruin developers’ lives with my code reviews and I'm sorry

habr.com

Post reply on HN
Print view View original

191–199 of 199 posts

Re: I ruin developers’ lives with my code reviews and I'm sorry

#191

Post by eu »

golergka wrote: post #150
kbenson wrote: post #97

Earlier quoted context omitted.

> saw multiple articles in Russian from this specific author. Actually, the one linked in this post is a translation. To put it bluntly, while they clearly have a background in software engineering, they are a troll. All their articles seem to have one thing in common: they look to be as controversial as possible on purpose, I don't believe them to be sincere. Is "don't be an asshole when it's actually not helping th…

> Is "don't be an asshole when it's actually not helping the other person like you told yourself if you look closely" actually controversial enough on that site to be considered a troll? In Russia, yes. Like the OP comment author, I'm familiar with both IT cultures, and there's a dramatic differences in the amount of politeness. I have actually seen people get into a physical fight because of work-related dispute, mo…

> I have actually seen people get into a physical fight because of work-related dispute, more than once.

Do tell, please

Re: I ruin developers’ lives with my code reviews and I'm sorry

#192

Post by spdionis »

eu wrote: post #191
golergka wrote: post #150

Earlier quoted context omitted.

> Is "don't be an asshole when it's actually not helping the other person like you told yourself if you look closely" actually controversial enough on that site to be considered a troll? In Russia, yes. Like the OP comment author, I'm familiar with both IT cultures, and there's a dramatic differences in the amount of politeness. I have actually seen people get into a physical fight because of work-related dispute, mo…

> I have actually seen people get into a physical fight because of work-related dispute, more than once. Do tell, please

Probably some tabs vs spaces issue.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#193

Post by foobarian »

golergka wrote: post #150
kbenson wrote: post #97

Earlier quoted context omitted.

> saw multiple articles in Russian from this specific author. Actually, the one linked in this post is a translation. To put it bluntly, while they clearly have a background in software engineering, they are a troll. All their articles seem to have one thing in common: they look to be as controversial as possible on purpose, I don't believe them to be sincere. Is "don't be an asshole when it's actually not helping th…

> Is "don't be an asshole when it's actually not helping the other person like you told yourself if you look closely" actually controversial enough on that site to be considered a troll? In Russia, yes. Like the OP comment author, I'm familiar with both IT cultures, and there's a dramatic differences in the amount of politeness. I have actually seen people get into a physical fight because of work-related dispute, mo…

That's interesting; the article did seem like something more common in Russian and other East European cultures. Maybe it's a side effect of intellectualism being more highly valued (a good thing) but then leads to these superiority contests where "good enough" is derided if it is not done in some intellectually interesting way. Which can be a disadvantage in software engineering.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#194

Post by majormajor »

ravitation wrote: post #113
majormajor wrote: post #31

> If a guy brings me his code, and it has mistakes, it brings insane pleasure from how smart I feel [...] And if you tell me that you haven’t had this feeling ever, then you’re lying. Tell me about higher goals, training rookies and all that — I know you’re simply too full of themselves. And if you try to tell me that you learned to defeat that feeling (however it manifests in you), then I must be a pink unicorn. I r…

> I want to learn things, but code reviewing bad code doesn't teach me anything - I want to work with people who can teach me things when they review my code just as often as the reverse. I mean maybe you're working on extremely repetitive code, but the idea that you don't learn anything from reviewing bad code, and hopefully writing comments designed to help not humiliate, seems pretty bad to me also... You want to…

It's certainly bad to get angry - I mentioned that there. I should clarify the anger happens when it's repeated more than on a one-off. E.g. if you have the same sloppy signs for 6 months (where I can tell by reading the code that you didn't even try to run your code locally), then I'm not learning anything and I'm getting frustrated because you're clearly not taking feedback to heart.

I try to avoid letting this show, but it's frustrating.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#196

Post by ethanfinni »

People like this are so toxic that companies must eject them. They have no real added value, they merely harass those that should be helped to grow and learn as they evolve in their positions. Software engineering teams need collaborating peers and mentors not bullies.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#197

Post by flud »

majormajor wrote: post #31

> If a guy brings me his code, and it has mistakes, it brings insane pleasure from how smart I feel [...] And if you tell me that you haven’t had this feeling ever, then you’re lying. Tell me about higher goals, training rookies and all that — I know you’re simply too full of themselves. And if you try to tell me that you learned to defeat that feeling (however it manifests in you), then I must be a pink unicorn. I r…

I concur. I'm not a coder but I do review things every 2 months as part of the release cycle, and whenever I see mistakes, especially silly mistakes, I don't feel smart at all, it doesn't even cross my mind.

I feel, in order: disappointment - because how could they make this stupid mistake, then anger - why the f do I have to waste time to correct stupid mistakes, then a bit hateful - we need to fire this person and hire someone competent, then sometimes a bit scared - what else has this person got wrong and I missed, then a mix of all of the above.

What would make me feel good, as far as reviews go, would be to say "hey, this person did this way better than I would have".

Can you tell I hate doing reviews?

Re: I ruin developers’ lives with my code reviews and I'm sorry

#198

Post by tcspence »

spdionis wrote: post #192
eu wrote: post #191

Earlier quoted context omitted.

> I have actually seen people get into a physical fight because of work-related dispute, more than once. Do tell, please

Probably some tabs vs spaces issue.

You shut your big fat pie hole. Spaces.
Post reply on HN