PHP 8

Post by Kluny » Thu, Nov 26, 2020, 8:53 PM UTC

mgkimsal wrote: post #141

Kluny wrote: post #106

Earlier quoted context omitted.

I worked at WordPress for half a year, and I'm no expert, but the code reviews there were more intense than any I've ever experienced. Every line of code gets reviewed before it gets committed, and if the commit is longer than 20 lines or so, it undergoes an additional scheduled review as well as pre-commit review. They also have pretty good code sniffers that ought to catch errors like OP mentioned. The reason they'…

> The reason they're concerned, I think, is because they try to protect users who have plugins that came from their plugin repository, where the same code quality rules don't apply. Then start making the quality rules apply. Or produce code quality ratings for plugins and display them for people to make decisions on. Making sure that WP can keep working with lower-quality plugins in the name of 'compatibility' just e…

Post by Denvercoder9 » Thu, Nov 26, 2020, 9:04 PM UTC

danudey wrote: post #181

nolok wrote: post #19

Earlier quoted context omitted.

Reading the list of things that worry them makes it clear that it's not so much php is breaking bc than it is wordpress lack of cleaning and linting for so long catching up to them. I mean seriously the first thing they list as a worry is that arithmetic operators will now throw an error when one (and only one) of their operand is an array or resource (eg array + array support remains, it's really int + array or stri…

It also sounds as though the internal type checking is going to be a large developer load as well. In PHP7, internal functions return null for type mismatches, and in PHP8, they raise a TypeError. This means going back through every case where they call an internal function and wrapping it with a try/catch for TypeError, in addition to checking for null. That sounds like a pretty significant workload change.

Post by TekMol » Thu, Nov 26, 2020, 9:10 PM UTC

Post by hakre » Thu, Nov 26, 2020, 9:18 PM UTC

matt_kantor wrote: post #168

nolok wrote: post #19

Earlier quoted context omitted.

Reading the list of things that worry them makes it clear that it's not so much php is breaking bc than it is wordpress lack of cleaning and linting for so long catching up to them. I mean seriously the first thing they list as a worry is that arithmetic operators will now throw an error when one (and only one) of their operand is an array or resource (eg array + array support remains, it's really int + array or stri…

> it's really int + array or string + file_descriptor, things like that I haven't personally used PHP in years, but was curious about this. Based on some quick/dumb experiments it appears int + array has thrown errors as far back as PHP4: - http://sandbox.onlinephpfunctions.com/code/0b2f22ea881b36e58... - http://sandbox.onlinephpfunctions.com/code/0e5fb752fc3ec28e8... Is the post talking about some other scenario? Ma…

Post by TekMol » Thu, Nov 26, 2020, 9:20 PM UTC

chmod775 wrote: post #104

baby wrote: post #86

Earlier quoted context omitted.

I don't understand why pretty much no language does that these days. I think the argument is that your IDE should do this, and it does in some cases, but still...

You can get a much more powerful alternative for "free" if you support de-structuring assignments (in arguments). JavaScript Example: function test({a,b,c}) { console.log(c,b,a) }; test({ a: 1, b: 2, c: 3 }); If you have this there's really no need for named arguments anymore. If you add features to your de-structuring, your "named arguments" will have them too (things missing for JS specifically: optional objects, T…

    function hello($name='Joe',$title='dear')
    {
        echo "Hello $title $name";
    }
    hello('Sue');