Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

The GitHub website is slow on Safari

github.com

Post reply on HN
Print view View original

181–190 of 367 posts

Re: The GitHub website is slow on Safari

#181

Post by mormegil »

bityard wrote: post #137
accrual wrote: post #128

Earlier quoted context omitted.

Looks like a new community developed fork of Phabricator is up! I've never used it but glad to see the project continues. https://we.phorge.it/

I tried poking around but it looks like you have to be logged into to view the source, and registration requires manual approval. :/ I assume this is fallout from dealing with LLM content scrapers.

Yes, exactly. Even though you can clone the git repos anonymously, or look at the Github mirror.

https://we.phorge.it/phame/post/view/8/anonymous_cloning_dis... https://we.phorge.it/phame/post/view/9/anonymous_cloning_has...

Re: The GitHub website is slow on Safari

#182

Post by psygn89 »

Sesse__ wrote: post #105
muglug wrote: post #5

Improvements merged within the last two days by the WebKit team: https://github.com/orgs/community/discussions/170922#discuss... For my sins I occasionally create large PRs (> 1,000 files) in GitHub, and teammates (who mostly all use Chrome) will sometimes say "I'll approve once it loads for me..."

Interesting how _everyone_ here blames JS and React, yet the fixes you linked are about CSS performance.

JS is the logical place to start with all the virtualization and fanciness.

But CSS has bit me with heavy pages (causing a few seconds of lag that even devtools debugging/logging didn't point towards). We know wildcard selectors can impact performance, but in my case there were many open ended selectors like `:not(.what) .ever` where the `:not()` not being attached to anything made it act like a wildcard with conditions. Using `:has()` will do the same with additional overhead. Safari was the worst at handling large pages and these types of selectors and I noticed more sluggishness 2-3 years ago.

Re: The GitHub website is slow on Safari

#183

Post by fouc »

agos wrote: post #24
bob1029 wrote: post #15

Earlier quoted context omitted.

> And no, the problem is not "Rails" The problem is they abandoned rails for react. The old SSR GitHub experience was very good. You could review massive PRs on any machine before they made the move.

if you look at the thread, the explanation is not this easy, as much as it's satisfying to blame React (or any other single tech)

We're not specifically blaming React. we're blaming their approach to React/SPA and how it caused a massive degrade compared to Github's Rails-based UX.

Github's code view page has been unreasonably slow for the last several years ever since they migrated away from Rails for no apparent reason.

Re: The GitHub website is slow on Safari

#184

Post by CharlesW »

zackmorris wrote: post #57

GitHub moved to a JavaScript rendering mode almost as soon as Microsoft bought it. Previously, I had been able to browse it with JavaScript disabled on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13. So even if I enable JavaScript, I can no longer browse GitHub, because they didn't bother to make their build compatible with browser versions as old as mine. It's hard to know which member of…

> …on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13.

In case you're one of today's lucky 10,000, OpenCore Legacy Patcher supports Macs going to back as far as 2007: https://github.com/dortania/OpenCore-Legacy-Patcher

Re: The GitHub website is slow on Safari

#185

Post by Autummata »

makeitdouble wrote: post #155
w0m wrote: post #140

Earlier quoted context omitted.

or use a supported OS (linux, or hilariously probably Windows), or install a still-suppored browser (I'd guess Firefox likely still runs latest on there). I'd put it on the end user for not updating software on 15 y/o hardware and still expecting the outside world to interact cleanly.

> hilariously probably Windows That's probably true. > 15 y/0 It's a matter of expectations, many laptops that old still work decently enough with a refreshed battery. Funnily enough win10 was released 15 ago, and one can still get support for it for at least another 3 years until 2028, even on the customer license.

W10 was released 10 years ago, not 15. https://en.wikipedia.org/wiki/Windows_10_version_history

Re: The GitHub website is slow on Safari

#186

Post by Sesse__ »

psygn89 wrote: post #182
Sesse__ wrote: post #105

Earlier quoted context omitted.

Interesting how _everyone_ here blames JS and React, yet the fixes you linked are about CSS performance.

JS is the logical place to start with all the virtualization and fanciness. But CSS has bit me with heavy pages (causing a few seconds of lag that even devtools debugging/logging didn't point towards). We know wildcard selectors can impact performance, but in my case there were many open ended selectors like `:not(.what) .ever` where the `:not()` not being attached to anything made it act like a wildcard with conditi…

`:not(.what) .ever` should be fairly fast, unless you have lots of `class="ever"` elements. Not ideal, but not as bad as e.g. `.ever :not(.what)` would be. `:has()` is just inherently slow if there's a significant amount of elements to search, even though browsers have some caching and tricks.

Normally, you be able to debug selector matching performance (and in general, see how much style computation costs you), so it's a bit weird if you have phantom multi-second delays.

Re: The GitHub website is slow on Safari

#188

Post by Zanfa »

agos wrote: post #24
bob1029 wrote: post #15

Earlier quoted context omitted.

> And no, the problem is not "Rails" The problem is they abandoned rails for react. The old SSR GitHub experience was very good. You could review massive PRs on any machine before they made the move.

if you look at the thread, the explanation is not this easy, as much as it's satisfying to blame React (or any other single tech)

Not once have I seen a site go from SSR to SPA and been pleasantly surprised. It always trends towards worse in responsiveness and overall UX.

I’m sure you could make something work better as a SPA, but nobody does.

Re: The GitHub website is slow on Safari

#189

Post by TiredOfLife »

adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

https://github.com/ethanniser/NextFaster

https://t3.chat/

Re: The GitHub website is slow on Safari

#190

Post by [deleted] »

muglug wrote: post #5

Improvements merged within the last two days by the WebKit team: https://github.com/orgs/community/discussions/170922#discuss... For my sins I occasionally create large PRs (> 1,000 files) in GitHub, and teammates (who mostly all use Chrome) will sometimes say "I'll approve once it loads for me..."

[deleted]
Post reply on HN