Why is Git Autocorrect too fast for Formula One drivers?

Post by vrighter » Mon, Jan 20, 2025, 1:44 PM UTC

egypturnash wrote: post #125

chuckadams wrote: post #113

Earlier quoted context omitted.

It was about saving memory by tokenizing keywords: '?' is how PRINT actually was stored in program memory, it just rendered as 'PRINT'. Most other tokens were typically the first two characters, the first lowercase, the second uppercase: I remember LOAD was 'lO' and DATA was 'dA', though on the C64's default character glyphs they usually looked like L and D . All this being on a C64 of course, but I suspect most vers…

C64 basic was tokenized into one byte, with the most significant bit set: https://www.c64-wiki.com/wiki/BASIC_token Each command could be typed in two ways: the full name, or the first two letters, with the second capitalized. Plus a few exceptions like "?" turning into the PRINT token ($99, nowhere near the PETSCII value for ?) and π becoming $FF. The tokens were expanded into full text strings when you would LIST t…

Post by shawabawa3 » Mon, Jan 20, 2025, 2:15 PM UTC

Etheryte wrote: post #69

shawabawa3 wrote: post #35

Earlier quoted context omitted.

In this case the reaction starts before you hit enter, as you're typing the command So, you type `git pshu ` and realise you made a typo before you've finished typing. You can't react fast enough to stop hitting enter but you can absolutely ctrl+c before 100 more ms are up

I'm still pretty skeptical of this claim. If you type 60 wpm, which is faster than an average human, but regular for people who type as professionals, you spend on average 200ms on a keystroke. 60 standard words per minute means 300 chars per minute [0], so 5 chars per second which is 200ms per char. Many people type faster than this, yes, but it's all still very much pushing it just to even meet the 100ms limit, and…

    #!/usr/bin/env bash
    start_time=$(gdate +%s%3N)
    # Function to handle Ctrl+C (SIGINT)
    on_ctrl_c() {
        end_time=$(gdate +%s%3N)
        total_ms=$((end_time - start_time))
        # Calculate integer seconds and the remaining milliseconds
        seconds=$((total_ms / 1000))
        millis=$((total_ms % 1000))

        # Print the runtime in seconds.milliseconds
        echo "Script ran for ${seconds}.$(printf '%03d' ${millis}) seconds."
        exit 0
    }

    # Trap Ctrl+C (SIGINT) and call on_ctrl_c
    trap on_ctrl_c INT

    # Keep the script running indefinitely
    while true; do
        sleep 1
    done

Post by deltaburnt » Mon, Jan 20, 2025, 2:26 PM UTC

physicles wrote: post #89

The root cause here is poorly named settings. If the original setting had been named something bool-y like `help.autocorrect_enabled`, then the request to accept an int (deciseconds) would've made no sense. Another setting `help.autocorrect_accept_after_dsec` would've been required. And `dsec` is so oddball that anyone who uses it would've had to look up. I insist on this all the time in code reviews. Variables must…

Post by fsckboy » Mon, Jan 20, 2025, 2:35 PM UTC

catlifeonmars wrote: post #94

darkwater wrote: post #77

Earlier quoted context omitted.

About 2, well, you are the actual polluter, even if you just scroll back in history andnuse the same last wrong command because it works anyway.

Well to put it into context, I use fish shell, which will only save commands that have an exit code of 0. By using git autocorrect, I have guaranteed that all git commands have an exit code of 0 :)

Post by TeMPOraL » Mon, Jan 20, 2025, 2:39 PM UTC

codetrotter wrote: post #181

TeMPOraL wrote: post #95

Earlier quoted context omitted.

> I insist on this all the time in code reviews. Variables must have units in their names if there's any ambiguity. For example, `int timeout` becomes `int timeout_msec`. Same here. I'm still torn when this gets pushed into the type system, but my general rule of thumb in C++ context is: void FooBar(std::chrono::milliseconds timeout); is OK, because that's a function signature and you'll see the type when you're look…

> Yes, I use IDE or a language-server-enabled editor when working with C++, and no, I don't have time to stop every 5 seconds to hover my mouse over random symbols to reveal their types. JetBrains does a great thing where they show types for a lot of things as labels all the time instead of having to hover over all the things.