Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Apple Photos app corrupts images

tenderlovemaking.com

Post reply on HN
Print view View original

171–180 of 471 posts

Re: Apple Photos app corrupts images

#171

Post by thewebguyd »

ValentineC wrote: post #104
tenderlove wrote: post #24

Earlier quoted context omitted.

This is also my guess. It's really a bummer, and I'd report it to Apple but since it's nondeterministic I have no idea how to provide repro steps.

What's worse about the Apple ecosystem is that because of how tightly coupled it is, a bug fix for Photos would only come as part of a macOS update. Which means that if that bug has been present since the (now unsupported) Mavericks, tough luck!

I still don't under stand why Apple limits updates to their first party apps to OS updates.

They could really benefit from how Google does it on Android and decouple it. Push updates to their first party apps via the app store like everyone else, and let the OS update on its own separate schedule.

Re: Apple Photos app corrupts images

#172

Post by nickcw »

jjcob wrote: post #64
tenderlove wrote: post #20

Earlier quoted context omitted.

Here you go! https://gist.github.com/tenderlove/25853f50ab46a58738ff2cc22d682f2b I ran both files through xxd then diffed them. I've literally changed every piece of hardware (at no small cost). "premature to immediately blame Apple" seems a bit off.

I tried running the file segments through a binary diff with Hex Fiend As far as I can tell: - 0x7800 bytes were replaced at file offset 0x00aa0000 - 0x2200 bytes were replaced at file offset 0x00aa8000 I can't tell if the replacement data came from a different part of the file, or somewhere totally different. Race condition somewhere sounds plausible.

gcd(0x2200,0x7800) = 512

So some part of the chain with 512 byte buffer size corrupted the data.

It doesn't look like a memory corruption but if this were my computer I'd run the equivalent of memtest86 on it.

It looks like a filing system corruption to me. Running `diskutil info` on the main harddisk and the sd card might be interesting to see if the block sizes match.

Running a disk tester on the sd card and the main disk might be a good idea too. Here is one I wrote: https://github.com/ncw/stressdisk

Re: Apple Photos app corrupts images

#174

Post by tpurves »

deviation wrote: post #59
ChrisMarshallNY wrote: post #46

Earlier quoted context omitted.

I have had extremely bad luck, reporting bugs to Apple. They constantly ask for an example project, even if it's something that is easily demonstrated, simply by running existing Apple software, and creating a project, would be a huge pain. They also ignore reports. Very rarely, I may get a ping on one of my reports, asking me to verify that it was fixed in some release. Otherwise, there's no sign that they ever even…

Not to hand wave-- but this feels industry standard IMO. I have a dozen PRs sitting unacknowledged and stale across a handful of FAANG (and other) repos, including Apple's. I start my first day @ Apple in a few weeks, so I ACK that my opinion might be a little biased here.

Did you take a job at Apple just so you can accept one or more of those PR's that's been bugging you? :)

Wasn't there an xkcd about that scenario...

Re: Apple Photos app corrupts images

#175

Post by ffsm8 »

soperj wrote: post #170
myshkin5 wrote: post #117

I’m a fan of the whole Apple ecosystem but I have to say that there’s a pattern here. Apple does a decent job of keeping my data safe from others but a terrible job of keeping it intact. From music libraries with song titles that got switched to long integers to this (and I’m sure more that I’m not remembering atm) they need to do a better job here. Sure security is important but integrity is too.

[flagged]

They were also active participants in prism...

https://en.m.wikipedia.org/wiki/PRISM

What they actually do is a moderate effort to keep app developers from accessing user data. Which is definitely good!

Though the reason for this likely more about keeping the customer relationship with apple then actually protecting the privacy of users, but it's a nicely marketable side effect - and that's definitely a good thing for the users, too!

Re: Apple Photos app corrupts images

#176

Post by ajkjk »

myshkin5 wrote: post #117

I’m a fan of the whole Apple ecosystem but I have to say that there’s a pattern here. Apple does a decent job of keeping my data safe from others but a terrible job of keeping it intact. From music libraries with song titles that got switched to long integers to this (and I’m sure more that I’m not remembering atm) they need to do a better job here. Sure security is important but integrity is too.

I think of Apple as blessed and cursed by hubris. The same arrogance that lets them assert a design into the world on the belief that people will adopt it allows them to incapable of changing at the things they are bad or deplorable at.

Re: Apple Photos app corrupts images

#177

Post by BeFlatXIII »

kokey wrote: post #58

Fortunately it mentions early on in the article that this is related to an Olympus camera so I'm guessing this has something to do with the OM system's flavor of Olympus's proprietary ORF format.

This would not surprise me. For whatever reason, ORF files from the TG-4 import fine, but CoreRAW doesn't handle the TG-6, so I need to either use RAW+JPEG or convert to DNG.

Re: Apple Photos app corrupts images

#178

Post by jm4 »

ffsm8 wrote: post #175
soperj wrote: post #170

Earlier quoted context omitted.

[flagged]

They were also active participants in prism... https://en.m.wikipedia.org/wiki/PRISM What they actually do is a moderate effort to keep app developers from accessing user data. Which is definitely good! Though the reason for this likely more about keeping the customer relationship with apple then actually protecting the privacy of users, but it's a nicely marketable side effect - and that's definitely a good thing fo…

Anybody who was anybody back then was an active participant in PRISM. There are no good guys and bad guys when it comes to that. There are businesses that get to keep doing business by doing what the government tells them to do, there are ones that shut down (Lavabit), and there are ones that don't have enough going on to be on the radar for a project like PRISM.

Re: Apple Photos app corrupts images

#180

Post by yard2010 »

> Turns out “delete after import” was a huge mistake.

I learned the hard way to never delete photos from the SD. Just buy a new one it's so cheap anyway.

Great article by the way, sounds like my kind of rabbit hole :)

Post reply on HN