Earlier quoted context omitted.
> I don’t think people express these things nearly as often as they feel them, and I expect that many of the positive things that do end up communicated have another motive behind them. I have the displeasure of working with a team member who does the exact opposite: at every chance he gets, he expressed his displeasure regarding other team members to management. Once I confronted him about that behavior and he state…
I hear you. But having once worked with team-members who take critique at anything, personally, I feel there is more to this. I always try to praise a person. But I also want to "reserve all rights" to say that a codebase is crap or a choice made in the past was evidently a bad choice. Finding the balance to critique work that a person contributed to, without criticising that person itself, is hard. A true challenge,…
Criticizing the code itself (with useful feedback), and not the person who wrote it, gives them a chance to own up to it if they're comfortable with doing that. And if not, you're still able to improve the codebase without directly calling them out.
If they get pissy about it, that's on them.