Twelve Go Best Practices

Post by azth » Fri, Aug 02, 2013, 4:07 AM UTC

EdiX wrote: post #141

brianberns wrote: post #76

Earlier quoted context omitted.

Because the alternative is worse. If you test-and-return after every call, your function has multiple exit points and is far less maintainable. If you nest like this, you at least have a chance of maintaining a single exit point in your function (even though this example fails to do so). This is why the Lord invented exceptions, which it seems that Go does not use. This one example is enough to convince me to never u…

> If you test-and-return after every call, your function has multiple exit points and is far less maintainable. There is nothing wrong with multiple exit points as long as: a. the language has a mechanism for scoped resource allocation (ie. defer, finally, with, unwind-protect or "RAII") b. the early exit doesn't happen in the middle of a long and complex function

Post by inkel » Sun, Aug 04, 2013, 7:17 PM UTC

EdiX wrote: post #143

ktt wrote: post #23

Interesting that this snippet: func (g *Gopher) DumpBinary(w io.Writer) error { err := binary.Write(w, binary.LittleEndian, int32(len(g.Name))) if err != nil { return err } _, err = w.Write([]byte(g.Name)) if err != nil { return err } err = binary.Write(w, binary.LittleEndian, g.Age) if err != nil { return err } return binary.Write(w, binary.LittleEndian, g.FurColor) } could be written like this: func (g *Gopher) Dum…

func must(err error) { if err != nil { panic(err) } } func (g *Gopher) DumpBinary(w io.Writer) (err error) { defer func() { err, _ = recover().(error) } must(binary.Write(w, binary.LittleEndian, int32(len(g.Name)))) must(w.Write([]byte(g.Name))) must(binary.Write(w, binary.LittleEndian, g.Age)) must(binary.Write(w, binary.LittleEndian, g.FurColor)) return }