Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Amazon CodeGuru – Preview

aws.amazon.com

Post reply on HN
Print view View original

151–160 of 209 posts

Re: Amazon CodeGuru – Preview

#151

Post by paulddraper »

justwalt wrote: post #97
paulddraper wrote: post #91

Earlier quoted context omitted.

My hot take is that if you can automatically detect meaningful bugs or author fixes, you need to level up your abstraction. I think these things make the most sense for Java and Go where there tends to be lots of repetition and lower-order programming patterns. Unlike say, Python, Lisp, or Rust.

I’ve never programmed in Java or Go in any serious context. What do some of those repeated patterns look like?

Error handling in Go.

Lots and lots of getters and setters in Java.

Re: Amazon CodeGuru – Preview

#152

Post by takeda »

Sebguer wrote: post #126
NegativeLatency wrote: post #125

Earlier quoted context omitted.

It's still increasing your dependence on AWS systems and software. (The upsell price may be free for now, but who knows maybe they add a premium version or enterprise features in the future) I imagine that the tool will be used for recommending more amazon services in the future, and this is possibly a poor POC of more to come.

It's not an AWS system or service at all though... This is like saying that using React will lead you to be locked into Facebook?

So why is it under AWS[1]?

[1] https://aws.amazon.com/corretto/

Re: Amazon CodeGuru – Preview

#153

Post by bentcorner »

gregdunn wrote: post #93

Disclaimer: I work at AWS on an unrelated team. I was not involved in development of this product. Opinions stated are my own, and not necessarily a reflection of my employer. Nothing here is being posted in any sort of official capacity. There's lots of focus here in the comments on the code reviewer portion, but one of the things I'm most excited about is the profiler - https://aws.amazon.com/codeguru/features/ I d…

Does anyone know of a good flame graph visualizer for callstacks? Particularly one that allows you to drill down into a stack. Bonus points if you can diff two data sets. I recently built an in-app profiler and am trying to work out the analysis side of things to make life easier for the other developers on my team.

Re: Amazon CodeGuru – Preview

#154

Post by cowsandmilk »

ghostpepper wrote: post #127
Sebguer wrote: post #126

Earlier quoted context omitted.

It's not an AWS system or service at all though... This is like saying that using React will lead you to be locked into Facebook?

Why does it have Amazon in the name then? Amazon Coretto?

Amazon Corretto Crypto Provider ACCP Is a Java library you can install using Maven or Gradle that works with any JDK 8 on Linux x86_64. It has Amazon in the name because Amazon wrote the library....

The name might be awkward, and codeguru might be slanted towards suggesting open source libraries written at Amazon, but it is about as neutral as can be, not even requiring you to use Amazon’s OpenJDK distro.

Why does Amazon have an OpenJDK district though? Because sometimes Amazon sees performance issues at scale that they have a hot fix for. Then they share the patch with the wider OpenJDK community and have discussions about if there are better approaches to fix. Amazon has been one of the top contributors to OpenJDK releases recently (typically in top 3 for contributions to a given release), so they really are upstreaming patches.

Re: Amazon CodeGuru – Preview

#155

Post by Sebguer »

takeda wrote: post #152
Sebguer wrote: post #126

Earlier quoted context omitted.

It's not an AWS system or service at all though... This is like saying that using React will lead you to be locked into Facebook?

So why is it under AWS[1]? [1] https://aws.amazon.com/corretto/

The same reason React is under Facebook's github org? https://github.com/facebook/react

FYI, as I commented below, it's also available on Github under its own user and with a very permissive (GPLv2) license: https://github.com/corretto/corretto-8

Re: Amazon CodeGuru – Preview

#156

Post by JaRail »

femto113 wrote: post #63
ReidZB wrote: post #3

The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.

If it’s trained on software written by Amazon it’s probably worth the $3.75 just so you can do the exact opposite of what they recommend.

It'll probably generate irrelevant stats on the engineers to send directly to their managers to use against them in their next review.

Re: Amazon CodeGuru – Preview

#157

Post by bentcorner »

derision wrote: post #10
pc86 wrote: post #8

Earlier quoted context omitted.

This seems like a good incentive not to be generating thousands of lines of codes with each PR, which most would probably consider a feature as opposed to a bug.

exactly. IMO if you're generating code, it should happen at build/compile time not at checkin

I'm not a fan of this. My team does this a lot and invariably it leads to having stuff be unfindable because the source you really want is in your build directory and not in code search. Which is annoying but manageable if I build the project, but partners who don't will have an even harder time of things.

More recent efforts have us check in generated code alongside the "config" files, and automated processes ensure you check in the generated code if you touch the config file. It's much better this way.

Re: Amazon CodeGuru – Preview

#158

Post by JaRail »

ReidZB wrote: post #3

The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.

Tools like this should be built into your IDE. No developer ever wants automated feedback at the end of the process in a code review.

There are lots of academic ML review/suggestion tools. Those people come to the table with trials and statistics to assess the quality of their results. Amazon probably copied one of those papers, added a rules-engine to recommend their own APIs, and slapped a hefty price tag on it.

Re: Amazon CodeGuru – Preview

#159

Post by nivenhuh »

notjustanymike wrote: post #62
ReidZB wrote: post #3

The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.

Or when a junior dev switches from tabs to spaces

Or when a junior dev switches from spaces to tabs ;)
Post reply on HN