Earlier quoted context omitted.
The best advice I received on this topic was that feedback should be actionable, specific, and kind. Actionable and specific mean that the person on the receiving end has a set of concrete actions to take to implement. For example, "get better at programming" isn't specific, and "get a PhD in Computer Science" probably isn't actionable, but "work on improving your ability to write readable code by working through the…
> When giving feedback, some people say that they are brutally honest As someone who prefers giving and receiving terse feedback... I would suggest that there's nothing wrong with brutal honesty for type of people who appreciate receiving it . If I write code and forget to test some specific cases, I would much rather get a code review of "Missing tests for negative numbers, empty string, null" than a longwinded and…
Could you give an example of what you're imagining a longwinded nice version would be like? Because this seems mostly fine, just a bit clipped.
All I'd really expect to improve it is something like: "This is mostly fine. It just needs tests for negative numbers, empty strings and null." Adding just a few words validates their work, and more practically, it also clarifies that the criticisms are exhaustive.