Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

The GitHub website is slow on Safari

github.com

Post reply on HN
Print view View original

141–150 of 367 posts

Re: The GitHub website is slow on Safari

#141

Post by ori_b »

fkyoureadthedoc wrote: post #135
ori_b wrote: post #124

Earlier quoted context omitted.

It's frustrating, because GitHub used to perform quite well, before it was a single page app.

clicking around GitHub and checking network panel, it seems to load plenty of server rendered HTML. Some views seem to use React within the page, but it doesn't appear to be a React SPA.

Maybe I should have said pre-react. I don't know what GitHub did specifically, but several years ago it used to be reasonably fast and relatively pleasant to use. It regressed a lot over the last few years, seemingly correlated with attempts at interactive features.

Re: The GitHub website is slow on Safari

#142

Post by Sesse__ »

jchw wrote: post #131
Sesse__ wrote: post #105

Earlier quoted context omitted.

Interesting how _everyone_ here blames JS and React, yet the fixes you linked are about CSS performance.

You certainly can build slow apps with React, it doesn't make building slow things that hard. But honestly, React primitives (component mounting/unmounting, rendering, virtual DOM diffing, etc.) just aren't that slow/inefficient and using React in a fairly naive way isn't half-bad for data-heavy apps. I actually have been trying to figure out how to get my React application (unreleased) to perform less laggy in Safar…

> You certainly can build slow apps with React, it doesn't make building slow things that hard.

By all means. It sometimes feels like React is more the symptom than the actual issue, though.

Personally I generally just like having less code; generally makes for fewer footguns. But that's an incredibly hard sell in general (and of course not the entire story).

Re: The GitHub website is slow on Safari

#143

Post by mrbombastic »

slt2021 wrote: post #116
Zanfa wrote: post #90

Earlier quoted context omitted.

I’m pretty sure they used to do syntax highlighting on the server before and it was fast. Now they send down unhighlighted text that seems to choke the browser with anything but the smallest diffs.

the problem is developers having fast modern machines. if they were forced to use slow machines, they would not be able to put out crap like that

M4 macbook pro and almost unusably slow

Re: The GitHub website is slow on Safari

#144

Post by [deleted] »

eviks wrote: post #121
shadowgovt wrote: post #106

Earlier quoted context omitted.

Ideally, you automate a check like that. Because the answer turns out to actually be "humans are profoundly bad at that kind of pattern recognition." A computer will be able to tell that the 497th has a misspelled `CusomerEmail` or that change 829 is a regexp failure that trimmed the boolean "CustomerEmailAddressed" to "CustomerEmailed" with 100% reliability; humans, not so much.

Oh, certainly, didn't mean that you had to avoid using your IDE to autorename a variable yourself (to avoid the boolean issue) and diffed results to those of the PR Or that you had to avoid Ctrl+F "CustomerEmail" and see whether you had 1000 matches that matches the number of changed files or only 999 due to some typo. Or using the web interface to filter by file type to batch your reviews. Or... Just that in none of…

[deleted]

Re: The GitHub website is slow on Safari

#145

Post by gloosx »

makeitdouble wrote: post #136
gloosx wrote: post #132

Earlier quoted context omitted.

> a single well made react app What about Slack, the messenger? Umm, Discord? SoundCloud? Trello? Bandcamp? Spotify? If I keep going there are actually hundreds and thousands of well-made react apps.

Isn't the most common complaint against Slack that it's not optimized enough for what it does ? That's how I read the rants against its electron app, and people are already choosing the electron app against using it straight in the browser (as they'd do for Gmail or Calendar for instance)

Slack is one the most slick and pleasant pieces of software to use. It's big success as well as the fact that it's acquisition cost was one of the largest software deals ever – tells of itself – it's certainly a fine piece of software made by fine engineers who used react and electron with a certain amount of dignity. People who rant about tools like react or electron affecting their performance just don't want to understand that it's organisation and people behind the tools who are responsible for their performance.

Re: The GitHub website is slow on Safari

#146

Post by dpkirchner »

lazypenguin wrote: post #102
adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

I don't hate React developers. I hate developers who build consumer facing software and use top of the line hardware and networks to test it while being ignorant to the fact that most of their users will be using their products on 8+ year old consumer grade hardware over spotty 3G

And then there's the devs and PMs that have an irrational fear of the back button -- enough so that they never ever use it on their SPA.

Re: The GitHub website is slow on Safari

#147

Post by bityard »

bob1029 wrote: post #32
patrickmay wrote: post #21

Earlier quoted context omitted.

That seems essentially unreviewable. If you can share without violating an NDA, what kind of PR would involve that many files?

"Upgrade solution from .NET Framework 4.8 => .NET 8" "Rename 'CustomerEmailAddress' to 'CustomerEmail'" "Upgrade 3rd party API from v3 to v4" I genuinely don't get this notion of a "max # of files in a PR". It all comes off to me as post hoc justification of really shitty technology decisions at GitHub.

I've always thought those kinds of large-scale search-and-replace diffs should not generally be expected to be reviewed. If a review is 1000's of lines of identical changes (or newly-vendored code), literally nobody is actually reading it, even if they are somehow able to convince themselves that they are.

I would rather just see the steps you ran to generate the diff and review that instead.

Re: The GitHub website is slow on Safari

#148

Post by c-hendricks »

Something did change with Safari when handling lots of DOM nodes around the last major release of all Apple's operating systems.

I have an ever growing directory listing using SolidJS, and it's up to about 25,000 items. Safari macOS and iOS two major versions ago actually handled it well. After the last major update, my phone rendered it faster than an m1 MacBook Pro.

Re: The GitHub website is slow on Safari

#149

Post by throw-the-towel »

agos wrote: post #62
bob1029 wrote: post #53

Earlier quoted context omitted.

You're right. The technology is not necessarily flawed. It is more about the people who decided to use it and the way in which they used it.

exactly. I don't want to do a "no true scotsman" to defend React, but circumstantial evidence suggests that they wildly misused the tool

A tool that lends itself to misuse so easily is a bad tool, period.

Re: The GitHub website is slow on Safari

#150

Post by captn3m0 »

ori_b wrote: post #141
fkyoureadthedoc wrote: post #135

Earlier quoted context omitted.

clicking around GitHub and checking network panel, it seems to load plenty of server rendered HTML. Some views seem to use React within the page, but it doesn't appear to be a React SPA.

Maybe I should have said pre-react. I don't know what GitHub did specifically, but several years ago it used to be reasonably fast and relatively pleasant to use. It regressed a lot over the last few years, seemingly correlated with attempts at interactive features.

It used to be jQuery + PJAX
Post reply on HN