If You Call Out Bad Code, Make Sure It's Bad First • Hacker News Board

Re: If You Call Out Bad Code, Make Sure It's Bad First

#131

Post by klibertp » Fri, Jan 25, 2013, 10:27 AM UTC

fernandezpablo wrote: post #38

I just gave the code a quick look and I find this `eval` usage not too cool: https://github.com/harthur/replace/blob/master/replace.js#L4... It relies on the fact that you can provide javascripts String#replace a "replace function" (1). The author just evals the contents of a command line provided file into a variable called `replaceFunc`. Beside that, there's not a lot that can be pointed out as "bad", at least by j…

As VMG writes, it's one of a few places where 'eval' is the right tool for the job. In this case you either have to drop the feature (of providing replacement function), implement your own language/DSL that compiles down to JS function or just use eval.

What would you do in this case?

Re: If You Call Out Bad Code, Make Sure It's Bad First

#132

Post by MartinCron » Fri, Jan 25, 2013, 3:52 PM UTC

SyneRyder wrote: post #127

MartinCron wrote: post #74

Earlier quoted context omitted.

I have shared literally thousands of photos on Flickr. Nobody has told me that my photos shouldn't exist of that my photos make their eyes bleed. Can we, as a community, be at least as nice as serious amateur photographers?

Perhaps you haven't found "You Are Not A Photographer" yet. Some photography communities have a similar level of snark and calling out others, sadly.

I thought about that site, which is terrible. It feels a little different in that it seems to be fueled by insecure pro photogs who want to instill fear of hiring second-rate hacks.

Maybe I should be, but I am generally unafraid of sharing my photos.

http://Flickr.com/photos/martincron

Re: If You Call Out Bad Code, Make Sure It's Bad First

#133

Post by swartzrock » Fri, Jan 25, 2013, 5:13 PM UTC

clhodapp wrote: post #126

swartzrock wrote: post #48

I enjoyed reading David's post and only have one issue: Oxford Comma? Seriously? That's ridiculous, unnecessary and unparsable.

You pause there in speaking, so you should put a comma there.

Unless I increased my speaking rate to prevent the awkward situation of requiring the comma... or perhaps there never was a pause there (eg "eats shoots...")

Re: If You Call Out Bad Code, Make Sure It's Bad First

#134

Post by jussij » Sat, Jan 26, 2013, 2:46 AM UTC

pbiggar wrote: post #104

jussij wrote: post #68

Earlier quoted context omitted.

> windows has nothing unless you have cygwin A lot of the Unix tools (including SED) run just fine on Windows without cygwin: http://www.zeusedit.com/zforum/viewtopic.php?p=2683

Right, you need to install them. Having node is a less onerous requirement than having all the gnu tools, on windows.

These are just simple copy installs and they don't require any cygwin install.

I suspect they would be easier to install than node.