Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Issue links now open in a popup

github.com

Post reply on HN
Print view View original

131–138 of 138 posts

Re: Issue links now open in a popup

#131

Post by zerd »

snailmailman wrote: post #70
c-hendricks wrote: post #63

Earlier quoted context omitted.

Every bit of intuition you have using a browser, really? You click a link, the current page changes, you click back, it goes away. You cmd/ctrl click it opens in a new window, you right click and select "open in new tab/window" and it opens in a new tab / window.

Now, when you click a link in GitHub, the current page doesnt change . I want to look at the linked issue on its own page. That doesn’t occur anymore. The page i wanted to go to pops up in a small overlay on the right hand side. The body text and content that I wanted to view is in a new, weird location, with the old page still behind it in the normal spot. It’s very unintuitive. Thankfully either the behavior has re…

Also it breaks copying links. If I want to link to an issue I copy the URL. But now there's two different issues open at the same time, which one am I linking to? Original? Popup? Both?

Re: Issue links now open in a popup

#132

Post by c-hendricks »

snailmailman wrote: post #70
c-hendricks wrote: post #63

Earlier quoted context omitted.

Every bit of intuition you have using a browser, really? You click a link, the current page changes, you click back, it goes away. You cmd/ctrl click it opens in a new window, you right click and select "open in new tab/window" and it opens in a new tab / window.

Now, when you click a link in GitHub, the current page doesnt change . I want to look at the linked issue on its own page. That doesn’t occur anymore. The page i wanted to go to pops up in a small overlay on the right hand side. The body text and content that I wanted to view is in a new, weird location, with the old page still behind it in the normal spot. It’s very unintuitive. Thankfully either the behavior has re…

Right, not saying it's not annoying, but "every intuition about using a browser" is a bit over the top. A link can open a dialog, has been happening for decades.

Re: Issue links now open in a popup

#133

Post by nfw2 »

self_awareness wrote: post #127
dewski wrote: post #91

Earlier quoted context omitted.

I was responsible for this going out. The goal was to provide a more consistent user experience in that what happens when you click an issue would be the same in more places where we use the issue viewer (sub-issues on an issue, our dedicated issues dashboard ( https://github.com/issues ), GitHub Projects, and others). Like you mentioned, you also wouldn't lose your place when clicking an issue reference when reading…

Did you get feedback from users that this change is needed? Or was it your (GitHub's) idea and initiative/vision?

This is feedback from me, a user, that the change was beneficial

Re: Issue links now open in a popup

#134

Post by em-bee »

pidgeon_lover wrote: post #128
crtasm wrote: post #42

Earlier quoted context omitted.

Split tabs are now in: https://support.mozilla.org/en-US/kb/split-view-firefox

I don't understand why browser-makers don't leave window management to the window manager. Split view has been standard in Windows (and probably Linux?) since 2009. I know Mac doesn't really do split windows without additional software, but that's an Apple-being-awkward problem.

just putting windows side by side is not enough. i need to be able to treat those two side by side windows as a unit: see how i use it as an example here: https://news.ycombinator.com/item?id=47913202

no windowmanager anywhere supports that. even tabs could have been solved by window managers. but then we could not get inactive tabs, and the same is true for the tabs in splitview.

if lack of support for inactive tabs are no issue and if you don't use workspaces much, you could use those as a workaround. but that unfortunately at least gnome workspaces are not flexible enough for that. (i'd need dynamic creation of workspaces without automatic destruction, and i'd need gnome to remember which window goes into which workstation. that used to be a feature on some windowmanagers, but i haven't found any that can distinguish multiple windows from the same app.)

Re: Issue links now open in a popup

#135

Post by madeofpalk »

bsuvc wrote: post #111
Matt138 wrote: post #66

This was a performance driven change. We added this as loading a cross repo issue is a much slower experience than loading an issue in the same repo due to the way the header is loaded (which is being worked on). But we hear you on the feedback - we will roll this back while we keep pushing on the root performance causes. [update - this change has been reverted and the previous behaviour is back]

> loading a cross repo issue is a much slower experience Why not solve the real problem instead of putting in a janky workaround? At risk of being cliche, it seems like you guys could benefit from the 5 Whys approach here: "Why is loading a cross repo issue slow?" and iterate until you discover the root cause, and fix that. I suspect fixing the root cause is going to be a lot less glorious career-wise than implementi…

Maybe fixing the root cause is slower, and this janky workaround was quicker as its something largely already built (a few views/links in Github already open issues in a drawer).

You've never done a temporary fix to stop the bleeding?

Re: Issue links now open in a popup

#136

Post by embedding-shape »

userbinator wrote: post #108
Banditoz wrote: post #83

Earlier quoted context omitted.

How did the performance of GitHub become so slow in the first place? It didn't used to be this bad years ago.

From what I remember, it got much worse the moment they started requiring JS for displaying what would otherwise be mostly static (and thus easily cached) content.

Used to be full page loads when you clicked on links too, performance got a lot worse (for me), both network-wise and client-side-wise when that changed.

Re: Issue links now open in a popup

#137

Post by odo1242 »

odo1242 wrote: post #54
chuckadams wrote: post #10

Earlier quoted context omitted.

I don't think there is such a thing as perfect UX and I'm not asking for it. I just want them to stop making it worse . Seriously tho, why isn't this something that a browser can do? Why can't I just split a tab and say all links from the left tab open in the right? Why not be able to scroll through history as a list of such panes like a smalltalk browser or file explorer on a mac? Maybe even a history tree, able to…

You might like Zen Browser

https://zen-browser.app/ - it’s not exactly what you describe but it’s basically redesigned from the ground up for the same interaction model
Post reply on HN