Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

The GitHub website is slow on Safari

github.com

Post reply on HN
Print view View original

131–140 of 367 posts

Re: The GitHub website is slow on Safari

#131

Post by jchw »

Sesse__ wrote: post #105
muglug wrote: post #5

Improvements merged within the last two days by the WebKit team: https://github.com/orgs/community/discussions/170922#discuss... For my sins I occasionally create large PRs (> 1,000 files) in GitHub, and teammates (who mostly all use Chrome) will sometimes say "I'll approve once it loads for me..."

Interesting how _everyone_ here blames JS and React, yet the fixes you linked are about CSS performance.

You certainly can build slow apps with React, it doesn't make building slow things that hard. But honestly, React primitives (component mounting/unmounting, rendering, virtual DOM diffing, etc.) just aren't that slow/inefficient and using React in a fairly naive way isn't half-bad for data-heavy apps.

I actually have been trying to figure out how to get my React application (unreleased) to perform less laggy in Safari than it does in Firefox/Chrome, and it seems like it is related to all the damn DOM elements. This sucks. Virtualizing viewports adds loads of complexity and breaks some built-in browser features, so I generally prefer not to do it. But, at least in my case, Safari seems to struggle with doing certain layout operations with a shit load of elements more than Chrome and Firefox do.

Re: The GitHub website is slow on Safari

#132

Post by gloosx »

adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

> a single well made react app

What about Slack, the messenger?

Umm, Discord? SoundCloud? Trello? Bandcamp? Spotify?

If I keep going there are actually hundreds and thousands of well-made react apps.

Re: The GitHub website is slow on Safari

#133

Post by makeitdouble »

adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

Yes, SPAs are inherently a very niche concept that has been applied to too many things for the wrong reasons.

On react, it's funny that sites where the frontend part is really crucial tend to move away from generic frameworks and do really custom stuff to optimize. I'm thinking about Notion, or Google Sheets, or Figma, where the web interface is everything and pretty early on they just bypass the frontend stacks generally used by the industry.

Re: The GitHub website is slow on Safari

#134

Post by Aldipower »

adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

Tredict is a webapp written in React that works for me since years. It is fast, stable and useful.

The problem isn't React. The problem are KPIs and unrealistic timeline. It is the same then ever. Not a fault of React at all.

Re: The GitHub website is slow on Safari

#135

Post by fkyoureadthedoc »

ori_b wrote: post #124
PedroBatista wrote: post #11

The Github website is slow everywhere. It is truly a piece of shit software both in terms of performance but also UX/UI and everything in between. It's a product of many cooks and their brilliant ideas and KPIs, a social network for devs and code being the most "brilliant" of them all. For day to day dev operations is something so mediocre even Gitlab looks like the golden standard compared to Github. And no, the pro…

It's frustrating, because GitHub used to perform quite well, before it was a single page app.

clicking around GitHub and checking network panel, it seems to load plenty of server rendered HTML. Some views seem to use React within the page, but it doesn't appear to be a React SPA.

Re: The GitHub website is slow on Safari

#136

Post by makeitdouble »

gloosx wrote: post #132
adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

> a single well made react app What about Slack, the messenger? Umm, Discord? SoundCloud? Trello? Bandcamp? Spotify? If I keep going there are actually hundreds and thousands of well-made react apps.

Isn't the most common complaint against Slack that it's not optimized enough for what it does ? That's how I read the rants against its electron app, and people are already choosing the electron app against using it straight in the browser (as they'd do for Gmail or Calendar for instance)

Re: The GitHub website is slow on Safari

#137

Post by bityard »

accrual wrote: post #128
ssttoo wrote: post #118

Earlier quoted context omitted.

After 10 years of using Phabricator at a previous company I am still shocked how bad GitHub is. This the industry standard?! Too bad Phabricator is maintenance-only now https://en.m.wikipedia.org/wiki/Phabricator

Looks like a new community developed fork of Phabricator is up! I've never used it but glad to see the project continues. https://we.phorge.it/

I tried poking around but it looks like you have to be logged into to view the source, and registration requires manual approval. :/

I assume this is fallout from dealing with LLM content scrapers.

Re: The GitHub website is slow on Safari

#138

Post by jasonjmcghee »

A regular GitHub annoyance for me is the propensity to lose the browser history for the main repo page.

On random site, Navigate to GitHub repo, navigate to file in repo, and hit back, and I'm on the random site, hit forward and I'm on the file.

So annoying.

One of a large handful of issues I've encountered post react conversion

Re: The GitHub website is slow on Safari

#139

Post by sipjca »

makeitdouble wrote: post #125
dylan604 wrote: post #104

Earlier quoted context omitted.

> on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13 I know some people feel like Apple is aggressive in this respect, but that's an 8 year old version of a browser. That's like taking off all of the locks on your house, leaving the doors and windows open all while expecting your house to never have uninvited guests.

But Apple is also the one locking Safari to the OS, IE style. Having to buy a new machine to get the latest and secure version of a browser is a pretty heavy requirement.

i mean there are also lots of browser options to be fair.

should they be locking safari to the OS, definitely not. but users can just go download another browser if they are actually concerned.

Re: The GitHub website is slow on Safari

#140

Post by w0m »

makeitdouble wrote: post #125
dylan604 wrote: post #104

Earlier quoted context omitted.

> on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13 I know some people feel like Apple is aggressive in this respect, but that's an 8 year old version of a browser. That's like taking off all of the locks on your house, leaving the doors and windows open all while expecting your house to never have uninvited guests.

But Apple is also the one locking Safari to the OS, IE style. Having to buy a new machine to get the latest and secure version of a browser is a pretty heavy requirement.

or use a supported OS (linux, or hilariously probably Windows), or install a still-suppored browser (I'd guess Firefox likely still runs latest on there).

I'd put it on the end user for not updating software on 15 y/o hardware and still expecting the outside world to interact cleanly.

Post reply on HN