Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Issue links now open in a popup

github.com

Post reply on HN
Print view View original

121–130 of 138 posts

Re: Issue links now open in a popup

#121

Post by Telaneo »

dewski wrote: post #118
Telaneo wrote: post #40

Earlier quoted context omitted.

> Utterly insane that this went through QA. Big assumption you're making there.

All new features are gated behind feature flags that progress from the developing team, to all GitHub employees, then to public over a multi-week span. Larger changes like this one have an internal discussion post shared with the company and a changelog entry once published.

I'm not sure that's all that much better. I'm not sure what's worse. There not being QA, or things just flowing right through QA. I guess still the former, since when there is QA, it's probably still filtering off some of the insanity. It's just that it's never seen by the greater public.

Re: Issue links now open in a popup

#122

Post by justinclift »

Xunjin wrote: post #73
Matt138 wrote: post #66

This was a performance driven change. We added this as loading a cross repo issue is a much slower experience than loading an issue in the same repo due to the way the header is loaded (which is being worked on). But we hear you on the feedback - we will roll this back while we keep pushing on the root performance causes. [update - this change has been reverted and the previous behaviour is back]

To be honest GitHub should have like a switch for "preview stuff adopter" where you guys could give any benefits for it (maybe more copilot usage?). This way you can test with a specific public, using metrics and feedback, while testing and people could comment more about it.

> GitHub should have like a switch for "preview stuff adopter"

They do. And they tend to avoid using it, and/or ignore feedback if it's not in line with the direction that they actually want to go. :( :( :(

Re: Issue links now open in a popup

#123

Post by justinclift »

nikanj wrote: post #92
willio58 wrote: post #7

It’s always been interesting to me that multi-million and even billion dollar tech companies don’t have perfect websites in terms of UX. Just last night I was helping my GF set up an ad for her job on LinkedIn. The UX was terrible. Like awful and basic things like save and exit were completely broken. Meanwhile LinkedIn makes what percentage of their revenue through ads? Same with google ads. It’s like these products…

The metric for perfect is -Does it drive more people to the app -Does it maximize time spent on the site -etc Your idea of perfect is very different than the one LinkedIn is using

> Does it maximize time spent on the site

That one in particular is super dangerous.

It can incorrectly lead to a process that used to be a 5 second thing suddenly becoming a back and forth 2 hour nightmare, because the metrics show "user spends more time on site".

Though in reality it turned the user from a happy user into a frustrated one whose likely to exit the platform.

Oh, GitHub is probably using a variant of this metric... :)

Re: Issue links now open in a popup

#124

Post by joshmn »

Matt138 wrote: post #84
mvdtnz wrote: post #78

Earlier quoted context omitted.

I can't speak for GitHub but I've worked on multiple nav headers for large SaaS products and they can be ridiculously heavy weight to render given they appear on every page. They tend to be a dumping ground for features, many of which require their own permissions checks, feature flag checks, etc. it's not unusual to have to perform hierarchical permissions checks. They also tend to contain contextual info about the…

Yes, pretty much this as well as some additional complexities due to the issue content being in React and the header in Rails - to the cost of approx 500-800ms p50 for a page load vs sub 100ms for a nav to an issue in the same repo (or without the header which is what we tried with this change here)

is `current_user` really costing that much?

Re: Issue links now open in a popup

#125

Post by shepherdjerred »

rafram wrote: post #80
vbezhenar wrote: post #69

Earlier quoted context omitted.

I hate that feature and I hate that they keep bloating browser which was lightweight. Just for the record.

When was Chrome lightweight? 15 years ago?

Didn't it used to be branded as lightweight?

https://techcrunch.com/2010/09/02/google-chrome-birthday/

> I fondly remember the good old days of 2004 when I first started using Firefox as my main browser and thinking how fresh and lightweight it felt compared to the atrocity that was IE. Firefox, sadly, got bloated over the years. So far, Chrome hasn’t put on the same weight

Re: Issue links now open in a popup

#127

Post by self_awareness »

dewski wrote: post #91
nfw2 wrote: post #77

Being able to see a detail view without navigating away from the list view is a better user experience and the more common practice now

I was responsible for this going out. The goal was to provide a more consistent user experience in that what happens when you click an issue would be the same in more places where we use the issue viewer (sub-issues on an issue, our dedicated issues dashboard ( https://github.com/issues ), GitHub Projects, and others). Like you mentioned, you also wouldn't lose your place when clicking an issue reference when reading…

Did you get feedback from users that this change is needed? Or was it your (GitHub's) idea and initiative/vision?

Re: Issue links now open in a popup

#128

Post by pidgeon_lover »

crtasm wrote: post #42
chuckadams wrote: post #10

Earlier quoted context omitted.

I don't think there is such a thing as perfect UX and I'm not asking for it. I just want them to stop making it worse . Seriously tho, why isn't this something that a browser can do? Why can't I just split a tab and say all links from the left tab open in the right? Why not be able to scroll through history as a list of such panes like a smalltalk browser or file explorer on a mac? Maybe even a history tree, able to…

Split tabs are now in: https://support.mozilla.org/en-US/kb/split-view-firefox

I don't understand why browser-makers don't leave window management to the window manager. Split view has been standard in Windows (and probably Linux?) since 2009. I know Mac doesn't really do split windows without additional software, but that's an Apple-being-awkward problem.

Re: Issue links now open in a popup

#129

Post by [deleted] »

odo1242 wrote: post #54
chuckadams wrote: post #10

Earlier quoted context omitted.

I don't think there is such a thing as perfect UX and I'm not asking for it. I just want them to stop making it worse . Seriously tho, why isn't this something that a browser can do? Why can't I just split a tab and say all links from the left tab open in the right? Why not be able to scroll through history as a list of such panes like a smalltalk browser or file explorer on a mac? Maybe even a history tree, able to…

You might like Zen Browser

[deleted]

Re: Issue links now open in a popup

#130

Post by rafram »

shepherdjerred wrote: post #125
rafram wrote: post #80

Earlier quoted context omitted.

When was Chrome lightweight? 15 years ago?

Didn't it used to be branded as lightweight? https://techcrunch.com/2010/09/02/google-chrome-birthday/ > I fondly remember the good old days of 2004 when I first started using Firefox as my main browser and thinking how fresh and lightweight it felt compared to the atrocity that was IE. Firefox, sadly, got bloated over the years. So far, Chrome hasn’t put on the same weight

So, yes, 15 years ago.
Post reply on HN