Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

The GitHub website is slow on Safari

github.com

Post reply on HN
Print view View original

121–130 of 367 posts

Re: The GitHub website is slow on Safari

#121

Post by eviks »

shadowgovt wrote: post #106
eviks wrote: post #84

Earlier quoted context omitted.

How much working memory/attention span is required to look through 1000 identical lines "-CustomerEmailAddress +CustomerEmail"?

Ideally, you automate a check like that. Because the answer turns out to actually be "humans are profoundly bad at that kind of pattern recognition." A computer will be able to tell that the 497th has a misspelled `CusomerEmail` or that change 829 is a regexp failure that trimmed the boolean "CustomerEmailAddressed" to "CustomerEmailed" with 100% reliability; humans, not so much.

Oh, certainly, didn't mean that you had to avoid using your IDE to autorename a variable yourself (to avoid the boolean issue) and diffed results to those of the PR

Or that you had to avoid Ctrl+F "CustomerEmail" and see whether you had 1000 matches that matches the number of changed files or only 999 due to some typo.

Or using the web interface to filter by file type to batch your reviews.

Or...

Just that in none of those cases there is anything close to our memory/attention capacity.

Re: The GitHub website is slow on Safari

#122

Post by hk1337 »

PedroBatista wrote: post #94
leosanchez wrote: post #87

Earlier quoted context omitted.

It is faster than GitLab, at least to me.

Is your deployment SaaS or running on your company servers? Gitlab is anything but light, by default tends to be slow, but surprisingly fast with a good server ( nothing crazy, but big ) and caching.

It's probably not related to the speed and I am not entirely certain how Github stores the repository but I noticed Gitlab does something weird to the bare repository so it's not directly usable as a bare repository.

Gitea is an example I like because it stores the repository as a bare repository, the same as if I did git clone --bare. I bring it up because when I stopped running Gitea, I could easily go in to the data and backup all the repositories an easily reuse them somewhere else.

Re: The GitHub website is slow on Safari

#123

Post by disgruntledphd2 »

AndreasHae wrote: post #100
adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

The hate is more geared towards SPAs in general, but there are some shining examples that show that a well-made React/Angular/whatever app can have great UX - Clockify being one of them. I don’t think the culprit apps would have substantially better UX if they were rendered on the server, because these issues tend to be a consequence of devs being pressured to rapidly release new features without regard to quality.

And to be fair, the problems that Facebook had when they introduced React are not common problems at all.

As an aside, I was an employee around then and I vividly remember that the next half there was a topline goal to improve web speed. Hmmmm, I wonder what could have happened?

Re: The GitHub website is slow on Safari

#124

Post by ori_b »

PedroBatista wrote: post #11

The Github website is slow everywhere. It is truly a piece of shit software both in terms of performance but also UX/UI and everything in between. It's a product of many cooks and their brilliant ideas and KPIs, a social network for devs and code being the most "brilliant" of them all. For day to day dev operations is something so mediocre even Gitlab looks like the golden standard compared to Github. And no, the pro…

It's frustrating, because GitHub used to perform quite well, before it was a single page app.

Re: The GitHub website is slow on Safari

#125

Post by makeitdouble »

dylan604 wrote: post #104
zackmorris wrote: post #57

GitHub moved to a JavaScript rendering mode almost as soon as Microsoft bought it. Previously, I had been able to browse it with JavaScript disabled on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13. So even if I enable JavaScript, I can no longer browse GitHub, because they didn't bother to make their build compatible with browser versions as old as mine. It's hard to know which member of…

> on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13 I know some people feel like Apple is aggressive in this respect, but that's an 8 year old version of a browser. That's like taking off all of the locks on your house, leaving the doors and windows open all while expecting your house to never have uninvited guests.

But Apple is also the one locking Safari to the OS, IE style. Having to buy a new machine to get the latest and secure version of a browser is a pretty heavy requirement.

Re: The GitHub website is slow on Safari

#126

Post by cratermoon »

whstl wrote: post #45
terminalbraid wrote: post #38

Earlier quoted context omitted.

As someone who has worked in and with large orgs, the better question is "why does this always happen?". In large organizations "ownership" of a product becomes more nebulous from a product and code standpoint due to churn and a focus on short-sighted goals. If you put a lot of momentum behind a product with that mentality you get features piled on tech debt, no one gets enthusiastic about paying that down because it…

At this point "ownership" is just a buzzword thrown around by management types that has no meaning. If a developer has to put up a fight in order to push back against the irresponsibility of a non-technical person, they by definition don't have ownership.

I've seen shops where ownership is used as a cudgel to punish unruly developers. If the task isn't done as specified and on time, the developer is faulted for not taking ownership, but that "ownership" is meaningless, as you note, because it does not extend to pushing back against irresponsible or unreasonable demands.

Re: The GitHub website is slow on Safari

#127

Post by __alexs »

slt2021 wrote: post #116
Zanfa wrote: post #90

Earlier quoted context omitted.

I’m pretty sure they used to do syntax highlighting on the server before and it was fast. Now they send down unhighlighted text that seems to choke the browser with anything but the smallest diffs.

the problem is developers having fast modern machines. if they were forced to use slow machines, they would not be able to put out crap like that

It is garbage even on my extremely high end desktop PC.

Re: The GitHub website is slow on Safari

#128

Post by accrual »

ssttoo wrote: post #118
PedroBatista wrote: post #11

The Github website is slow everywhere. It is truly a piece of shit software both in terms of performance but also UX/UI and everything in between. It's a product of many cooks and their brilliant ideas and KPIs, a social network for devs and code being the most "brilliant" of them all. For day to day dev operations is something so mediocre even Gitlab looks like the golden standard compared to Github. And no, the pro…

After 10 years of using Phabricator at a previous company I am still shocked how bad GitHub is. This the industry standard?! Too bad Phabricator is maintenance-only now https://en.m.wikipedia.org/wiki/Phabricator

Looks like a new community developed fork of Phabricator is up! I've never used it but glad to see the project continues.

https://we.phorge.it/

Re: The GitHub website is slow on Safari

#129

Post by cratermoon »

yrds96 wrote: post #83

Isn't the opposite? No one in this thread even cogitating how bad Safari is in terms of performance and supporting web standards? There's in one even partially blaming both. Github isn't the best example of a fast website, but if you can run it in Chrome and Firefox, even on rudimentary browsers like Palemoon (I tested) on decent hardware (even mobile), there's something clearly wrong on Safari.

Safari is behind on web standards, but often those standards are things designed and implemented by the Chrome team and pushed into standards later. It's the Chromification of the web, where the standard is "whatever chrome does". It's much like the era of "Designed For IE" or "Works best in Netscape 2.3", but now there's a thrice-convicted monopolist in de facto control of the standard.

Re: The GitHub website is slow on Safari

#130

Post by moffkalast »

patrickmay wrote: post #21
muglug wrote: post #5

Improvements merged within the last two days by the WebKit team: https://github.com/orgs/community/discussions/170922#discuss... For my sins I occasionally create large PRs (> 1,000 files) in GitHub, and teammates (who mostly all use Chrome) will sometimes say "I'll approve once it loads for me..."

That seems essentially unreviewable. If you can share without violating an NDA, what kind of PR would involve that many files?

Convert space indents to tabs, as god intended.
Post reply on HN