Live data from Hacker News

Git security vulnerabilities announced

github.blog

121–130 of 139 posts

Re: Git security vulnerabilities announced

#121

Earlier quoted context omitted.

I too think package managers are amazing... reads new git security threat "brew upgrade" done!

Running brew upgrade uses git, so it has to run the insecure git to upgrade.

Wait until you hear about how your OpenSSL patches get delivered!

Re: Git security vulnerabilities announced

#122

Earlier quoted context omitted.

I too think package managers are amazing... reads new git security threat "brew upgrade" done!

Running brew upgrade uses git, so it has to run the insecure git to upgrade.

ugh technically correct, the best type of correct

Re: Git security vulnerabilities announced

#123
post #96

What is the recommended upgrade path for macOS' system install of git? I have upgraded my brew install, but am unsure of what to do with the vulnerable system install.

I'm guessing a system security update will patch the git executable. No way would apple make you update Xcode just for this. (Well, maybe...)

Re: Git security vulnerabilities announced

#124
post #41

Earlier quoted context omitted.

> Integer overflow isn't a security issue unless your program's memory safety depends on the correctness of the integer operation. That's simply not true and has wide-reaching horrible effects that can occur. The wrong number of tickets can be purchased from a website, charging for less than were purchased. The DNR order can be put in place instead of SAVE LIFE. There are countless security issues that can occur. Say…

Do you have data on the relative frequency and severity of non-memory safety integer overflow security issues?

Here are over 3k CVEs that contain "integer overflow". That shouldn't be considered a comprehensive search.

https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=integer+ove...

Re: Git security vulnerabilities announced

#125
post #48

Earlier quoted context omitted.

As best I can tell from the "The Windows-specific issue involves a $PATH lookup including the current working directory" part, it would be: echo "calc.exe" > aspell.cmd git commit -a -m"lolol windows" and wait for someone to clone that repo

What I don't quite get is why there's spellchecking on incoming commits at all.

I’m pretty sure it’s spell-checking the next commit the user will make, which on an new repository is of course empty, but there's no special case to start the spell-checker only when the user starts writing. (The “post-processing” the article refers to, I think, is just starting up the GUI on the repo, which includes setting up the textbox for the commit message. In fact I’m pretty sure the act of cloning is irrelevant, that’s just the most likely way for an unwitting user to get a malicious repository.)

Re: Git security vulnerabilities announced

#126

Earlier quoted context omitted.

Don't understand what you mean by "incoming commits". git-gui shows you a textbox for the commit message, and error squiggles for misspelled words (presumably; I CBA to install a spell checker). The bug is that it spawns the spellcheck binary using Tcl's API, which on Windows also looks up binaries in the current directory regardless of whether the current directory is in $PATH or not. Edit: Maybe you're referring to…

My reason for asking that is that this is the vuln description from the article: > After cloning a repository, Git GUI automatically applies some post-processing to the resulting checkout, including running a spell-checker, if one is available. > A Windows-specific vulnerability causes Git GUI to look for the spell-check in the worktree that was just checked out, which may result in running untrusted code. I get what…

It's phrased badly. I can see that it sounds like it's post-processing the new clone by running spellcheck on all the commits of the cloned branch, but it definitely doesn't do that. I checked the code just to be sure and there's nothing like that in the clone code. (Unless I'm missing something, but as you said I can't fathom why it would need to do that.)

What happens is that, when you use it clone a repo it immediately shows the window for authoring a new commit message, which as I said will invoke the spell-check. That's why you are vulnerable from the moment you use git-gui to clone.

Re: Git security vulnerabilities announced

#128
post #83

Earlier quoted context omitted.

Your could use interrupts, no? Basically free when not triggered and when triggered you probably don't care about performance anymore.

Most architectures do not provide an interrupt that is generated by an integer overflow. Since this would be a significant architectural change in the hardware, it can't be simply added in. Additionally, if you are running inside an operating system, handling an interrupt usually incurs a trip through the kernel, which would add extra overhead every time an overflow did happen. Since there's a lot of software which d…

Using a new instruction none of that would be an issue. And as someone pointed out, on x86 it wouldn't even be a new instruction, INTO already exists. But apparently it didn't make it in x64 because nobody used it :/

Re: Git security vulnerabilities announced

#129

Earlier quoted context omitted.

I too think package managers are amazing... reads new git security threat "brew upgrade" done!

Running brew upgrade uses git, so it has to run the insecure git to upgrade.

brew repositories are hosted at Github. According the linked article Github did a full scan on all repositories whether those attacks were already in use and implemented mitigations to make it impossible to push attacks to Github. I.e. it should be safe to run brew upgrade.

Re: Git security vulnerabilities announced

#130
post #41

Earlier quoted context omitted.

> Integer overflow isn't a security issue unless your program's memory safety depends on the correctness of the integer operation. That's simply not true and has wide-reaching horrible effects that can occur. The wrong number of tickets can be purchased from a website, charging for less than were purchased. The DNR order can be put in place instead of SAVE LIFE. There are countless security issues that can occur. Say…

Do you have data on the relative frequency and severity of non-memory safety integer overflow security issues?

You don't need to have to have historical stats to show that it can be a security issue.
Post reply on HN