I don't at all object to code reviews/evaluation, but the thing I wonder about is this: I rarely open an empty file and write some big block of code. 98% of the time I'm fixing bugs in legacy code or shimming in some new feature. It would be trivial to produce the diffs I generated in the past 30 or 60 days, but the volume of code isn't really a great metric for my productivity. There may be some three line change th…
I once reviewed code for a company that got purchased. I took less than a few hours to reach conclusion. There were 7 developers and in 2 months only one was writing code. The entire team but that one developer was fired. Twitter has grown a reputation for being slow and a rest and vest haven. Won't be surprised if they are looking for people not writing code. On a different note, If you're in a large org and all you…
Try fixing your own code 3 months after you wrote it. You end up turning it into a mess too. To think code is something that stays in long term memory somehow is a flawed assumption. We should think of it as language, you say something to someone and a few hours later have 0 memory of how you phrased, the words you used and why you phrased it the way you did. Taking code so seriously ends up sucking the enjoyment out of programming and turns it into a boring office job that you clock in and out so just that you get a paycheck. Let's not create random rules that benefit no one in the long term.
To become a better programmer is a choice people have to make for themselves not dictated by a manager who probably became one because of their mundane prior coding role.