Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

The GitHub website is slow on Safari

github.com

Post reply on HN
Print view View original

101–110 of 367 posts

Re: The GitHub website is slow on Safari

#101

Post by bethekidyouwant »

Roark66 wrote: post #20
PedroBatista wrote: post #11

The Github website is slow everywhere. It is truly a piece of shit software both in terms of performance but also UX/UI and everything in between. It's a product of many cooks and their brilliant ideas and KPIs, a social network for devs and code being the most "brilliant" of them all. For day to day dev operations is something so mediocre even Gitlab looks like the golden standard compared to Github. And no, the pro…

Yes, I came here to say this exact thing. Also github search sucks bad as well as the way it shows diffs. My current client has just moved from bitbucket to GH and all the devs are up in arms.

Where is it good?

Re: The GitHub website is slow on Safari

#102

Post by lazypenguin »

adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

I don't hate React developers. I hate developers who build consumer facing software and use top of the line hardware and networks to test it while being ignorant to the fact that most of their users will be using their products on 8+ year old consumer grade hardware over spotty 3G

Re: The GitHub website is slow on Safari

#103

Post by dylan604 »

rootnod3 wrote: post #47
celsoazevedo wrote: post #39

Earlier quoted context omitted.

How long until those improvements reach users? I assume it requires an OS update or does Safari use something similar to Firefox and Chrome for faster updates?

There is a developer version you can install. There is beta, but that overrides your existing Safari and rollback might be tricky sometimes. But there is also the Safari Technology Preview, which installs as a separate app, but is also a bit more unstable. Similar to Chrome Canary.

I had to download STP for a specific case I don't even remember. Ever since, I get frequent OS Update notifications with new STP versions. Updates without a fully system which means no rebooting necessary. About as easy any other software typically does it, only this is using the OS' upgrade so it does make it those extra steps instead of clicking the update->relaunch button

Re: The GitHub website is slow on Safari

#104

Post by dylan604 »

zackmorris wrote: post #57

GitHub moved to a JavaScript rendering mode almost as soon as Microsoft bought it. Previously, I had been able to browse it with JavaScript disabled on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13. So even if I enable JavaScript, I can no longer browse GitHub, because they didn't bother to make their build compatible with browser versions as old as mine. It's hard to know which member of…

> on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13

I know some people feel like Apple is aggressive in this respect, but that's an 8 year old version of a browser. That's like taking off all of the locks on your house, leaving the doors and windows open all while expecting your house to never have uninvited guests.

Re: The GitHub website is slow on Safari

#105

Post by Sesse__ »

muglug wrote: post #5

Improvements merged within the last two days by the WebKit team: https://github.com/orgs/community/discussions/170922#discuss... For my sins I occasionally create large PRs (> 1,000 files) in GitHub, and teammates (who mostly all use Chrome) will sometimes say "I'll approve once it loads for me..."

Interesting how _everyone_ here blames JS and React, yet the fixes you linked are about CSS performance.

Re: The GitHub website is slow on Safari

#106

Post by shadowgovt »

eviks wrote: post #84
ambicapter wrote: post #70

Earlier quoted context omitted.

It's not GitHub-specific advice, it's about reviewability of the PR vs. human working memory/maximum attention span.

How much working memory/attention span is required to look through 1000 identical lines "-CustomerEmailAddress +CustomerEmail"?

Ideally, you automate a check like that. Because the answer turns out to actually be "humans are profoundly bad at that kind of pattern recognition."

A computer will be able to tell that the 497th has a misspelled `CusomerEmail` or that change 829 is a regexp failure that trimmed the boolean "CustomerEmailAddressed" to "CustomerEmailed" with 100% reliability; humans, not so much.

Re: The GitHub website is slow on Safari

#107

Post by shadowgovt »

zackmorris wrote: post #57

GitHub moved to a JavaScript rendering mode almost as soon as Microsoft bought it. Previously, I had been able to browse it with JavaScript disabled on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13. So even if I enable JavaScript, I can no longer browse GitHub, because they didn't bother to make their build compatible with browser versions as old as mine. It's hard to know which member of…

Turing completeness never says anything about performance. Hypothetically, sure, you could emulate a newer computer on your current computer.

Re: The GitHub website is slow on Safari

#108

Post by Elfener »

DrBenCarson wrote: post #17
bob1029 wrote: post #15

Earlier quoted context omitted.

> And no, the problem is not "Rails" The problem is they abandoned rails for react. The old SSR GitHub experience was very good. You could review massive PRs on any machine before they made the move.

Well yeah, but just imagine how much money they’re saving by delivering a subpar experience!

I guess if you say "we've made the UX worse" instead of "we've reduced costs but made the UX worse" to shareholders, they think of cost savings regardless.

Re: The GitHub website is slow on Safari

#109

Post by shadowgovt »

adithyassekhar wrote: post #95

This thread has really opened my eyes to how much the world hates react developers, I am one. Unrealistic timelines, implementing what should be backend logic in frontend, there's a bunch of ways SPA's tend to be a trap. Was react a bad idea? Can anyone point to a single well made react app?

It's also misapplied here. If anything, it appears from the changes being made to WebKit that the issue is detailed interactions with DOM change logic and with CSS, not JavaScript. JavaScript may tickle the issue, but that's like blaming the mouse for allowing you to click on a button that has expensive operations attached to it.

I've definitely managed to make a page that uses almost no JavaScript and is dog-slow on Firefox (until Mozilla updated the rendering engine) just by building a table out of flexboxes. There's plenty of places for browsers to chug and die in the increasingly-complicated standard they adhere to.

Re: The GitHub website is slow on Safari

#110

Post by sidewndr46 »

Zanfa wrote: post #90
bob1029 wrote: post #15

Earlier quoted context omitted.

> And no, the problem is not "Rails" The problem is they abandoned rails for react. The old SSR GitHub experience was very good. You could review massive PRs on any machine before they made the move.

I’m pretty sure they used to do syntax highlighting on the server before and it was fast. Now they send down unhighlighted text that seems to choke the browser with anything but the smallest diffs.

Whoever had a KPI for improving server performance and decreasing cost got their promotion that quarter, that is for sure.
Post reply on HN