Live data from Hacker News

Tencent WeChat is now a GitHub secret scanning partner

github.blog

101–110 of 144 posts

Re: Tencent WeChat is now a GitHub secret scanning partner

#101
post #13

Brilliant title for the article. Even though I'm a paid github customer, I had no idea they had a program called "secret scanning" and that it's actually beneficial. So I obviously assumed they're letting China scan my private repos. They really need to work on wording.

Scanning repos for secrets has been a thing for a while now. But seeing Tencent might put people on edge.

Secret scanning is a thing.

But this is an excellent next step where they build an integration with these partners where, as soon as a secret is scanned, they can notify tencent/AWS/other providers automatically to instantly invalidate those keys before they’re abused.

That’s what’s novel here.

Re: Tencent WeChat is now a GitHub secret scanning partner

#102

Earlier quoted context omitted.

How is Githun a poor implementation of Git? Because it’s centralized?

I believe it's roughly a quote from Linus Torvalds, the creator of git who has many issues with githubs decisions. See https://www.wired.com/2012/05/torvalds-github/ for a start, his opinion hasn't improved over the decade.

His oppositions seems to be nitpicking and he says it is fine for hosting?

Re: Tencent WeChat is now a GitHub secret scanning partner

#103
post #93
post #87

Earlier quoted context omitted.

Without taking away from your first paragraph at all, if any dissidents are publishing their access codes to GitHub repos, they are 1) doing it completely wrong and 2) are already screwed. The threat here, in the worst case, is associating a GitHub ID with a WeChat ID.

Quoted from the blog post: > We have partnered with Tencent WeChat to scan for their tokens and help secure our mutual users on all public repositories and private repositories with GitHub Advanced Security. This is GitHub scanning private repos and telling WeChat about them. WeChat can already scan public repos. They are not already screwed if they’re publishing something to a private repo, it might be the wrong way…

Wrong, this only applies to public repos.

https://docs.github.com/en/code-security/secret-scanning/abo...

Re: Tencent WeChat is now a GitHub secret scanning partner

#104
post #19
post #13

Brilliant title for the article. Even though I'm a paid github customer, I had no idea they had a program called "secret scanning" and that it's actually beneficial. So I obviously assumed they're letting China scan my private repos. They really need to work on wording.

>, I had no idea they had a program called "secret scanning" and that it's actually beneficial. Fyi... this feature was also previously mentioned in the news for public repos: https://techcrunch.com/2022/12/15/github-brings-free-secret-... >So I obviously assumed they're letting China scan my private repos. To clarify, it's Microsoft/Github doing the scanning of private repos on behalf of the partners. They're just f…

Devils advocate: I read recently that GitHub is being used to circumvent censorship in China. Does this system of allowing them to provide regexes allow China to automatically obtain lists of users who are mentioning certain words or phrases? Or is that nonsense?

Re: Tencent WeChat is now a GitHub secret scanning partner

#105
post #19

Earlier quoted context omitted.

>, I had no idea they had a program called "secret scanning" and that it's actually beneficial. Fyi... this feature was also previously mentioned in the news for public repos: https://techcrunch.com/2022/12/15/github-brings-free-secret-... >So I obviously assumed they're letting China scan my private repos. To clarify, it's Microsoft/Github doing the scanning of private repos on behalf of the partners. They're just f…

Like .* ?

>Like .* ?

Assuming your question is not a joke...

The partner has to email the regex to secret-scanning@github.com for their approval. See the steps at: https://docs.github.com/en/developers/overview/secret-scanni...

Once it's in the scanning system, the partner receives JSON messages alerts such as:

  [
    {
      "token":"NMIfyYncKcRALEXAMPLE",
      "type":"mycompany_api_token",
      "url":"https://github.com/octocat/Hello-World/blob/12345600b9cbe38a219f39a9941c9319b600c002/foo/bar.txt",
      "source":"content"
    } 
  ]
So instead of ""token":"NMIfyYncKcRALEXAMPLE"," -- the private repo owners would worry about '.*' regex leaking full source code instead of API credentials such as ""token":"#include \nmain(){\nprintf("hello world");\n}","

The above scenario requires believing the following:

- Microsoft/Github is technically incompetent and an employee and/or their internal regex sanity checking tool will blindly accept open-ended regex like '.*'

- MS/Github will then allow that unbounded regex to leak petabytes of private source code out to China partners via the JSON "token:" response. (Github says they have 18+ petabytes of data and most of that is private repos: https://twitter.com/github/status/1569852682239623173)

If one believes their entire private repo source code is at risk of being copied to TenCent being leaked by the '.*' threat because the above scenario seems realistic, I assume the answer is to delete the repo.

Re: Tencent WeChat is now a GitHub secret scanning partner

#106
post #100

To everyone portraying this as harmless and as Wechat just looking for security breaches: Tencent itself is the security breach. Not only can Chinese ppl not sign up without providing a phone number, just to get a SIM card they now take your government ID, a picture of your face and a fingerprint! Xi is making absolutely sure that every single internet user is IDed and has their conversations tracked on apps like Wec…

This is a service running on public repos, anyone can scrape this which is the problem. GitHub does the scanning and all that is forwarded is the "secret" matching their regex. Tencent then identifies the account owner and informs them about the public secret. That's all. GitHub is available in China, why shouldn't they protect their Chinese users? And the SIM card requirements have nothing to do with Tencent, have y…

Why do they notify tencent instead of the repo owner?

Re: Tencent WeChat is now a GitHub secret scanning partner

#107
post #103
post #93

Earlier quoted context omitted.

Quoted from the blog post: > We have partnered with Tencent WeChat to scan for their tokens and help secure our mutual users on all public repositories and private repositories with GitHub Advanced Security. This is GitHub scanning private repos and telling WeChat about them. WeChat can already scan public repos. They are not already screwed if they’re publishing something to a private repo, it might be the wrong way…

Wrong, this only applies to public repos. https://docs.github.com/en/code-security/secret-scanning/abo...

Obviously you’re wrong or the article is wrong… I’m gonna lean on you being wrong as the article is coming from GitHub and you’re not GitHub.

Re: Tencent WeChat is now a GitHub secret scanning partner

#108
post #100

Earlier quoted context omitted.

This is a service running on public repos, anyone can scrape this which is the problem. GitHub does the scanning and all that is forwarded is the "secret" matching their regex. Tencent then identifies the account owner and informs them about the public secret. That's all. GitHub is available in China, why shouldn't they protect their Chinese users? And the SIM card requirements have nothing to do with Tencent, have y…

Why do they notify tencent instead of the repo owner?

This is my question too… why not just let the owner of the repo know, why notify Tencent at all?

Re: Tencent WeChat is now a GitHub secret scanning partner

#109
post #105

Earlier quoted context omitted.

Like .* ?

>Like .* ? Assuming your question is not a joke... The partner has to email the regex to secret-scanning@github.com for their approval. See the steps at: https://docs.github.com/en/developers/overview/secret-scanni... Once it's in the scanning system, the partner receives JSON messages alerts such as: [ { "token":"NMIfyYncKcRALEXAMPLE", "type":"mycompany_api_token", "url":"https://github.com/octocat/Hello-World/blob/…

https://docs.github.com/en/code-security/secret-scanning/abo... is pretty damn clear that secret scanning for private repos only alert owners; only the public repo scans alert partners (for instant revocation).

Re: Tencent WeChat is now a GitHub secret scanning partner

#110
post #107
post #103

Earlier quoted context omitted.

Wrong, this only applies to public repos. https://docs.github.com/en/code-security/secret-scanning/abo...

Obviously you’re wrong or the article is wrong… I’m gonna lean on you being wrong as the article is coming from GitHub and you’re not GitHub.

For private repos it is opt-in requiring the Advanced Security license: https://docs.github.com/en/get-started/learning-about-github...
Post reply on HN