Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Testing at Airbnb

nerds.airbnb.com

Post reply on HN
Print view View original

11–20 of 58 posts

Re: Testing at Airbnb

#11

Post by hoverkraft »

hiisi wrote: post #10

Great article! I wonder if the guys are doing code reviews for each PR along with making sure build is green. In our team, we've been doing code reviews for about three years now and can't imagine our workflow without them.

Yes, we're absolutely doing code reviews for each PR. Should have mentioned it in the post. Our general policy is to have engineers merge their own PRs, but only after at least 1-2 people have reviewed them (and obviously more for sensitive changes). The dialog that takes place in PRs helps enforce (and sometimes define) our style standards, teach engineers the idioms of a languages they may be new to, and ensure that we're always moving our codebase in the right direction. (They're also a great place to teach people how to write cleaner and less brittle tests!)

Re: Testing at Airbnb

#12

Post by elsbree »

Does anybody have recommendations for where/how to start learning best practices for TDD?

As (nominally) top nerd at a tiny startup (2 engineers), I feel like I should set a precedent sooner rather than later for testing. This is currently not possible since I don't know anything about it, so any resources would be appreciated :)

Edit: Primarily looking for resources involving Node.js and client-side testing of a jQuery-based website.

Re: Testing at Airbnb

#15

Post by hoverkraft »

theSshow wrote: post #13

Is pushing directly to master still not disabled to this day?

Still not disabled! Although at this point we're so habituated to PRs as a team that in practice it never happens. We did finally disable force pushes to master, though. Don't miss those one bit.

Re: Testing at Airbnb

#16

Post by hoka »

elsbree wrote: post #12

Does anybody have recommendations for where/how to start learning best practices for TDD? As (nominally) top nerd at a tiny startup (2 engineers), I feel like I should set a precedent sooner rather than later for testing. This is currently not possible since I don't know anything about it, so any resources would be appreciated :) Edit: Primarily looking for resources involving Node.js and client-side testing of a jQu…

If you're a python developer, http://www.tdd-django-tutorial.com/ is an excellent resource.

Re: Testing at Airbnb

#17

Post by elsbree »

hoka wrote: post #16
elsbree wrote: post #12

Does anybody have recommendations for where/how to start learning best practices for TDD? As (nominally) top nerd at a tiny startup (2 engineers), I feel like I should set a precedent sooner rather than later for testing. This is currently not possible since I don't know anything about it, so any resources would be appreciated :) Edit: Primarily looking for resources involving Node.js and client-side testing of a jQu…

If you're a python developer, http://www.tdd-django-tutorial.com/ is an excellent resource.

Thanks! Our backend is built on Node, but I'll see if I can glean some general concepts from this.

Re: Testing at Airbnb

#18

Post by logicallee »

nchuhoai wrote: post #7

Pretty interesting that according to him, Airbnb didn't really have a functioning testing infrastructure only a year ago. So you really can hit a billion dollars in valuation without testing :)

or worse, you can only hit a billion dollars in valuation without testing.

(might be a true statement.)

Re: Testing at Airbnb

#19

Post by jcagalawan »

elsbree wrote: post #12

Does anybody have recommendations for where/how to start learning best practices for TDD? As (nominally) top nerd at a tiny startup (2 engineers), I feel like I should set a precedent sooner rather than later for testing. This is currently not possible since I don't know anything about it, so any resources would be appreciated :) Edit: Primarily looking for resources involving Node.js and client-side testing of a jQu…

I found http://www.letscodejavascript.com/ very useful.

Re: Testing at Airbnb

#20

Post by 2mur »

elsbree wrote: post #12

Does anybody have recommendations for where/how to start learning best practices for TDD? As (nominally) top nerd at a tiny startup (2 engineers), I feel like I should set a precedent sooner rather than later for testing. This is currently not possible since I don't know anything about it, so any resources would be appreciated :) Edit: Primarily looking for resources involving Node.js and client-side testing of a jQu…

For node + browser, I'm partial to substack's tape module[1][2] to output tap. Works great with browserify too.

[1] https://github.com/substack/tape

[2] http://www.catonmat.net/blog/writing-javascript-tests-with-t...

Post reply on HN