Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Losing 1½ Million Lines of Go

tbray.org

Post reply on HN
Print view View original

11–14 of 14 posts

Re: Losing 1½ Million Lines of Go

#11

Post by 8n4vidtmkvmk »

LukeShu wrote: post #7
matt3210 wrote: post #4

Earlier quoted context omitted.

Based on the commit message and using "CL" which is google lingo for Change List on their internal system, I bet this was already available on the internal version and just ported to github version after someone pointed it out.

"CL"/"Change List" is the lingo for the Gerrit code review tool, which is how all contributions to Go happen. Creating a GitHub PR simply triggers a bot to create a Gerrit CL, which is where all discussion about the "PR" happens and where the "accept" button gets clicked.

Is Gerrit the same as Critique?

Re: Losing 1½ Million Lines of Go

#12

Post by tonfa »

8n4vidtmkvmk wrote: post #11
LukeShu wrote: post #7

Earlier quoted context omitted.

"CL"/"Change List" is the lingo for the Gerrit code review tool, which is how all contributions to Go happen. Creating a GitHub PR simply triggers a bot to create a Gerrit CL, which is where all discussion about the "PR" happens and where the "accept" button gets clicked.

Is Gerrit the same as Critique?

It's a descendant of critique's predecessor (Mondrian)

https://www.gerritcodereview.com/about.html

Re: Losing 1½ Million Lines of Go

#13

Post by norir »

Someone wrote: post #10

> Sure, these automata are “wide”, with lots of branches, but they’re also shallow, since they run on UTF-8 encoded characters whose maximum length is four and average length is much less I would consider splitting this task into two: - extracting the next Unicode code unit - determining whether it’s in the code class For the second, instead of using an automaton, one could use a perfect hash ( https://en.wikipedia.o…

A precomputed lookup table would be about 1MB covering all of then code points. The lookup code would first compute the code point (and also could do validation) and directly look up the class in the table. The lookup table would not need to be directly embedded in go code and could just be stored in a binary file. But I'd imagine it also could be put in an array literal in its own file that would never be opened by an ide if the program needs to be distributed as a single binary.
Post reply on HN