Question, isn't this a bug? static enum hrtimer_restart perf_swevent_hrtimer(struct hrtimer *hrtimer) { - if (event->state != PERF_EVENT_STATE_ACTIVE) + if (event->state != PERF_EVENT_STATE_ACTIVE || + event->hw.state & PERF_HES_STOPPED) return HRTIMER_NORESTART; The bug being that the precedence of || is higher than the precedence of != ? Consider writing it if ((event->state != PERF_EVENT_STATE_ACTIVE) || (event->h…
Which language(s?) have || before !=/==?
A kernel bug froze my machine: Debugging an async-profiler deadlock
11–19 of 19 posts
Re: A kernel bug froze my machine: Debugging an async-profiler deadlock
#12This kind of "debugging journey" post is gold.
Re: A kernel bug froze my machine: Debugging an async-profiler deadlock
#13Great debugging effort. Now, with the complexity (MLoCs!) of the Linux kernel, this is definitely not the only bug to be found in there. This is why Linux is just an interim kernel for these use cases in which we still cannot use seL4[0]. 0. https://sel4.systems/
35 years of "interim" status. Is there a roadmap?
Re: A kernel bug froze my machine: Debugging an async-profiler deadlock
#14Great article! Just yesterday I watched a Devoxx talk by Andrei Pangin [1], the creator of async-profiler where I learned about the new heatmap support. To many folks it might not sound that exciting, until you realise that these heatmaps make it much easier to see patterns over time. If you’re interested there’s a solid blog post [2] from Netflix that walks through the format and why it can be incredibly useful. [1]…
Thanks for the kind words! Heatmaps are amazing for pattern spotting. I also use them when hunting irregular hiccups or outliers. More people should know about this feature.
Great that you had the time to be curious and dig into what was going on. QEMU is quite an amazing tool.
I'm kind of surprised there isn't a fairly robust kernel test around this issue, since it locks the machine down and I think the fix was to prevent a stuck CPU last time as well?
It's also vaguely surprising that this hasn't been encountered more often, particularly by the https://news.ycombinator.com/user?id=everlier talking in links to this HN post about "20-30 containers" running simultaneously and occasionally locking up the machine.
If you're still thinking about the bug a little, you could look over how other kernel tests work and implement a failing test around it....?
I imagine the tests have some way of detecting a locked up kernel... I don't know exactly how they'd do it, but they probably have a technique. Most likely since the kernel is literally in a loop it won't respond to anything.. so starting any process, something as simple as creating any process, even one as simple as printing "Hello World!!" would fail and indicate the machine is locked.
Perhaps this is one of those cases where something like UserModeLinux would allow a test to be easily put together, rather than spawning complete VMs via some kind of VM software. Again, would be interesting to know what Linux does with this kind of test.
Re: A kernel bug froze my machine: Debugging an async-profiler deadlock
#15Great debugging effort. Now, with the complexity (MLoCs!) of the Linux kernel, this is definitely not the only bug to be found in there. This is why Linux is just an interim kernel for these use cases in which we still cannot use seL4[0]. 0. https://sel4.systems/
> Linux is just an interim kernel 35 years of "interim" status. Is there a roadmap?
Re: A kernel bug froze my machine: Debugging an async-profiler deadlock
#16I do not have much experience with it, but I think you can see the kernel call stack with it and I know you can also see the return value (in eax). That would be less effort than qemu + gdb + disabling kernel aslr, etc.
Re: A kernel bug froze my machine: Debugging an async-profiler deadlock
#17Nice article, thank you. Did you also consider using bpftrace while debugging? I do not have much experience with it, but I think you can see the kernel call stack with it and I know you can also see the return value (in eax). That would be less effort than qemu + gdb + disabling kernel aslr, etc.
Re: A kernel bug froze my machine: Debugging an async-profiler deadlock
#18Re: A kernel bug froze my machine: Debugging an async-profiler deadlock
#19Great article! Just yesterday I watched a Devoxx talk by Andrei Pangin [1], the creator of async-profiler where I learned about the new heatmap support. To many folks it might not sound that exciting, until you realise that these heatmaps make it much easier to see patterns over time. If you’re interested there’s a solid blog post [2] from Netflix that walks through the format and why it can be incredibly useful. [1]…