Live data from Hacker News

Stop Validating Email Addresses With Your Complex Regexes

davidcelis.com

11–20 of 25 posts

Re: Stop Validating Email Addresses With Your Complex Regexes

#11
post #2

There's got to be a bug because this was on the front page 6 days ago: http://news.ycombinator.com/item?id=4486108 Well the link in the previous post had a trailing slash.

Funny part is that this submission made it to the front page again... I guess this is a really popular topic?

It's a really popular headline at least. The actual article i'm not impressed with but email regexes are a pain.

Re: Stop Validating Email Addresses With Your Complex Regexes

#13
post #2

There's got to be a bug because this was on the front page 6 days ago: http://news.ycombinator.com/item?id=4486108 Well the link in the previous post had a trailing slash.

So to sum up the comments on the previous submission:

1) Someone did make a fully compliant Regex https://github.com/larb/email_address_validator

2) Lots of people (including the author http://news.ycombinator.com/item?id=4486264) think that you should at least validate that the '@' is somewhere to avoid username / email mixups

3) If your regex fails for foo+tag@something.com lots of people get pissed. I learned you can use that for inbox sorting since foo+tag@something.com goes to foo@something.com.

4) There are other schools of thought that promote validation and telling the user something is wrong like mailcheck.js (https://github.com/Kicksend/mailcheck), but these should not stop users from submitting forms.

Did I miss anything?

Re: Stop Validating Email Addresses With Your Complex Regexes

#14
post #9

If you've been developing login systems for any length of time, this should be fairly obvious. Be careful about taking that "it’ll get bounced" attitude too far though. The last time I did so I forgot to trim the email addresses and didn't lowercase them. Failing to trim will probably result in the email going through, but then might cause problems later on when you try to match their login ID to what they enter the…

Regarding upper case: I've taken to typing the first part of my work email address as "JensenS". My wife and I work at the same place, and when I wrote it as "jensens" there were honestly people who assumed that address was a plural and went to both of us.

Re: Stop Validating Email Addresses With Your Complex Regexes

#15
post #14
post #9

If you've been developing login systems for any length of time, this should be fairly obvious. Be careful about taking that "it’ll get bounced" attitude too far though. The last time I did so I forgot to trim the email addresses and didn't lowercase them. Failing to trim will probably result in the email going through, but then might cause problems later on when you try to match their login ID to what they enter the…

Regarding upper case: I've taken to typing the first part of my work email address as "JensenS". My wife and I work at the same place, and when I wrote it as "jensens" there were honestly people who assumed that address was a plural and went to both of us.

>when I wrote it as "jensens" there were honestly people who assumed that address was a plural and went to both of us.

facepalm

Re: Stop Validating Email Addresses With Your Complex Regexes

#17
I couldn't help thinking while reading this that my main concern with registration systems isn't the complicated Regex as much, but rather the really annoying registry bots that sign up phantom accounts. I'm not a huge Captcha fan, but without something (Recaptcha, ghosted fields, etc) you'll get SPAMMED with tons of fake accounts - and they have valid emails, AND the bots click on the links in the confirmation email automatically. It's really sad.

Re: Stop Validating Email Addresses With Your Complex Regexes

#18
post #17

I couldn't help thinking while reading this that my main concern with registration systems isn't the complicated Regex as much, but rather the really annoying registry bots that sign up phantom accounts. I'm not a huge Captcha fan, but without something (Recaptcha, ghosted fields, etc) you'll get SPAMMED with tons of fake accounts - and they have valid emails, AND the bots click on the links in the confirmation email…

[deleted]

Re: Stop Validating Email Addresses With Your Complex Regexes

#19

What about just checking if a MX record exists?

That verifies the domain, but not the actual mailbox.

One possibility would be to lookup the MX, then connect to the remote MTA and ask it directly if the mailbox is valid. But that seems a bit like over-engineering.

Re: Stop Validating Email Addresses With Your Complex Regexes

#20
post #17

I couldn't help thinking while reading this that my main concern with registration systems isn't the complicated Regex as much, but rather the really annoying registry bots that sign up phantom accounts. I'm not a huge Captcha fan, but without something (Recaptcha, ghosted fields, etc) you'll get SPAMMED with tons of fake accounts - and they have valid emails, AND the bots click on the links in the confirmation email…

Well now some bots can read captchas too: http://userscripts.org/scripts/show/56989
Post reply on HN