Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Why I am tired of writing pull requests

gist.io

Post reply on HN
Print view View original

11–20 of 71 posts

Re: Why I am tired of writing pull requests

#11

Post by josegonzalez »

mirsadm wrote: post #9
josegonzalez wrote: post #6

That's really too bad. For the record, I've written a couple hundred pull requests - no really! - and those that haven't been accepted have been because - The project is no longer maintained (I fork or rewrite better in this case) - I was actually doing it wrong - My pull didn't have tests and that was the convention (gotta respect conventions) - The author wished to keep my feature out for some random reason, but ei…

I always figured the unwritten rule for every developer is to always follow the existing code's style regardless of their own opinion of it.

That's not always the case, and sometimes if you don't know the language very well - in my case, Ruby - then certain patterns aren't available to you and it looks hokey without you realizing it.

Re: Why I am tired of writing pull requests

#12

Post by simanyay »

The first thing you should always do is create a ticket. There you can discuss if its worth spending time on a patch and what the best implementation could be. Pull requests that come up out of nowhere usually end up in the end of maintainers' queue.

Or you can continue calling people who maintain free and open source projects in their spare time douchebags and neckbeards.

Re: Why I am tired of writing pull requests

#13

Post by mnutt »

I've found that if it's a pull request of any significance, if you want it merged it's good to hop on IRC and talk to one of the maintainers and get their take on it. That can head off a lot of issues and save a lot of your time. Then if you still need the change, you know up front that you'll be maintaining your own fork.

Re: Why I am tired of writing pull requests

#14

Post by apeace »

I can't say I've had a similar experience on Github, or heard anything of that sort from the many developers I know who write pull requests (or even just submit issues) on Github.

I think there should be an expectation that getting a pull accepted on a huge repo like Node or Rails should be a bit hard. When code is being used by thousands of people and companies, it's important that a lot of thought and care is put into even the smallest changes.

And finally, there is an easy way to end the negativity: respond to it by doing what they say. If they want you to do it in a different way, make a separate pull request and leave it up to the maintainers to choose the best one. Best never to argue on Github. If there's a disagreement, answer it with code.

I understand where the OP is coming from. This certainly does happen from time to time, and it's awful when it does. But I think this post is overblowing it. I certainly hope he does try sending pull requests again!

Re: Why I am tired of writing pull requests

#16

Post by austinbv »

adamrt wrote: post #10
austinbv wrote: post #5

I have had similar things happen to me. https://github.com/joyent/node/pull/3710 I sit and argue my pull like crazy but it is just getting derailed :/ oh well.

Unless I'm confused, aren't you also the author of that gist? https://gist.github.com/3444052 your names on that one.

nope just edited a typo

Re: Why I am tired of writing pull requests

#17

Post by kisielk »

adamrt wrote: post #10
austinbv wrote: post #5

I have had similar things happen to me. https://github.com/joyent/node/pull/3710 I sit and argue my pull like crazy but it is just getting derailed :/ oh well.

Unless I'm confused, aren't you also the author of that gist? https://gist.github.com/3444052 your names on that one.

The original gist is on the bottom of the revision stack on the right, it was by an anonymous user.

Re: Why I am tired of writing pull requests

#20

Post by RegEx »

josegonzalez wrote: post #11
mirsadm wrote: post #9

Earlier quoted context omitted.

I always figured the unwritten rule for every developer is to always follow the existing code's style regardless of their own opinion of it.

That's not always the case, and sometimes if you don't know the language very well - in my case, Ruby - then certain patterns aren't available to you and it looks hokey without you realizing it.

Completely forgivable. This pull request[0], on the other hand, is probably more along the lines of what mirsadm was thinking of.

[0]: https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d...

Post reply on HN