Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Ask HN: Where can I ask for code reviews online without being roasted for fun?

news.ycombinator.com

Post reply on HN
Print view View original

11–17 of 17 posts

Re: Ask HN: Where can I ask for code reviews online without being roasted for fun?

#11

Post by whitfieldsdad »

tomcam wrote: post #9

Painful suggestion: I reframe the savagery as a free consultation by folks with poor people skills. Often one or two of the reviews gives you actionable results. I view this exercise as something you akin to learning how to be a sales person: a very unpleasant experience at first but eventually you develop a new muscle/superpower. Being coachable can take you pretty far.

I was moreso thinking of review comments like "this is the worst code I've ever seen", "give up now", "ignoring the hundreds of errors, this looks fine", Dreamworks villain laughter, etc.

Re: Ask HN: Where can I ask for code reviews online without being roasted for fun?

#12

Post by whitfieldsdad »

TIL: all code posted for review on https://codereview.stackexchange.com/ has to be compilable.

I noted that a function wasn't available in the snippet in my post, but 2 users still voted to remove the question without any feedback, person-to-person communication, etc., because it broke the rules.

While I'm a rule-breaker, and the problem, maybe GPT4 is where to go for code reviews.

Re: Ask HN: Where can I ask for code reviews online without being roasted for fun?

#13

Post by turtleyacht »

whitfieldsdad wrote: post #3
turtleyacht wrote: post #2

It's fun to write code you don't need reviewed. Build wondrous things, accept contributions (or not), and enjoy each project as its own gem. If you want code reviewed, contribute to existing projects. Part of getting better is realizing the previous work needs to be rewritten. Your past self wouldn't have known that at the beginning. But you got better.

I get what you mean, and agree with the idea of Just Building Things, but, I also want to make sure that I'm building things "the right way" if that makes sense. For example, I'm not new to programming, but am new to Go and have been struggling to figure out how to model messages as structs using composition rather than inheritance. As one of, if not the most senior developer in the team that I work on, I have nobody…

That makes sense. I'm trying to wrap my head around Dubray's State-Action-Model and have reduced it to rewriting examples from different perspectives (first starting with the model, for example).

I found this answer on StackOverflow about Go structs for composition. It's interesting because at least there's an example of how not to do it (in Go) and a detailed answer:

https://stackoverflow.com/a/70100167

The Ben Franklin approach: "I've seen one more way not to write it."

Hope you find or figure what you're looking for.

Re: Ask HN: Where can I ask for code reviews online without being roasted for fun?

#14

Post by tomcam »

whitfieldsdad wrote: post #11
tomcam wrote: post #9

Painful suggestion: I reframe the savagery as a free consultation by folks with poor people skills. Often one or two of the reviews gives you actionable results. I view this exercise as something you akin to learning how to be a sales person: a very unpleasant experience at first but eventually you develop a new muscle/superpower. Being coachable can take you pretty far.

I was moreso thinking of review comments like "this is the worst code I've ever seen", "give up now", "ignoring the hundreds of errors, this looks fine", Dreamworks villain laughter, etc.

Ugh. I feel you, which is why I unfortunately had to hedge with l "Often one or two of the reviews...". I think the best way to handle that is to understand you'll have to separate wheat from chaff, period, that's just the price. The good news is, once you learn to ignore comments like that you don't really need to worry about it ever again.

Sucks to go through that learning period.

Re: Ask HN: Where can I ask for code reviews online without being roasted for fun?

#15

Post by coldtrait »

Leftium wrote: post #10

I believe this community would be different: https://www.recurse.com/ Based on their social rules: https://www.recurse.com/social-rules However, it might be difficult to get in...

I'd rather work on interviewing to get a job than whatever that is.

Re: Ask HN: Where can I ask for code reviews online without being roasted for fun?

#16

Post by coldtrait »

I had a good experience while learning Ruby by asking on the Ruby discord channel. Everyone was supportive and there's a core group of highly knowledgeable users. A lot of people ask for help there, and it's a very positive environment.

Additionally on most sub-reddits I've seen people get good constructive feedback on their code.

If you can find such discord channels where the environment is non-toxic (I doubt any coding oriented ones are) and the users are active, that could be the ideal option.

Re: Ask HN: Where can I ask for code reviews online without being roasted for fun?

#17

Post by ttymck »

calebdre wrote: post #8

I’m actually building one right now so I can give code reviews for my mentees more easily! I’ll post back when I’ve put it up on the internet.

What does it do differently that makes it more valuable than github, et al?
Post reply on HN