Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Leaving Facebook/Meta was the best thing we could do for the community

trino.io

Post reply on HN
Print view View original

11–20 of 64 posts

Re: Leaving Facebook/Meta was the best thing we could do for the community

#11

Post by bitsondatadev »

neilv wrote: post #8
ruler88 wrote: post #3

why did Presto got renamed to Trino? so confusing...

According to https://trino.io/blog/2020/12/27/announcing-trino.html , because of trademark registration and enforcement by Facebook. (IMHO, PrestoSQL also looked maybe a little too much like PostgreSQL in this space.) I'm imagining an unusually efficient brandstorming session. "OK, folks, idea hats on, there are no bad ideas... we've got Presto..." "Uh... new Presto... New-o..." "Neutrino..." "Trino?" "Trino!" "Searc…

Hah! It may have very well looked like that given the time constraints they were working with.

Re: Leaving Facebook/Meta was the best thing we could do for the community

#12

Post by MonkeyMalarky »

bitsondatadev wrote: post #6

I'm curious to know if this is anyone's first time hearing about Trino?

Not trino, but yes for Presto. But it was already confusing because there are/were two Presto projects with one being a fork of the other?

Re: Leaving Facebook/Meta was the best thing we could do for the community

#13

Post by bitsondatadev »

MonkeyMalarky wrote: post #12
bitsondatadev wrote: post #6

I'm curious to know if this is anyone's first time hearing about Trino?

Not trino, but yes for Presto. But it was already confusing because there are/were two Presto projects with one being a fork of the other?

Yeah, I think that was one of the reasons why Facebook enforcing the trademark ended up being a blessing in disguise. It at least made the forks clearer. Now Trino is gaining more momentum but it takes a while for the brand recognition to set in I suppose.

Re: Leaving Facebook/Meta was the best thing we could do for the community

#14

Post by micromacrofoot »

cmrdporcupine wrote: post #7

"Feedback from these engineers ultimately culminated in the managers making the decision to give automatic contributor rights to any Facebook engineer working on Presto, so that these engineers could move faster." I'm confused -- does Facebook not have similar code review infrastructure as Google, etc. That is: nothing -- I mean nothing -- gets "contributed" at Google without it going through code review. Were FB eng…

There's code review, and there's "code review" where there's a deadline and someone says "can you click approve on this real quick," which is essentially a direct contribution with a compliance dance. I've seen it at large companies like these on several occasions.

Re: Leaving Facebook/Meta was the best thing we could do for the community

#15

Post by radicality »

bitsondatadev wrote: post #10
cmrdporcupine wrote: post #7

"Feedback from these engineers ultimately culminated in the managers making the decision to give automatic contributor rights to any Facebook engineer working on Presto, so that these engineers could move faster." I'm confused -- does Facebook not have similar code review infrastructure as Google, etc. That is: nothing -- I mean nothing -- gets "contributed" at Google without it going through code review. Were FB eng…

Facebook has their own internal reviews for their own internal projects and forks of open source projects. I think the issue came down to Facebook adding anyone working on the project to have the ability to merge code to the open source project. Typically if a company wants to contribute to open source, you have to create a PR and have it be reviewed and merged by the maintainers of the open source project on top of…

I spent many years at FB, but no longer there, but that doesn’t even sound like a ‘special case’? Every engineer at Fb has access to pretty much all the code, and after an internal code review for your code change, you can get it committed to the internal repos. For open source things, something syncs the external and internal changes ocassionaly I think. I imagine the problem here was that now external people can’t comment on internal PRs etc.

I even remember some of my internal commits making it into FBs open source code on GitHub, even though at the time I had no idea that this specific area of FBs codebase is open source.

Re: Leaving Facebook/Meta was the best thing we could do for the community

#16

Post by dsundstrom »

cmrdporcupine wrote: post #7

"Feedback from these engineers ultimately culminated in the managers making the decision to give automatic contributor rights to any Facebook engineer working on Presto, so that these engineers could move faster." I'm confused -- does Facebook not have similar code review infrastructure as Google, etc. That is: nothing -- I mean nothing -- gets "contributed" at Google without it going through code review. Were FB eng…

We ran Presto directly on Github (I think it still does), so everything went directly to the project without a private internal review first. We designed it this way, so that everyone in the community could participate in the full process.

Re: Leaving Facebook/Meta was the best thing we could do for the community

#17

Post by dsundstrom »

neilv wrote: post #8
ruler88 wrote: post #3

why did Presto got renamed to Trino? so confusing...

According to https://trino.io/blog/2020/12/27/announcing-trino.html , because of trademark registration and enforcement by Facebook. (IMHO, PrestoSQL also looked maybe a little too much like PostgreSQL in this space.) I'm imagining an unusually efficient brandstorming session. "OK, folks, idea hats on, there are no bad ideas... we've got Presto..." "Uh... new Presto... New-o..." "Neutrino..." "Trino?" "Trino!" "Searc…

If only it were that easy. It took ages to find the new name. There is a Google doc somewhere with pages of bad names.

Re: Leaving Facebook/Meta was the best thing we could do for the community

#18

Post by bawolff »

MonkeyMalarky wrote: post #12
bitsondatadev wrote: post #6

I'm curious to know if this is anyone's first time hearing about Trino?

Not trino, but yes for Presto. But it was already confusing because there are/were two Presto projects with one being a fork of the other?

Not to mention the name of the opera rendering engine.

Re: Leaving Facebook/Meta was the best thing we could do for the community

#19

Post by kmonsen »

cmrdporcupine wrote: post #7

"Feedback from these engineers ultimately culminated in the managers making the decision to give automatic contributor rights to any Facebook engineer working on Presto, so that these engineers could move faster." I'm confused -- does Facebook not have similar code review infrastructure as Google, etc. That is: nothing -- I mean nothing -- gets "contributed" at Google without it going through code review. Were FB eng…

Facebook/Meta does not have owners, so any two people in the company can land a change.
Post reply on HN