Funny but Azure Repos actually has had this feature for a while. When I first joined Microsoft I was shocked that all our teams used Azure Repos instead of GitHub considering we own GitHub but as I've used Repos more and more I've actually come to like it more than GitHub itself. A lot of the UI is cleaner and more intuitive than GitHub to me now, maybe just from using it a lot.
Pull Request File Tree Feedback
11–20 of 77 posts
Re: Pull Request File Tree Feedback
#12Back in the day I created something similar for CLI, which lets you diff any change in tree format.
Re: Pull Request File Tree Feedback
#13Funny but Azure Repos actually has had this feature for a while. When I first joined Microsoft I was shocked that all our teams used Azure Repos instead of GitHub considering we own GitHub but as I've used Repos more and more I've actually come to like it more than GitHub itself. A lot of the UI is cleaner and more intuitive than GitHub to me now, maybe just from using it a lot.
Agree, I really prefer DevOps' PR experience. I'm just missing the easy GitHub ci Integrations (3rd party checks & bots that post comments for example). It probably also exists for DevOps, but I never came across of it
Re: Pull Request File Tree Feedback
#14Display performance switching between files in Safari is terrible on very large PRs. I don't know what it could be doing. Maybe something to do with text reflow? But it's almost unusable.
Re: Pull Request File Tree Feedback
#15Not sure if this is well known, but press period `.` when viewing a PR, repo, or file and github will send you to a in-browser visual code editor. Able to make commits in there too, perfect for [nit] comments
if you press it from a PR you'll get the vscode PR viewer which is way nicer than Github's (IMO, especially for larger PRs) the only thing missing is the ability to switch between changes from last commit, last review, etc.
Re: Pull Request File Tree Feedback
#16Bitbucket Server and Gitlab have this feature and it's quite useful for very large pull requests as you can easily see the folder structure of the file you're reviewing, for that bit extra bit of visual context. Bitbucket's search box is slightly better because it also does a code search within the PR, it helps you quickly find specific words (say, a class name) across all the changed files. Gitlab's only does a file…
Gitlab and big PR aren't a great experience. Impossible to scroll -- it's so slow
Re: Pull Request File Tree Feedback
#17I’d settle for them making PRs as useful as they were in 2015, before they messed up some of the most basic functionality: showing the diff, and showing review comments. They hide big diffs behind a “load more” link, and as a result people often fail to code review the most substantial part of a change because they scan right past it, thinking it’s a removed file or binary or something. Then, once you submit a review, they only show 10 comments. In the middle, there’s an easy-to-miss “load more comments” button.
These are the two most fundamental features of a PR. How could they decide so few as 10 is the right number of comments?
Re: Pull Request File Tree Feedback
#18Bitbucket Server and Gitlab have this feature and it's quite useful for very large pull requests as you can easily see the folder structure of the file you're reviewing, for that bit extra bit of visual context. Bitbucket's search box is slightly better because it also does a code search within the PR, it helps you quickly find specific words (say, a class name) across all the changed files. Gitlab's only does a file…
If only Bitbucket Cloud would play catchup now. So many times I read about a bitbucket feature to only find out it is server only and we can't use it.
I believe Bitbucket Cloud and Bitbucket Server/Datacenter (nee Stash) are still two completely separate codebases that just happen to share a name.
Re: Pull Request File Tree Feedback
#19What's ironic is that discussion pages, like the one linked here, are broken on mobile. Maybe they should focus on that first.
Also, I hate repos that convert issues to discussions. Might as well close the issue, as discussion is usually a graveyard.
Re: Pull Request File Tree Feedback
#20I’d settle for them making PRs as useful as they were in 2015, before they messed up some of the most basic functionality: showing the diff, and showing review comments. They hide big diffs behind a “load more” link, and as a result people often fail to code review the most substantial part of a change because they scan right past it, thinking it’s a removed file or binary or something. Then, once you submit a review…
Hiding of the large files has tripped me up multiple times. I've starting having to look at the diffs outside github's UI