11–20 of 238 posts
There's no way that Google would actually use this service.
(In this case, they seem to be claiming Google engineers are moonlighting as reviewers, not using the service for reviewing Google’s code.)
There's no way that Google would actually use this service.
SaaS apps tend to slap a logo up when there’s a single free trial account with a @google.com email address. (In this case, they seem to be claiming Google engineers are moonlighting as reviewers, not using the service for reviewing Google’s code.)
Thanks, I hate it.
Interested to know if anyone has used this service or similar and what the quality is like.
It is new to me, but raises a concern that they could only review for general engineering quality, not whether or not a PR is appropriate to a codebase. How would they know if the same problem has already been solved elsewhere, that no wheels are being re-invented, or that a PR is stepping on the toes of something else the team is working on. Because that is the value I've found in code reviews - not generic "is this…
As you said, the big value in reviews are the points you mentioned. Correctness/technical quality certainly has value, but at $700/dev/month the reviews better be really good. Especially since doing it internally has value as well (knowledge sharing in particular).
Having on-demand engineers look at code, without broader context on the project it is in my view the same as something that can be automated either or both via static analysis and custom ci/cd workflow checks. This can probably makes sense on a project with more junior engineers where many basic improvements can be supposedly suggested without needing broader context? I would be keen on hearing the use case
And no, you can’t write programs to do this.
There's no way that Google would actually use this service.
SaaS apps tend to slap a logo up when there’s a single free trial account with a @google.com email address. (In this case, they seem to be claiming Google engineers are moonlighting as reviewers, not using the service for reviewing Google’s code.)
https://techcrunch.com/2017/12/07/pullrequest-pulls-in-2-3m-...
I will admit that I thought this was a joke on the "SaaS" everything trend. I can see how this works for fairly limited web applications for example, but as soon as the application grows in complexity and interacts within a bigger system of systems, I am doubtful that it would be logistically possible to outsource the code review (legally, knowledge transfer wise, and a plethora of other angles I'm a tad bit lazy to…
Afterwards you have individual components that have their code reviews and still need to follow industry best practices. I think external code reviews is great idea as it could allow the team to focus more on conceptual reviews and consequences to other systems.