Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

OCaml: Add support to iOS/Mac ARM64

github.com

Post reply on HN
Print view View original

11–20 of 103 posts

Re: OCaml: Add support to iOS/Mac ARM64

#11

Post by outadoc »

momothereal wrote: post #7
alderz wrote: post #3

By reading the stream of comments on the PR, and from my own experience, I feel that it is extremely cumbersome to do code reviews on Github. Atlassian's Fisheye/Crucible looks like a better solution. Does anyone think otherwise? I think Github has a large room of improvement in this regard; a PR is not the same as an issue.

I've been using GitHub for code review (both open-source and commercial projects) for about 5 years. It's improved a little bit, but for PRs with >100 files changed it's obviously lacking good UX. For me, the biggest improvement would be the tree-view you get in Fisheye/Crucible. It's so hard to get a grasp on large refactoring PRs on GitHub.

This extension [1] makes code reviews more bearable, I highly recommend it. I don't understand why Github hasn't shipped this years ago. They've been improving the UX since their acquisition but there's still a long ways to go.

[1]: https://addons.mozilla.org/en-US/firefox/addon/better-pull-r...

Re: OCaml: Add support to iOS/Mac ARM64

#12

Post by saagarjha »

If one was ever curious why the security research device program should have been open to everyone and available without restrictions: part of this work was done on a jailbroken iOS device and QEMU. I doubt anyone would have been able put in that work had they not had access to that.

Re: OCaml: Add support to iOS/Mac ARM64

#13

Post by EduardoRFS »

saagarjha wrote: post #12

If one was ever curious why the security research device program should have been open to everyone and available without restrictions: part of this work was done on a jailbroken iOS device and QEMU. I doubt anyone would have been able put in that work had they not had access to that.

There was a previous PR where I got the overall patches needed, but almost everything was developed on the iOS + QEMU, at first I didn't had spare money to buy an used iPhone.

The only feature developed on the real iPhone was the dynamic linking, but because I already got the device.

Also I don't have a mac so Hackintosh, a powerful Hackintosh but nonetheless

Re: OCaml: Add support to iOS/Mac ARM64

#14

Post by emmelaich »

aspenmayer wrote: post #8
ChrisMarshallNY wrote: post #6

Earlier quoted context omitted.

I don't feel like GH is really meant to be a code review platform. It does PRs, but I assume that review should be done offline (like in other tools, like Crucible). We have used GH as a review platform for an open-source project, but they tend to be relatively minor PRs. If they got hairier, we'd probably find something else. Personally, I really don't like having a gazillion different tools. If we can use one tool…

Is there a good self-hosted open source platform for this? I’m new to all this, even though I’ve been computing since I was in grade school. Coding is a new discipline for me, and it’s hard to know the territory without a guide. I’ve seen you around and would trust a recommendation from you.

I suggest https://www.gerritcodereview.com/

Re: OCaml: Add support to iOS/Mac ARM64

#15

Post by MaxBarraclough »

alderz wrote: post #3

By reading the stream of comments on the PR, and from my own experience, I feel that it is extremely cumbersome to do code reviews on Github. Atlassian's Fisheye/Crucible looks like a better solution. Does anyone think otherwise? I think Github has a large room of improvement in this regard; a PR is not the same as an issue.

You might be interested in Torvalds' low opinion of GitHub pull-requests.

https://github.com/torvalds/linux/pull/17#issuecomment-56599...

Discussed at:

https://news.ycombinator.com/item?id=3960876

https://old.reddit.com/r/programming/comments/tionj/

Re: OCaml: Add support to iOS/Mac ARM64

#16

Post by heavyset_go »

nindalf wrote: post #2

I think most programming languages and associated tools will start supporting ARM64 as a first class citizen. The current lack of support isn't due to apathy, just constraints around ARM64 not being popular for desktop development. For example, it's difficult to support a platform that isn't well supported by your CI/CD provider. Linus Torvalds previously said that ARM on the server would never be a thing since devel…

As someone who jumped on the ARM train early, and someone who doesn't want to contribute to creating more electronic waste than necessary, it's disheartening to see 32-bit ARM being increasingly ignored as a platform compared to ARM64.

Re: OCaml: Add support to iOS/Mac ARM64

#17

Post by fotta »

the_af wrote: post #10
momothereal wrote: post #7

Earlier quoted context omitted.

I've been using GitHub for code review (both open-source and commercial projects) for about 5 years. It's improved a little bit, but for PRs with >100 files changed it's obviously lacking good UX. For me, the biggest improvement would be the tree-view you get in Fisheye/Crucible. It's so hard to get a grasp on large refactoring PRs on GitHub.

I wonder how one does manage a PR with >100 files changed. I realize these are sometimes unavoidable, but shouldn't we strive for smaller PRs? No tool will help you with exploding complexity...

Usually with massive PRs of that sort I’ll have several smaller PRs to a separate branch that get reviewed so that everything in the massive PR to the main branch has already been reviewed and the big one is just a cursory look. But this approach probably isn’t as feasible with open source projects.

Re: OCaml: Add support to iOS/Mac ARM64

#18

Post by secondcoming »

alderz wrote: post #3

By reading the stream of comments on the PR, and from my own experience, I feel that it is extremely cumbersome to do code reviews on Github. Atlassian's Fisheye/Crucible looks like a better solution. Does anyone think otherwise? I think Github has a large room of improvement in this regard; a PR is not the same as an issue.

Agreed. We moved to GH from Bitbucket and code reviews is the only thing that Bitbucket did better.

Re: OCaml: Add support to iOS/Mac ARM64

#19

Post by wczekalski »

heavyset_go wrote: post #16
nindalf wrote: post #2

I think most programming languages and associated tools will start supporting ARM64 as a first class citizen. The current lack of support isn't due to apathy, just constraints around ARM64 not being popular for desktop development. For example, it's difficult to support a platform that isn't well supported by your CI/CD provider. Linus Torvalds previously said that ARM on the server would never be a thing since devel…

As someone who jumped on the ARM train early, and someone who doesn't want to contribute to creating more electronic waste than necessary, it's disheartening to see 32-bit ARM being increasingly ignored as a platform compared to ARM64.

ARM 32 bit is supported by OCaml. Just not for iOS/MacOS since the 32 bit iOS devices are ancient by now.
Post reply on HN