Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Launch HN: PullRequest (YC S17) – On-Demand Code Review

news.ycombinator.com

Post reply on HN
Print view View original

11–20 of 68 posts

Re: Launch HN: PullRequest (YC S17) – On-Demand Code Review

#11

Post by kevinSuttle »

lyal wrote: post #7
acconrad wrote: post #5

Awesome idea, just signed up to help out and review code! Is there an incentive / gamification system to reward strong reviewers so their reputation increases as they provide good feedback to companies?

Thanks! We're still early in our life cycle -- but on the roadmap is the creation of reviewer profiles (as an optional feature). This'll allow us to highlight strong reviewers, their projects, etc. Incentives and gamification are definitely there as well. We want to bonus people for doing thoughtful code review.

This is a big opportunity to create an entirely new specialized role. Could be very lucrative for people to make names for themselves.

Re: Launch HN: PullRequest (YC S17) – On-Demand Code Review

#12

Post by lyal »

kevinSuttle wrote: post #11
lyal wrote: post #7

Earlier quoted context omitted.

Thanks! We're still early in our life cycle -- but on the roadmap is the creation of reviewer profiles (as an optional feature). This'll allow us to highlight strong reviewers, their projects, etc. Incentives and gamification are definitely there as well. We want to bonus people for doing thoughtful code review.

This is a big opportunity to create an entirely new specialized role. Could be very lucrative for people to make names for themselves.

Completely agree! The idea of a 10x reviewer has been a big part of my thinking on creating this company (and the movement of specialization for review out of big tech companies into smaller engineering teams).

Re: Launch HN: PullRequest (YC S17) – On-Demand Code Review

#14

Post by lyal »

tcholas wrote: post #13

Congrats on building this product, guys. This tool is very interesting for startups that have only one developer and freelancers. However, a $49/month pricing may be quite expensive for these people.

Thanks! Pricing is a place we're working out details. We'd like to offer lower tiers for individuals/freelancers in the future for our static and automated tooling.

Re: Launch HN: PullRequest (YC S17) – On-Demand Code Review

#16

Post by fergie »

What are the benefits of reviewers over automated testing?

My workflow (which I believe is pretty standard) is:

* Write code

* Verify that tests pass locally (including stylistic tests, linting)

* Submit pull request

* Pull request triggers build and tests on Travis

* If all tests pass on Travis, code is stylistically and functionally correct

* Merge pull request

How can human reviewers improve this workflow?

Re: Launch HN: PullRequest (YC S17) – On-Demand Code Review

#17

Post by sz4kerto »

fergie wrote: post #16

What are the benefits of reviewers over automated testing? My workflow (which I believe is pretty standard) is: * Write code * Verify that tests pass locally (including stylistic tests, linting) * Submit pull request * Pull request triggers build and tests on Travis * If all tests pass on Travis, code is stylistically and functionally correct * Merge pull request How can human reviewers improve this workflow?

> If all tests pass on Travis, code is stylistically and functionally correct

Passing tests don't prove that

- tests are covering all functional criteria required

- the code doesn't add 'technical debt', i.e. structural problems that will have to be refactored/worked around in the future.

Re: Launch HN: PullRequest (YC S17) – On-Demand Code Review

#18

Post by maaaats »

fergie wrote: post #16

What are the benefits of reviewers over automated testing? My workflow (which I believe is pretty standard) is: * Write code * Verify that tests pass locally (including stylistic tests, linting) * Submit pull request * Pull request triggers build and tests on Travis * If all tests pass on Travis, code is stylistically and functionally correct * Merge pull request How can human reviewers improve this workflow?

Those things have nothing to do with a PR, other than maybe a PR being a good way to say "this is done, let's automatically verify it".

A PR is about showing the rest of the team the changes so more than one person knows how stuff work and what's going on in the code base. And for the rest of the team to give feedback on stuff like how the feature was architected, not to nitpick on indenting.

Re: Launch HN: PullRequest (YC S17) – On-Demand Code Review

#20

Post by overcast »

Dang. One of the most painful things to do in this field, is dig through someones code. I don't even like figuring out MY old code. I'm surprised reviewers are voluntarily submitting themselves to this torture :D Cool program though, hope it takes off for you.
Post reply on HN