Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Contributing to Open Source projects

brad.livejournal.com

Post reply on HN
Print view View original

11–20 of 23 posts

Re: Contributing to Open Source projects

#11

Post by jrockway »

krainboltgreene wrote: post #6
jrockway wrote: post #2

Github solved this problem. Everyone knows how to contribute to a Github project. Click the fork button, commit your patch, send pull request.

I wonder if you're being sarcastic? Had you said that to me two weeks ago I wouldn't know what the hell "fork", "commit", and "pull" had to do with contributing. Git is hardly the end all be all .

Huh? How much software do you write?

All I know is that I get a few patches a week from people I've never heard of, thanks to Github. I can even anticipate them in advance, since I can see who has forks of my project, and what they've committed.

For those of us that are able to learn about simple concepts, Github has been a godsend. It has never been easier to share code.

And no, I am not being sarcastic, nor was my original post.

Re: Contributing to Open Source projects

#12

Post by jrockway »

apsurd wrote: post #8
krainboltgreene wrote: post #6

Earlier quoted context omitted.

I wonder if you're being sarcastic? Had you said that to me two weeks ago I wouldn't know what the hell "fork", "commit", and "pull" had to do with contributing. Git is hardly the end all be all .

what's nice about needing to learn what fork, commit, and pull are, is a nice barrier to entry for developers to contribute. This is counter-intuitive since as many people should get involved as possible. But this is more true for things like spotting bugs or user testing and much less for actually contributing code.

What's there to learn? You just click buttons in a web interface. Click fork, click "edit", click "save", click "send pull request". It's like Web 2.0 for free software...

Re: Contributing to Open Source projects

#13

Post by techiferous »

krainboltgreene wrote: post #6
jrockway wrote: post #2

Github solved this problem. Everyone knows how to contribute to a Github project. Click the fork button, commit your patch, send pull request.

I wonder if you're being sarcastic? Had you said that to me two weeks ago I wouldn't know what the hell "fork", "commit", and "pull" had to do with contributing. Git is hardly the end all be all .

"Git is hardly the end all be all."

Not sure if that was a typo, but in case it wasn't: git is version control software, and github is a web app that allows you to host and manage git repositories (and open-source repo hosting is free).

Re: Contributing to Open Source projects

#14

Post by treeform »

jrockway wrote: post #2

Github solved this problem. Everyone knows how to contribute to a Github project. Click the fork button, commit your patch, send pull request.

I don't think Github solved it. Many open source projects don't use Github. Github has made great leeway in the right direction but its not the end.

Re: Contributing to Open Source projects

#15

Post by krainboltgreene »

techiferous wrote: post #13
krainboltgreene wrote: post #6

Earlier quoted context omitted.

I wonder if you're being sarcastic? Had you said that to me two weeks ago I wouldn't know what the hell "fork", "commit", and "pull" had to do with contributing. Git is hardly the end all be all .

"Git is hardly the end all be all." Not sure if that was a typo, but in case it wasn't: git is version control software, and github is a web app that allows you to host and manage git repositories (and open-source repo hosting is free).

Yes, it was a typo.

Re: Contributing to Open Source projects

#16

Post by davidw »

jrockway wrote: post #2

Github solved this problem. Everyone knows how to contribute to a Github project. Click the fork button, commit your patch, send pull request.

No it hasn't. It helps, it's a nice tool, but it does not take the place of human communication, which is essential. You can't just send someone a 'pull request' without explaining why you want to do it, what it's for and so on.

And you should really be doing that in a publicly archived, visible place.

Re: Contributing to Open Source projects

#17

Post by jrockway »

jamesbritt wrote: post #9
krainboltgreene wrote: post #6

Earlier quoted context omitted.

I wonder if you're being sarcastic? Had you said that to me two weeks ago I wouldn't know what the hell "fork", "commit", and "pull" had to do with contributing. Git is hardly the end all be all .

Even for people git-aware, there's a bit more involved. Most people are probably happy to get patch submissions, but there's some work involved in accepting them. Generally, project owners want to see a test accompany any change to demonstrate that a bug was fixed or that new behavior does what's claimed. There may also be coding standards to follow, and (ideally) some documentation for new code. If you omit these th…

Generally, project owners want to see a test accompany any change to demonstrate that a bug was fixed or that new behavior does what's claimed. There may also be coding standards to follow, and (ideally) some documentation for new code.

If the project owner really wants the patch, they will fix these details themselves. In my experience this is how project owners reject patches that they don't want; make the submitter do more work than he is willing to so that the patch silently dies.

Personally, I will usually ask a submitter for a test case and some docs... but if I don't hear from them (or hear, "works for me, no time"), I will just write them myself. Same for style issues; easier to just fix them myself, then I know that the style is exactly what I want.

Github, at the very least, eliminates any technical reason not to contribute. Social issues are largely the same; although back-and-forth is a lot easier when you both have access to a public repository. (Who likes attaching the 8th iteration of a patch to email? Not me.)

Re: Contributing to Open Source projects

#18

Post by jrockway »

davidw wrote: post #16
jrockway wrote: post #2

Github solved this problem. Everyone knows how to contribute to a Github project. Click the fork button, commit your patch, send pull request.

No it hasn't. It helps, it's a nice tool, but it does not take the place of human communication, which is essential. You can't just send someone a 'pull request' without explaining why you want to do it, what it's for and so on. And you should really be doing that in a publicly archived, visible place.

And you should really be doing that in a publicly archived, visible place.

The commit message.

Re: Contributing to Open Source projects

#19

Post by davidw »

jrockway wrote: post #18
davidw wrote: post #16

Earlier quoted context omitted.

No it hasn't. It helps, it's a nice tool, but it does not take the place of human communication, which is essential. You can't just send someone a 'pull request' without explaining why you want to do it, what it's for and so on. And you should really be doing that in a publicly archived, visible place.

And you should really be doing that in a publicly archived, visible place. The commit message.

Which is why traffic has stopped on the linux kernel mailing list, despite being long time users of git? Nope. All serious open source projects have some sort of discussion area. Even github lets you comment on commits, but that's not quite as convenient to read for most people as a publicly visible mailing list/forum/whatever.

Git is a nice tool, but you can't take things to extremes. It is not a substitute for actual discussion. What happens when the patch is 'pretty good', but not quite right and both people are willing to work on it? It just gets discussed in commit messages? No, it goes to a mailing list, especially when it's a larger project with many interested parties. This is pretty elementary open source stuff:-/

Where you're completely correct is that git and github make it easier to contribute 'at the margins'. In the sense that what once may have simply lain idle on one's own hard drive is easier to simply throw at some project in the hopes that they can do something useful with it.

Re: Contributing to Open Source projects

#20

Post by jrockway »

davidw wrote: post #19
jrockway wrote: post #18

Earlier quoted context omitted.

And you should really be doing that in a publicly archived, visible place. The commit message.

Which is why traffic has stopped on the linux kernel mailing list, despite being long time users of git? Nope. All serious open source projects have some sort of discussion area. Even github lets you comment on commits, but that's not quite as convenient to read for most people as a publicly visible mailing list/forum/whatever. Git is a nice tool, but you can't take things to extremes. It is not a substitute for actu…

When your project's size warrants it, you can switch from pull requests to an off-site mailing list. But most projects never get there, and so pull requests are quite useful for the long tail.

I remember back in the sourceforge day, most projects died before they ever got a mailing list, CVS account, web page, wiki, bug tracker, ..., all setup. Now, reasonable defaults are provided for you, and you can focus on writing the code. Once your project has a bunch of contributers that are all working on time-consuming projects... then you can invest some time in moving away from the defaults. But if you project is like most and has 3 users, you won't have to waste your time.

Post reply on HN