Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

More code review tools

github.com

Post reply on HN
Print view View original

11–20 of 151 posts

Re: More code review tools

#11

Post by Hovertruck »

numbsafari wrote: post #4

I'd love it if there was a way for me to queue my comments before submitting. I often keep my comments in a separate textedit/nv window and then go back to put them in since I want to keep track of questions that arise as I'm reading, but I don't want to pepper someone with comments that would be resolved 200 lines later in the diff.

Yeah this is my #1 feature request, and the main reason that a number of companies I've worked for/chatted with have switched to using Phabricator for their code review.

Re: More code review tools

#12

Post by morinted »

willchen wrote: post #6

Does anybody else feel like GitHub has released more features in the last month than the last 6 months? I'm not sure if it's just a coincidence with all the attention they've gotten on HN, but these improvements are much appreciated!

It was probably in reaction to the Dear GitHub letter. People were considering migrating away from GitHub and so they got their hands out of their pockets. We all benefit, though, GitHub becomes a better platform for us and they probably become a more successful company.

Re: More code review tools

#13

Post by hwangmoretime »

Code review is something all of us do, but all of us do differently. Anyone know of any nice frameworks, articles, or blog posts for code review? I'm particularly interested in the case where knowledge transfer is a high priority in the code review.

My current side project integrates feedback theory [1], to provide scaffolds and other cues to help and remind reviewers to give high quality feedback. Thus, my interest.

1: https://scholar.google.com/scholar?q=%22The+Effects+of+Feedb...

Re: More code review tools

#14

Post by moby »

avolcano wrote: post #3
danpalmer wrote: post #2

This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. These changes look great, I just hope that we get some sort of checking-off of review points, and accept/reject functionality.

I wonder if there's a set of API hooks they could expose to allow third party applications to handle more advanced code review techniques? I would totally understand GitHub not wanting to implement a full Phabricator/Gerrit review feature set, but maybe they could make it easier to integrate other services for it.

That's a great thought. For my own edification, which third party apps come to mind?

At present, the "official" collaboration tools in the GitHub integrations directory are here: https://github.com/integrations/feature/collaborate

Re: More code review tools

#15

Post by nathankleyn »

erichurkman wrote: post #7
danpalmer wrote: post #2

This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. These changes look great, I just hope that we get some sort of checking-off of review points, and accept/reject functionality.

I'd love a UI way to enable `?w=1` whitespace mode, especially for html/json/yaml files. I have a feeling a lot of reviewers don't know about it and spend an inordinate amount of time squinting to see what changes when it was a whitespace-only change.

Some similar option for enabling patience diffing as well would be amazing. Those two options in combination would certainly make a not insignificant amount of PRs much more readable.

Re: More code review tools

#16

Post by [deleted] »

faitswulff wrote: post #9
danpalmer wrote: post #2

This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. These changes look great, I just hope that we get some sort of checking-off of review points, and accept/reject functionality.

It's interesting that you mention checking off of review points. I had begun to do that in an informal fashion by updating my pull request with notes in the form of a checklist: - [x] Refactor _ - [ ] Rename variable x - [ ] ... Now that you mention it, it would be very nice to have something like Google Docs's ability to mark comments as resolved.

[deleted]

Re: More code review tools

#17

Post by softawre »

vdnkh wrote: post #8
pearlsteinj wrote: post #5

I've been pleasantly surprised at how fast Github has been moving since that critical open letter came out. For a giant company like Github they've been releasing developer tools very quickly.

Makes you question what exactly they were doing before the letter came out.

Taking naps in big piles of cash? Heh.. Enterprise-only stuff?

Re: More code review tools

#19

Post by smaili »

willchen wrote: post #6

Does anybody else feel like GitHub has released more features in the last month than the last 6 months? I'm not sure if it's just a coincidence with all the attention they've gotten on HN, but these improvements are much appreciated!

Definitely not a coincidence. Although it certainly begs the question of why this wasn't done earlier given the sheer amount of capital they have.

Re: More code review tools

#20

Post by Karunamon »

smaili wrote: post #19
willchen wrote: post #6

Does anybody else feel like GitHub has released more features in the last month than the last 6 months? I'm not sure if it's just a coincidence with all the attention they've gotten on HN, but these improvements are much appreciated!

Definitely not a coincidence. Although it certainly begs the question of why this wasn't done earlier given the sheer amount of capital they have.

I'm guessing they didn't realize how annoyed people were. There's a pretty big gulf between "we hear complaints about X" (every company is going to have complaints about their product) and "lots of people, very well known ones, are complaining about X, we should do something about it"
Post reply on HN