Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Git-appraise: Distributed code review system for Git repos

github.com

Post reply on HN
Print view View original

11–20 of 30 posts

Re: Git-appraise: Distributed code review system for Git repos

#11

Post by cjbprime »

pm90 wrote: post #6

How does this compare w.r.t Gerrit? I see that an advantage is that it doesn't require server-side setup. But wouldn't one require some sort of central repo to coordinate code reviews and CI tests?

It does the code reviews in a distributed way. It just needs a central Git repo, but not a central code review server.

CI tests could work in a similar way! Each CI runner is polling for new commits, running tests against them, and pushing the results as git-notes in the Git repo, just like for the reviews.

Re: Git-appraise: Distributed code review system for Git repos

#12

Post by secure »

I can’t find any mention of GUI frontends for git-appraise.

While I prefer to write code in my terminal, I like to switch settings for reviewing code — with GitHub’s Pull Requests, I can just do it in the browser. Can I use git-appraise in my browser? Is there a stand-alone tool?

Re: Git-appraise: Distributed code review system for Git repos

#14

Post by amiraliakbari »

e40 wrote: post #10
pm90 wrote: post #6

How does this compare w.r.t Gerrit? I see that an advantage is that it doesn't require server-side setup. But wouldn't one require some sort of central repo to coordinate code reviews and CI tests?

To me it looks like something that could be used to implement Gerrit, but it doesn't come close to what Gerrit offers, having used it for a few years now. Gerrit is excellent at what it does.

I like Gerrit features, but it always seemed too complicated to integrate into usual coding workflow, especially with people always even complaining about git being "hard to use". This tools seems simpler compared to Gerrit, and more flexible compared to GitHub pull requests.

I would appreciate advices on introducing Gerrit to my team and make it somehow transparent in development workflow.

Re: Git-appraise: Distributed code review system for Git repos

#15

Post by dominotw »

jonahx wrote: post #13

Upvoted because this looks cool and I'm definitely your target audience. The README doesn't give me a great sense of how this actually works, though. A 5 minute video, or even a hypothetical example with some screenshots intermixed, would help a lot.

https://github.com/google/git-appraise-eclipse

Re: Git-appraise: Distributed code review system for Git repos

#17

Post by dominotw »

secure wrote: post #12

I can’t find any mention of GUI frontends for git-appraise. While I prefer to write code in my terminal, I like to switch settings for reviewing code — with GitHub’s Pull Requests, I can just do it in the browser. Can I use git-appraise in my browser? Is there a stand-alone tool?

https://github.com/google/git-appraise-eclipse

Re: Git-appraise: Distributed code review system for Git repos

#18

Post by [deleted] »

dominotw wrote: post #15
jonahx wrote: post #13

Upvoted because this looks cool and I'm definitely your target audience. The README doesn't give me a great sense of how this actually works, though. A 5 minute video, or even a hypothetical example with some screenshots intermixed, would help a lot.

https://github.com/google/git-appraise-eclipse

[deleted]

Re: Git-appraise: Distributed code review system for Git repos

#19

Post by bjackman »

pm90 wrote: post #6

How does this compare w.r.t Gerrit? I see that an advantage is that it doesn't require server-side setup. But wouldn't one require some sort of central repo to coordinate code reviews and CI tests?

This seems to be extremely different to Gerrit. Gerrit requires a centralised server which acts in place of a regular git server. It has its own database, distinct from git, and adds the notion of a "Change ID". Generally you do your review through a web interface. It's all quite clunky, but it does its job very well.

This is distributed but more importantly it looks like it's more entangled/in-tune with git. It says it uses git notes [1], which appeals to me; they're a feature that are basically useless on their own, but seem to be included exactly for the use of something like git-appraise.

Regarding your comment about a central repo, I'd guess the idea is you use git-appraise like you use git today; it's decentralised in the technical layers, but you assign "central" repo in the human workflow layer.

[1] http://git-scm.com/docs/git-notes

Re: Git-appraise: Distributed code review system for Git repos

#20

Post by ktt »

What's interesting is that this project seems to be using itself for code review.

Clone the repo and then fetch notes manually:

    git fetch origin refs/notes/*:refs/notes/*
After installing it through "go get" check existing code reviews with "git appraise list".

There are notes from Jenkins and comments from developers as far as I can see.

Seems to be a little bit slow on my computer but the idea is really brilliant.

Post reply on HN