Linthub: Static code analysis for GitHub pull requests

#1

Post by nl5874 » Wed, Feb 04, 2015, 9:52 AM UTC

Linthub: Static code analysis for GitHub pull requests
linthub.io

Re: Linthub: Static code analysis for GitHub pull requests

#2

Post by zidar » Wed, Feb 04, 2015, 10:40 AM UTC

This looks pretty awesome and will just get better as more languages get supported. But, it comments on commits, not on the diff in the PR. I think commeting on the diff looks nicer (you see code snippet with the comment) and in my opinion it's also easyer to find all the comments that way. Instead of clicking the commit hash on the commen each time.

Re: Linthub: Static code analysis for GitHub pull requests

#3

Post by nl5874 » Wed, Feb 04, 2015, 10:45 AM UTC

zidar wrote: post #2

This looks pretty awesome and will just get better as more languages get supported. But, it comments on commits, not on the diff in the PR. I think commeting on the diff looks nicer (you see code snippet with the comment) and in my opinion it's also easyer to find all the comments that way. Instead of clicking the commit hash on the commen each time.

Thanks! Will check and handle this.

Re: Linthub: Static code analysis for GitHub pull requests

#4

Post by jbrooksuk » Wed, Feb 04, 2015, 10:52 AM UTC

So this is like Hound[1]? - I am (kinda) building something for PHP, Anorak[2] which uses something else I built.

What's your plan on this? I'd like to use it for our private repositories.

Edit: My web hooks are returning errors. I'll submit some feedback.

[1] https://houndci.com

[2] https://github.com/jbrooksuk/anorak

Re: Linthub: Static code analysis for GitHub pull requests

#5

Post by nl5874 » Wed, Feb 04, 2015, 11:00 AM UTC

jbrooksuk wrote: post #4

So this is like Hound[1]? - I am (kinda) building something for PHP, Anorak[2] which uses something else I built. What's your plan on this? I'd like to use it for our private repositories. Edit: My web hooks are returning errors. I'll submit some feedback. [1] https://houndci.com [2] https://github.com/jbrooksuk/anorak

It seems comparable, though we are supporting different languages. Plans are to support a lot more languages, and support private repos also. (Actually they are already supported, but linthubot needs to have read only access to the repository). All feedback is welcome.

Re: Linthub: Static code analysis for GitHub pull requests

#6

Post by jbrooksuk » Wed, Feb 04, 2015, 11:04 AM UTC

nl5874 wrote: post #5

jbrooksuk wrote: post #4

So this is like Hound[1]? - I am (kinda) building something for PHP, Anorak[2] which uses something else I built. What's your plan on this? I'd like to use it for our private repositories. Edit: My web hooks are returning errors. I'll submit some feedback. [1] https://houndci.com [2] https://github.com/jbrooksuk/anorak

It seems comparable, though we are supporting different languages. Plans are to support a lot more languages, and support private repos also. (Actually they are already supported, but linthubot needs to have read only access to the repository). All feedback is welcome.

Thanks! Are you planning on charging for this? I have an error, can I email you guys?

Edit: Nevermind, I found the support form.

Re: Linthub: Static code analysis for GitHub pull requests

#7

Post by nl5874 » Wed, Feb 04, 2015, 11:07 AM UTC

jbrooksuk wrote: post #6

nl5874 wrote: post #5

Earlier quoted context omitted.

It seems comparable, though we are supporting different languages. Plans are to support a lot more languages, and support private repos also. (Actually they are already supported, but linthubot needs to have read only access to the repository). All feedback is welcome.

Thanks! Are you planning on charging for this? I have an error, can I email you guys? Edit: Nevermind, I found the support form.

Currently no plans for charging. If we'll change these plans, existing repositories will stay free. Send an email to support@linthub.io for the error, and we'll check it immediatly.

Re: Linthub: Static code analysis for GitHub pull requests

#8

Post by nl5874 » Wed, Feb 04, 2015, 11:18 AM UTC

jbrooksuk wrote: post #6

nl5874 wrote: post #5

Earlier quoted context omitted.

It seems comparable, though we are supporting different languages. Plans are to support a lot more languages, and support private repos also. (Actually they are already supported, but linthubot needs to have read only access to the repository). All feedback is welcome.

Thanks! Are you planning on charging for this? I have an error, can I email you guys? Edit: Nevermind, I found the support form.

Error should be fixed, was an error due to redirect http to https.

Re: Linthub: Static code analysis for GitHub pull requests

#9

Post by remi » Wed, Feb 04, 2015, 11:35 AM UTC

Instead of using a service like this one (or Hound) that comments directly on pull requests, we chose to integrate the same tools in our build process with Phare (https://github.com/mirego/phare), a command-line tool we built which runs Rubocop, JSHint, JSCS, etc. and exits with a global status.

If the code has coding style violations, the build breaks. Exactly like it would if we pushed a failing test.

Personally, I’m not a fan of the noise generated by comments about coding style on pull requests.

Re: Linthub: Static code analysis for GitHub pull requests

#10

Post by hk__2 » Wed, Feb 04, 2015, 11:48 AM UTC

remi wrote: post #9

Instead of using a service like this one (or Hound) that comments directly on pull requests, we chose to integrate the same tools in our build process with Phare ( https://github.com/mirego/phare ), a command-line tool we built which runs Rubocop, JSHint, JSCS, etc. and exits with a global status. If the code has coding style violations, the build breaks. Exactly like it would if we pushed a failing test. Personally,…

I guess the advantage of Linthub over Phare is that it can run on pull requests made by external contributors.