Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Interactive Résumé of Robby Leonardi

rleonardi.com

Post reply on HN
Print view View original

1–10 of 22 posts

Re: Interactive Résumé of Robby Leonardi

#3

Post by onion2k »

It's a fun and cute resume, but delving in to the code you see things like;

  function blinkRobbyEyes()
  {
	if (layersMovement != "not moving 2")
	{
		$(robbyEyesCloseDiv).fadeTo(0,1);
		$(robbyEyesCloseDiv).stop().delay(300).animate({opacity: 0}, 0, function() {});
	}
  }
"if (layersMovement != "not moving 2")" is a boolean that should be passed as a parameter if you're ever going to write a working unit test against that function. Consequently, it shows a pretty poor knowledge of "making nice looking and maintainable HTML5 scrolly animations" in any sort of a real-life environment. Many people can make fancy webpages; someone with "the best resume ever" would be able to make fancy webpages with code that's relatively well abstracted in to testable, reusable functions.

Re: Interactive Résumé of Robby Leonardi

#5

Post by happywolf »

I am not sure this is the 'best', as a hiring manager in my work life, I won't be too impressed if this is the only piece of information delivered to me. It is a useful piece of reference nonetheless, but definitely cannot replace a regular normal resume.

Re: Interactive Résumé of Robby Leonardi

#7

Post by rimantas »

onion2k wrote: post #3

It's a fun and cute resume, but delving in to the code you see things like; function blinkRobbyEyes() { if (layersMovement != "not moving 2") { $(robbyEyesCloseDiv).fadeTo(0,1); $(robbyEyesCloseDiv).stop().delay(300).animate({opacity: 0}, 0, function() {}); } } "if (layersMovement != "not moving 2")" is a boolean that should be passed as a parameter if you're ever going to write a working unit test against that funct…

Maybe someone with "best resume ever" has a better understanding what and when if worth testing and not yet embraced cargo-cult testing? I'd be more worried about the massive pollution of the global namespace. That said I am not a fan of such resumes. They do show skill, but they usually don't show the ability to choose the right tool for the job.

Re: Interactive Résumé of Robby Leonardi

#8

Post by jebus989 »

onion2k wrote: post #3

It's a fun and cute resume, but delving in to the code you see things like; function blinkRobbyEyes() { if (layersMovement != "not moving 2") { $(robbyEyesCloseDiv).fadeTo(0,1); $(robbyEyesCloseDiv).stop().delay(300).animate({opacity: 0}, 0, function() {}); } } "if (layersMovement != "not moving 2")" is a boolean that should be passed as a parameter if you're ever going to write a working unit test against that funct…

He does only give himself three lobsters for jQuery

Re: Interactive Résumé of Robby Leonardi

#9

Post by Antwan »

onion2k wrote: post #3

It's a fun and cute resume, but delving in to the code you see things like; function blinkRobbyEyes() { if (layersMovement != "not moving 2") { $(robbyEyesCloseDiv).fadeTo(0,1); $(robbyEyesCloseDiv).stop().delay(300).animate({opacity: 0}, 0, function() {}); } } "if (layersMovement != "not moving 2")" is a boolean that should be passed as a parameter if you're ever going to write a working unit test against that funct…

Yeah, that's what I thought.

The animation are fun, but having reviewed main.js and style.css, he can't reasonably pretend he's a "master" in css/javascript.

Please write/amend some ECMA/CSS specs or hack rendering engines first to pretend to be so.

Re: Interactive Résumé of Robby Leonardi

#10

Post by Dirlewanger »

No, it's really not. It's tacky and takes too long to get all of the relevant details...and they're not even all in one place. Everything a resume should do, this does not. This being included in a sampling of workpieces is a different story.

Not to mention it's a repost.

Post reply on HN