PR process killing morale and productivity
blackentropy.com
PR process killing morale and productivity
1–10 of 224 posts
Re: PR process killing morale and productivity
#2Per the article, not the pull requests itself, but the tedious bikeshedding around them. The article's headline is a bit misleading.
Re: PR process killing morale and productivity
#3Watched a guy get fired mostly because he made code review such a nightmare for everyone else while getting lapped by everyone in terms of actual output. I’m not sure there’s much to be done once you’ve hit “toxic.” The only question is whether the standard can be reset for the whole team.
Re: PR process killing morale and productivity
#4GIT seams to be optimized for network of trust. With one person at the top approving what gets merged into the release.
This person of course does not do all of the verification, other then broad strokes of what the change does, and who wrote it, reviewed it and tested it.
I feel like companies do not want a large tree like structure for their development teams.
Without a network of trust it can become mob rule, which is what this article appears to be describing.
Re: PR process killing morale and productivity
#5> I’ve recently come across a discussion where a new developer joined a team and faced over 300 PR comments on their first contribution. Most of it was stylistic nitpicking. This isn’t just unproductive, it’s outright toxic.
For me this says more about the company culture than any inherent flaws with the code review process.
Re: PR process killing morale and productivity
#6Per the article, not the pull requests itself, but the tedious bikeshedding around them. The article's headline is a bit misleading.
That's probably what they mean by "PR Process"?
Re: PR process killing morale and productivity
#7I've worked with plenty of devs who embody the toxicity here, lots of stylistic nitpicks and don't see the big picture. All the noise generated distracts from catching the important stuff.
Re: PR process killing morale and productivity
#8...just how big was that "first ever contribution" pull request that it gathered 300 comments? My first commit in the current company was a 2-liner addition to an existing function plus another 20 lines for a test that verified that indeed, the change does affect the outcome.
Re: PR process killing morale and productivity
#9> I’ve recently come across a discussion where a new developer joined a team and faced over 300 PR comments on their first contribution. Most of it was stylistic nitpicking. This isn’t just unproductive, it’s outright toxic. For me this says more about the company culture than any inherent flaws with the code review process.
on a different side: it also tell you (a lot) about specific people.
I've seen good/great people call out the nitpicks (in my case it was often mis-spelling, due to not being a native speaker of english) but will approve the PR anyway (implicitly expecting another revision to be sent, trusting the submitter).
On the other hand bad/toxic people will drown you with stylistic nitpicks and won't approve (and trust) you to do your best work. You will be essentially blocked pending their approval (so that nitpicks are changed according to their likings).
The weird thing is that all this traceability leaves traces for management to see who's doing a good pr review job and who's not... But I've learned that management usually does not care much.
Re: PR process killing morale and productivity
#10Recently I allowed everyone in my team to push to develop without PRs and even without doing feature branches. We review the code all together (max 2 ppl) just before the release and that's it. But great CI pipeline is must for this. It will get even better soon when AI will be able to slightly refactor the code.