Git-appraise – Distributed Code Review for Git
1–10 of 173 posts
Re: Git-appraise – Distributed Code Review for Git
#2Needs a vscode plugin/integration
Re: Git-appraise – Distributed Code Review for Git
#3> This design removes the need for any sort of server-side setup.
So what, I just write code reviews to myself? What happens when I want to review other peoples’ code? Where do I get it from? And when they want to read my comments, do I invite them over to my computer?
Re: Git-appraise – Distributed Code Review for Git
#4> This design removes the need for any sort of server-side setup. So what, I just write code reviews to myself? What happens when I want to review other peoples’ code? Where do I get it from? And when they want to read my comments, do I invite them over to my computer?
I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests.
https://github.com/google/git-appraise/blob/master/docs/tuto...
A trivial git-hook could be setup for automating email notifications: https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks
EDIT: add link to git-hooks docs.
Re: Git-appraise – Distributed Code Review for Git
#5I know the main contributor to this. I'll flag him so he can answer any questions people might have.
Re: Git-appraise – Distributed Code Review for Git
#6> This design removes the need for any sort of server-side setup. So what, I just write code reviews to myself? What happens when I want to review other peoples’ code? Where do I get it from? And when they want to read my comments, do I invite them over to my computer?
It's in the first three paragraphs of the README...
> By "distributed", we mean that code reviews are stored inside of the repository as git objects. Every developer on your team has their own copy of the review history that they can push or pull.
Before the part you quoted. I feel like it'd be "nice" of me to suggest maybe you're being pedantic. Otherwise... ?
Re: Git-appraise – Distributed Code Review for Git
#7> This design removes the need for any sort of server-side setup. So what, I just write code reviews to myself? What happens when I want to review other peoples’ code? Where do I get it from? And when they want to read my comments, do I invite them over to my computer?
It's in the first three paragraphs of the README... > By "distributed", we mean that code reviews are stored inside of the repository as git objects. Every developer on your team has their own copy of the review history that they can push or pull. Before the part you quoted. I feel like it'd be "nice" of me to suggest maybe you're being pedantic. Otherwise... ?
[flagged]
Re: Git-appraise – Distributed Code Review for Git
#8> This design removes the need for any sort of server-side setup. So what, I just write code reviews to myself? What happens when I want to review other peoples’ code? Where do I get it from? And when they want to read my comments, do I invite them over to my computer?
I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests. https://github.com/google/git-appraise/blob/master/docs/tuto... A trivial git-hook could be setup for automating email notifications: https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks EDIT: add link to git-hooks docs.
> I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests.
How do they push without a server to host the repository?
Re: Git-appraise – Distributed Code Review for Git
#9Earlier quoted context omitted.
It's in the first three paragraphs of the README... > By "distributed", we mean that code reviews are stored inside of the repository as git objects. Every developer on your team has their own copy of the review history that they can push or pull. Before the part you quoted. I feel like it'd be "nice" of me to suggest maybe you're being pedantic. Otherwise... ?
[flagged]
You don't strictly need a central server, you just need an upstream path between the people involved in the PR.
Eg if two developers both served up the same repo from their local machine, and each had an upstream to the other, then this would work as a distributed PR.
And you could have any number of arbitrary nodes in that graph
Re: Git-appraise – Distributed Code Review for Git
#10Earlier quoted context omitted.
[flagged]
You don't strictly need a central server, you just need an upstream path between the people involved in the PR. Eg if two developers both served up the same repo from their local machine, and each had an upstream to the other, then this would work as a distributed PR. And you could have any number of arbitrary nodes in that graph
[deleted]