Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Pull Request File Tree Feedback

github.com

Post reply on HN
Print view View original

1–10 of 77 posts

Re: Pull Request File Tree Feedback

#2

Post by politelemon »

Bitbucket Server and Gitlab have this feature and it's quite useful for very large pull requests as you can easily see the folder structure of the file you're reviewing, for that bit extra bit of visual context. Bitbucket's search box is slightly better because it also does a code search within the PR, it helps you quickly find specific words (say, a class name) across all the changed files. Gitlab's only does a file name filter.

Though relatively late, I am glad it's coming to Github, more people can benefit from this kind of pull request presentation.

Re: Pull Request File Tree Feedback

#5

Post by guessmyname »

ydnaclementine wrote: post #4

Not sure if this is well known, but press period `.` when viewing a PR, repo, or file and github will send you to a in-browser visual code editor. Able to make commits in there too, perfect for [nit] comments

Yes, that is a well known feature introduced last year. I saw hundreds of people talking about it on Twitter and here on Hacker News.

Link for people who didn’t know about this feature: https://mobile.twitter.com/github/status/1425505817827151872 and the official documentation with other keyboard shortcuts: https://docs.github.com/en/get-started/using-github/keyboard...

Re: Pull Request File Tree Feedback

#6

Post by mrrsm »

politelemon wrote: post #2

Bitbucket Server and Gitlab have this feature and it's quite useful for very large pull requests as you can easily see the folder structure of the file you're reviewing, for that bit extra bit of visual context. Bitbucket's search box is slightly better because it also does a code search within the PR, it helps you quickly find specific words (say, a class name) across all the changed files. Gitlab's only does a file…

If only Bitbucket Cloud would play catchup now. So many times I read about a bitbucket feature to only find out it is server only and we can't use it.

Re: Pull Request File Tree Feedback

#8

Post by robbyking »

guessmyname wrote: post #5
ydnaclementine wrote: post #4

Not sure if this is well known, but press period `.` when viewing a PR, repo, or file and github will send you to a in-browser visual code editor. Able to make commits in there too, perfect for [nit] comments

Yes, that is a well known feature introduced last year. I saw hundreds of people talking about it on Twitter and here on Hacker News. Link for people who didn’t know about this feature: https://mobile.twitter.com/github/status/1425505817827151872 and the official documentation with other keyboard shortcuts: https://docs.github.com/en/get-started/using-github/keyboard...

I didn't know about it! I primary use a corporate hosted instance GitHub (so we often opt in to new features late), and I don't follow a lot of tech news on social media.

Re: Pull Request File Tree Feedback

#9

Post by alkonaut »

dandigangi wrote: post #3

One of the few things worth actually stealing from BitBucket. Lol

Since GitHub is owned by Microsoft and their other product has had this, I’m guessing it’s yet another copy-over like GitHub Actions was from Azure Pipelines.

Not sure how long it’s been in AzureDevOps but it could have been inspired from GitLab there I suppose.

Re: Pull Request File Tree Feedback

#10

Post by rat9988 »

guessmyname wrote: post #5
ydnaclementine wrote: post #4

Not sure if this is well known, but press period `.` when viewing a PR, repo, or file and github will send you to a in-browser visual code editor. Able to make commits in there too, perfect for [nit] comments

Yes, that is a well known feature introduced last year. I saw hundreds of people talking about it on Twitter and here on Hacker News. Link for people who didn’t know about this feature: https://mobile.twitter.com/github/status/1425505817827151872 and the official documentation with other keyboard shortcuts: https://docs.github.com/en/get-started/using-github/keyboard...

That doesn't make it well known though
Post reply on HN