New tools for open source maintainers

#1

Post by joeyespo » Wed, Apr 18, 2018, 7:52 PM UTC

New tools for open source maintainers
blog.github.com

Re: New tools for open source maintainers

#2

Post by Nullabillity » Wed, Apr 18, 2018, 8:33 PM UTC

The "retirement" feature is a good start, but oddly over-engineered. Just stop allowing username reuse, period!

Re: New tools for open source maintainers

#3

Post by ocdtrekkie » Wed, Apr 18, 2018, 9:13 PM UTC

Minimized comments (hot take): A fancy new feature for AMP developers to ignore serious security and openness concerns about AMP.

Namespace retirement: Agreed with Nullability, just disable username reuse, it causes a lot more oddities than just cloning projects from unknown sources, old comments link to incorrect users and the like, it's awful.

Accidental PR protection: So this won't affect anyone, if I read it correctly, who types something in the PR description? As long as that's the case, fine, but I definitely don't want to overly impose upon the drive-by contributor... as an occasional drive-by contributor. (Sometimes I fix spelling errors, someone's gotta do it.)

Re: New tools for open source maintainers

#4

Post by maxnoe » Wed, Apr 18, 2018, 9:13 PM UTC

Can someone explain the Pull Request restrictions?

What does: "the changes are not explained in the commit body" actually mean?

Is this opt in?

Re: New tools for open source maintainers

#5

Post by rurban » Wed, Apr 18, 2018, 9:31 PM UTC

maxnoe wrote: post #4

Can someone explain the Pull Request restrictions? What does: "the changes are not explained in the commit body" actually mean? Is this opt in?

I see this new feature as a bug.

If you don't like a pull request close it or ignore it. But disabling accidental and “drive-through” pull requests sounds very bad to me.

Re: New tools for open source maintainers

#6

Post by pietroalbini » Wed, Apr 18, 2018, 9:40 PM UTC

maxnoe wrote: post #4

Can someone explain the Pull Request restrictions? What does: "the changes are not explained in the commit body" actually mean? Is this opt in?

As far as I understood this means you can't create pull requests of branches you don't have push access to (for example other people's forks) unless you're a project collaborator. It shouldn't affect your own branches.

Re: New tools for open source maintainers

#7

Post by dfabulich » Wed, Apr 18, 2018, 9:59 PM UTC

The main thing I want to hide in minimized comments are "+1 fix this plz!" comments on bugs, comments that add nothing above and beyond a thumbs-up reaction.

The "reasons" Github offers for minimizing comments are: Spam, Abuse, Off Topic, Outdated, and Resolved. "+1" isn't exactly any of those. (I guess they're kinda "Spam" but they're not unsolicited commercial messages.)

Re: New tools for open source maintainers

#8

Post by chr1 » Wed, Apr 18, 2018, 10:05 PM UTC

rurban wrote: post #5

maxnoe wrote: post #4

Can someone explain the Pull Request restrictions? What does: "the changes are not explained in the commit body" actually mean? Is this opt in?

I see this new feature as a bug. If you don't like a pull request close it or ignore it. But disabling accidental and “drive-through” pull requests sounds very bad to me.

Sometimes people use compare view and accidentally create pull requests without description from branches on which they do not have any commits.

On popular projects this happens often enough to become annoyance for maintainers.

I don't see any case when opening a pull request from someone else's branch and without a description could be done intentionally.

Re: New tools for open source maintainers

#9

Post by ocdtrekkie » Wed, Apr 18, 2018, 10:15 PM UTC

dfabulich wrote: post #7

The main thing I want to hide in minimized comments are "+1 fix this plz!" comments on bugs, comments that add nothing above and beyond a thumbs-up reaction. The "reasons" Github offers for minimizing comments are: Spam, Abuse, Off Topic, Outdated, and Resolved. "+1" isn't exactly any of those. (I guess they're kinda "Spam" but they're not unsolicited commercial messages.)

Maybe the missing feature here is that GitHub should "just" automatically minimize +1 comments. Or even better, delete them without sending a notification to maintainers/watchers, and automagically have the user who posted it add a thumbs up to the original issue.

(Personally, I would consider them spam.)

Re: New tools for open source maintainers

#10

Post by handbanana » Wed, Apr 18, 2018, 10:15 PM UTC

rurban wrote: post #5

maxnoe wrote: post #4

Can someone explain the Pull Request restrictions? What does: "the changes are not explained in the commit body" actually mean? Is this opt in?

I see this new feature as a bug. If you don't like a pull request close it or ignore it. But disabling accidental and “drive-through” pull requests sounds very bad to me.

If I understand the changes correctly, I agree.