Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

frappe.github.io

Post reply on HN
Print view View original

61–70 of 92 posts

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#61

Post by silvestrov »

pratu16x7 wrote: post #6
polskibus wrote: post #3

Impressive! What are the supported browsers? What are your plans going forward?

Supported across all major browsers :) We've covered much ground on the most used charts (while the heatmap just happened to be something we needed) and have the basic components down. That'll facilitate putting in, say, more axis charts in future. We're sure of not running out of ideas, there are just so many chart types out there :D

> Supported across all major browsers

Please be more specific: Frappe Charts doesn't work in MSIE 11 which is the latest IE for Windows 7 which is used by a lot of enterprises.

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#62

Post by trevor-e »

handbanana wrote: post #41
harunurhan wrote: post #25

Looks nice, 0 dependency, simple design but there is one issue... I see that you don't have a single unit test or integration or functional etc. Even if your in house developers know what they are doing (which is a myth, stuff will break) it's going to be difficult accept contributions from community without any tests that make (almost) sure existing features are working with the changes.

I see where your coming from, but I disagree. This isn't a new OS, its a tiny charts library/utility. I'm more inclined to contribute because there are no tests. Either way, someone could PR tests if they wished. Perhaps your comment should have been such a PR? ;)

> Perhaps your comment should have been such a PR? ;)

I really hate seeing this used in discussion. Just because it's open source does not mean it's immune from criticism. Yes, technically some random HN'er could spend tens of hours writing unit tests and submit a PR, but really this is a task for the library author/maintainer.

Having tests is a measure of quality, and should be cared about if you want people using your library.

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#64

Post by joshwcomeau »

trevor-e wrote: post #62
handbanana wrote: post #41

Earlier quoted context omitted.

I see where your coming from, but I disagree. This isn't a new OS, its a tiny charts library/utility. I'm more inclined to contribute because there are no tests. Either way, someone could PR tests if they wished. Perhaps your comment should have been such a PR? ;)

> Perhaps your comment should have been such a PR? ;) I really hate seeing this used in discussion. Just because it's open source does not mean it's immune from criticism. Yes, technically some random HN'er could spend tens of hours writing unit tests and submit a PR, but really this is a task for the library author/maintainer. Having tests is a measure of quality, and should be cared about if you want people using y…

The library author has already invested probably hundreds of hours creating the library; if someone who benefits from it only has to spend tens of hours writing the unit tests, they've saved an order of magnitude of time.

We need to stop thinking of OSS as something we're entitled to, that if a stranger doesn't put in enough free labour we're allowed to complain about it. I try to view my dependencies as favours other people have done for me. You wouldn't nitpick about a lack of tests after someone wrote a whole charting library for you; you'd thank them and add your own tests.

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#65

Post by developer2 »

jazoom wrote: post #47

This looks great. Can I ask why you didn't use chart.js?

I would also appreciate an answer to this question. It's not about "why'd you reinvent the wheel", but rather that I suspect you must have found chart.js while searching for options and decided something was missing or could be improved. I am interested to know how they compare, to have an idea how seriously I should look into this new option.

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#67

Post by opmac »

sillysaurus3 wrote: post #30
harunurhan wrote: post #25

Looks nice, 0 dependency, simple design but there is one issue... I see that you don't have a single unit test or integration or functional etc. Even if your in house developers know what they are doing (which is a myth, stuff will break) it's going to be difficult accept contributions from community without any tests that make (almost) sure existing features are working with the changes.

Judge work by what it does, not by what it doesn't have. Like users, programmers don't care whether programs have tests as long as it does what it needs to do.

Speak for yourself... that's quite the generalization. I'm a programmer, and I care when something doesn't have tests, especially if it's my own code.

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#68

Post by keithnz »

The biggest thing I find missing from most charts is their ability to interactively and dynamically chart over a large data set.

I once found a chart ( can't find it again ) that was super ugly but had a nice scheme for dynamically loading and caching data at different zoom levels that made the chart very snappy

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#69

Post by bradknowles »

silvestrov wrote: post #61
pratu16x7 wrote: post #6

Earlier quoted context omitted.

Supported across all major browsers :) We've covered much ground on the most used charts (while the heatmap just happened to be something we needed) and have the basic components down. That'll facilitate putting in, say, more axis charts in future. We're sure of not running out of ideas, there are just so many chart types out there :D

> Supported across all major browsers Please be more specific: Frappe Charts doesn't work in MSIE 11 which is the latest IE for Windows 7 which is used by a lot of enterprises.

It works on iOS, and I think there are a lot more iPhones out there than win7 desktops. ;)
Post reply on HN