51–60 of 67 posts
sudo bash -c "curl https://raw.githubusercontent.com/ravachol/kew/main/install.sh | bash" Might as well run unsigned binaries straight from the internet. What is this, Windows?
Good point. Might be better to just have the commands installing the requirements for the different distros, in the readme.
Earlier quoted context omitted.
Yes, unfortunately it only works on Linux and FreeBSD. I should add that to the readme. EDIT: Added.
Why, though?
Earlier quoted context omitted.
Super weird to bring Windows into this, but, anyway? I actually really like these one liners even if they have greater potential for abuse.
It's not weird to mention the other os where downloading and blindly double-clicking a naked exe is the standard.
Defaulting to the only result in your library is perfectly reasonable, but it the case of a collision, what does it do?
My guess is that it runs through in a loop (I haven't looked at the code) and simply goes with the first result that it finds, but that doesn't cover all possible use cases.
Does it accept flags to deal with ambiguities? Defaulting to the only result in your library is perfectly reasonable, but it the case of a collision, what does it do? My guess is that it runs through in a loop (I haven't looked at the code) and simply goes with the first result that it finds, but that doesn't cover all possible use cases.
Does it accept flags to deal with ambiguities? Defaulting to the only result in your library is perfectly reasonable, but it the case of a collision, what does it do? My guess is that it runs through in a loop (I haven't looked at the code) and simply goes with the first result that it finds, but that doesn't cover all possible use cases.
Like you said, it just takes the first result it finds. There is -e for exact search, which solves some problems, but it's not a full blown solution.
Unlike the -e solution, it wouldn't make the command significantly more verbose than the default option.
You could also print a list of commands for the specific options (or allow for index based selection) in cases where there were collisions.
Earlier quoted context omitted.
Like you said, it just takes the first result it finds. There is -e for exact search, which solves some problems, but it's not a full blown solution.
I'm thinking {-s, -l, -a, -p} for {song, album, artist, playlist}. Unlike the -e solution, it wouldn't make the command significantly more verbose than the default option. You could also print a list of commands for the specific options (or allow for index based selection) in cases where there were collisions.
kew dir (sometimes it's necessary to specify it's a directory you want)
kew song (or a song)
kew list (or a playlist)
The directory can be an artist or an album, so there's still ambiguity there. But kew cannot differentiate between the two. It matches against files or against directories.
Trying to nix run it I get a ton of insecure warnings and it lists the CVEs Is this a nix thing (i'm unsure what freeimage-unstable is) error: Package ‘freeimage-unstable-2021-11-01’ in /nix/store/20yis5w6g397plssim663hqxdiiah2wr-source/pkgs/development/libraries/freeimage/default.nix:72 is marked as insecure, refusing to evaluate. Known issues: - CVE-2021-33367 - CVE-2021-40262 - CVE-2021-40263 - CVE-2021-40264 - CV…
"Buffer Overflow vulnerability in Freeimage v3.18.0 allows attacker to cause a denial of service via a crafted JXR file." I don't know how relevant these vulnerabilities are to kew, which isn't run across the network in any way, it just reads your local files. Thank you for bringing this to light. I don't know how feasible it is to use something other than freeimage though, gonna have to investigate.
Looks like a nice project, I like the terminal album art display :).
Earlier quoted context omitted.
I'm thinking {-s, -l, -a, -p} for {song, album, artist, playlist}. Unlike the -e solution, it wouldn't make the command significantly more verbose than the default option. You could also print a list of commands for the specific options (or allow for index based selection) in cases where there were collisions.
That's already mostly in. From the readme: kew dir (sometimes it's necessary to specify it's a directory you want) kew song (or a song) kew list (or a playlist) The directory can be an artist or an album, so there's still ambiguity there. But kew cannot differentiate between the two. It matches against files or against directories.